From patchwork Fri Jul 9 03:32:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fei Wang X-Patchwork-Id: 28871 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a5d:965a:0:0:0:0:0 with SMTP id d26csp270369ios; Thu, 8 Jul 2021 20:35:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzj5Bv/gPNYlsR0EqAkt2iMZbvJ8pdHxuzhuldBzo+ZlhEAoxTlfjlgzYNvNkBmfqfk8Ocz X-Received: by 2002:a17:906:71c1:: with SMTP id i1mr28868346ejk.549.1625801731129; Thu, 08 Jul 2021 20:35:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625801731; cv=none; d=google.com; s=arc-20160816; b=UgzhJCrebTCE+aiZaPLu16CZLy9oszaNB3nNAu8gE72Vrs+yGpNjb27KJjVDREOn02 qmFWDwJj1KAJxxFOnNNrnXymC8hLe5UJD3A7usWCEGAMFueqUusCqz+danAY4J2KzwuB djC3692bGyqyDwaUqiqkUQuThHJ5awnUzAQBLO7n4Jxpblx0s3j7J2MDFYMLuJncYIdL bFed+qf+yCoE4rQ4gaNJkAc7s2xNN8ULj7AT9HSyYbLrgkmccKctCATbRR6h9I7ofT12 NFm5p7sWmaS+jCiH1/MtOauDusLK/hBCEWhJaby3kd9Vb7803z54snWR61J1FkCkuL5m pUTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:delivered-to; bh=PGowjithCpcdaytua5V5fYRixp4NYWCvgDLyZmU2b28=; b=BeBc5igqWSay77EOvnF/eqCh9VxuaYsP0GMR4ISb4t8ybPqCiMZhQsYiKZsCrxDE54 xQqTc9T4U6Ux9ZeSQupCMz3T6jmhpDnK27eQwsd8sKAViBBRqF4CtlKJzSpo5752ggdL tJW2dV/AI082nmoc9Zh16oCyvO8IACJj2VE95Qj99ebyRUtdOS+ig4PzinCdUI8MI70B HhiQkwQs8Gbw5Ugu3FC4B5dnDzMFJF0/JW/T4tgsxwNweetxGt++7ClFqkObaOuWNdS2 pboL7mpzPIno9hXEQCqs/LXVAxQXmi2nga9iCz7bG7UFqPSYQG/OlUPaNjPGY8dcqCbu aXnA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id j22si5363002edq.161.2021.07.08.20.35.08; Thu, 08 Jul 2021 20:35:31 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CDD8A68A451; Fri, 9 Jul 2021 06:35:03 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0AAD0689DB3 for ; Fri, 9 Jul 2021 06:34:56 +0300 (EEST) X-IronPort-AV: E=McAfee;i="6200,9189,10039"; a="196814895" X-IronPort-AV: E=Sophos;i="5.84,225,1620716400"; d="scan'208";a="196814895" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2021 20:34:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,225,1620716400"; d="scan'208";a="461973651" Received: from f.sh.intel.com ([10.239.159.147]) by fmsmga008.fm.intel.com with ESMTP; 08 Jul 2021 20:34:49 -0700 From: Fei Wang To: ffmpeg-devel@ffmpeg.org Date: Fri, 9 Jul 2021 11:32:21 +0800 Message-Id: <20210709033229.19125-1-fei.w.wang@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [FFmpeg-devel] [PATCH v4 1/9] cbs_av1: fix incorrect data type X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Fei Wang MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: qiwXKanZI8bz Since order_hint_bits_minus_1 range is 0~7, cur_frame_hint can be most 128. And similar return value for cbs_av1_get_relative_dist. So if plus them and use int8_t for the result may lose its precision. Signed-off-by: Fei Wang --- libavcodec/cbs_av1_syntax_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/cbs_av1_syntax_template.c b/libavcodec/cbs_av1_syntax_template.c index 6fe6e9a4f3..d98d3d42de 100644 --- a/libavcodec/cbs_av1_syntax_template.c +++ b/libavcodec/cbs_av1_syntax_template.c @@ -355,7 +355,7 @@ static int FUNC(set_frame_refs)(CodedBitstreamContext *ctx, RWContext *rw, AV1_REF_FRAME_ALTREF2, AV1_REF_FRAME_ALTREF }; int8_t ref_frame_idx[AV1_REFS_PER_FRAME], used_frame[AV1_NUM_REF_FRAMES]; - int8_t shifted_order_hints[AV1_NUM_REF_FRAMES]; + int16_t shifted_order_hints[AV1_NUM_REF_FRAMES]; int cur_frame_hint, latest_order_hint, earliest_order_hint, ref; int i, j;