From patchwork Sun Jul 11 04:44:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gyan Doshi X-Patchwork-Id: 28884 Delivered-To: andriy.gelman@gmail.com Received: by 2002:a25:bbc9:0:0:0:0:0 with SMTP id c9csp1862784ybk; Sat, 10 Jul 2021 21:44:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz7hamThRzt5pQH6eJTwZcOp4ZZtaDfg7RhWmVSgMGOixG86tNymIYRGc5j80WbQbieaKyI X-Received: by 2002:a17:906:4886:: with SMTP id v6mr9726843ejq.45.1625978685483; Sat, 10 Jul 2021 21:44:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625978685; cv=none; d=google.com; s=arc-20160816; b=oaCKYsHse43U1iG4vHPP2xR5tLykDvGGbT6nQOLMenQ/CWAMcKhBpJJ6LEGuPPxyPH vG/n1JyGIFyH7pLQ1RdLRxxKHxxlhNb2Q/EMhj2gZREhtZrzrHnBYcAfUPgeVPd6c20k i+2z7fs/VHpNMynUTrl2TLAenm5YNhSt3LHvXB+iVzITaqkYoQtOER17gjrEjWpCoD+D tBAb/VbhL89C4PE0sdLEz8qKSakLgT/Rx6UcHZ5WhF0H/iCPJlsPQrdMHnptBOASvUcw TE+JyhLMwbhyE9CzIin736oVNmvpzATH+RxlUbNMd0+ClsUD6w6iGQtMw26nfPi48QZH vpsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :delivered-to; bh=at5IomEE+ICGh+fdSpcVM+Q+cZ0z4XxqelQwoXY9kGc=; b=BNizmkxFIEYF4ji5BOGTZSNB8eqlkwXjbhYL1N6Zm2Q+1IgC0WTX3C1Z2YP3xOiZYk HOmwihMFpJfrT5NIgXsW6SI9SVGhxxijPNFffZrI9VJsV7TTXrtxIHXl4Sg+CrMmY6WL rYVDtkQfXE+DSwfUiPy6JPUuHeJ39tIToHM+se7fNhm6tl1IwoNaTjWKzoRIwy5t4EiD ResOU8ruBH84noX/kQq1nRiXDOSFmC7rqzLuPmXailxfly9RO40eQinwqAg8tK66P8uV kW3Lor9tRPsF6cZKmkceTDnWP4SqtNzfLnDUTenI6d6vgXnu3U2cQN5fBL5u7p0K2Div cNyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id s21si13394876edx.417.2021.07.10.21.44.44; Sat, 10 Jul 2021 21:44:45 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0DB5668A678; Sun, 11 Jul 2021 07:44:43 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B6DDE68A242 for ; Sun, 11 Jul 2021 07:44:36 +0300 (EEST) Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4GMvSf34mLzQjV0 for ; Sun, 11 Jul 2021 06:44:34 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by hefe.heinlein-support.de (hefe.heinlein-support.de [91.198.250.172]) (amavisd-new, port 10030) with ESMTP id sIcaiknysQbi for ; Sun, 11 Jul 2021 06:44:30 +0200 (CEST) From: Gyan Doshi To: ffmpeg-devel@ffmpeg.org Date: Sun, 11 Jul 2021 10:14:15 +0530 Message-Id: <20210711044415.875-1-ffmpeg@gyani.pro> MIME-Version: 1.0 X-MBO-SPAM-Probability: ** X-Rspamd-Score: 1.95 / 15.00 / 15.00 X-Rspamd-Queue-Id: 4196D22F X-Rspamd-UID: 1a64fb Subject: [FFmpeg-devel] [PATCH] avcodec/qsvenc: clip global_quality for ICQ modes. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: KpYXVk6+/r6d Content-Length: 1515 Allowed range is 1 to 51. Ref: https://software.intel.com/content/www/us/en/develop/articles/advanced-bitrate-control-methods-in-intel-media-sdk.html --- doc/encoders.texi | 3 ++- libavcodec/qsvenc.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index 4c38996372..8fccd73691 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -3119,7 +3119,8 @@ also set (the @option{-qscale} ffmpeg option). @option{look_ahead} option is also set. @item -@var{ICQ} -- intelligent constant quality otherwise. +@var{ICQ} -- intelligent constant quality otherwise. For the ICQ modes, global +quality range is 1 to 51, with 1 being the best quality. @end itemize @item diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index ca2b42cafd..b9a922d6b9 100644 --- a/libavcodec/qsvenc.c +++ b/libavcodec/qsvenc.c @@ -650,7 +650,7 @@ static int init_video_param(AVCodecContext *avctx, QSVEncContext *q) case MFX_RATECONTROL_LA_ICQ: q->extco2.LookAheadDepth = q->look_ahead_depth; case MFX_RATECONTROL_ICQ: - q->param.mfx.ICQQuality = avctx->global_quality; + q->param.mfx.ICQQuality = av_clip(avctx->global_quality, 1, 51); break; #endif #endif