From patchwork Mon Jul 12 11:07:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Khirnov X-Patchwork-Id: 28908 Delivered-To: andriy.gelman@gmail.com Received: by 2002:a25:bbc9:0:0:0:0:0 with SMTP id c9csp2811954ybk; Mon, 12 Jul 2021 04:08:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8xqVoLsnsTFop+8B5XfX2f8LSWoHDlf7qCt+d0BfUvbCNutOaMLnHWk9wxqR5OBxBTdXf X-Received: by 2002:a17:907:1b06:: with SMTP id mp6mr53893329ejc.188.1626088114038; Mon, 12 Jul 2021 04:08:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626088114; cv=none; d=google.com; s=arc-20160816; b=aNBhUzqOsc4LsIphcB8fG02zBLBBNhifsDdPyAb03prulCzCsiapgSqqqTBUJm36UP 6pAy4ldj1KCiFw6neUGmEgxX7iAhlyBr8+XhEbnbXe8IAqF1gYw3kIx1pVfOYxBMkutU FnlN7RNrADid3PNKE3prABdIZLHqCAybLb+Su62OWsJjUXQl7okenIW/TFGxQYUFVdMQ cf0v/GUqYTn20g3Epb++GtsVcKHtcR1He9NUKn+ZDdNjf/SJZO/9RfVexJyyHWKcZcdc X/8UXKYWgVQqPoCZv0xZmsuMuTq0/tEHklVZkpHxOzi1j1ouDxAvzB+0fajkLRKtLJLz a0/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:delivered-to; bh=AiOsH2ieJ8b7AGqyKz8kLLpihHsTA0ujohnATmmEarI=; b=aYQFBlgHCTKl6M3CeZXa0vIHOmFSypwaDBlyc28mpmfkEBzW64K0XSeMmt4WuGx41W LE3VQsPeJ8Lb44Io0Ijdc0Tva2TVs3/o65Ef7YrQ3wZwcz7UtoXd6v/NKQLm1wrr+cf5 kY2GwAQ5aUFB2kQx/LxH7Y4LAy7bjKhUm9Jfp+3r5yjUjo400Je4+k9D/N0+59dTj9F6 fcNEtFKG1g/vXl9BQ8ynVEdSmx0w4WKKE4LGjd5J4xlkFUvzDUA8bIXS/C/JO0MJtItP NUVFnUgQ5FDRbzcxjb59mh2602pp2T6ElBpdiQ8FA0depmjFZZUkn3npAHedjPdAmBc0 Kxow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id ka15si16198958ejc.148.2021.07.12.04.08.31; Mon, 12 Jul 2021 04:08:34 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C06AD68A947; Mon, 12 Jul 2021 14:08:03 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8CCD86898E4 for ; Mon, 12 Jul 2021 14:07:55 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 3DE1B2404C8 for ; Mon, 12 Jul 2021 13:07:55 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id iGX94t1HBUVi for ; Mon, 12 Jul 2021 13:07:54 +0200 (CEST) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:2a00:c500:561:201::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "libav.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 68EC5240692 for ; Mon, 12 Jul 2021 13:07:52 +0200 (CEST) Received: by libav.khirnov.net (Postfix, from userid 1000) id A4FC93A0BA4; Mon, 12 Jul 2021 13:07:50 +0200 (CEST) From: Anton Khirnov To: ffmpeg-devel@ffmpeg.org Date: Mon, 12 Jul 2021 13:07:05 +0200 Message-Id: <20210712110709.15532-5-anton@khirnov.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210712110709.15532-1-anton@khirnov.net> References: <20210712110709.15532-1-anton@khirnov.net> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 4/8] lavu/slicethread: return ENOSYS rather than EINVAL in the dummy func X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 4NAEKribuT4v Content-Length: 990 EINVAL is the wrong error code here, since the arguments passed to the function are valid. The error is that the function is not implemented in the build, which corresponds to ENOSYS. --- libavutil/slicethread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/slicethread.c b/libavutil/slicethread.c index dfbe551ef2..fd2145040d 100644 --- a/libavutil/slicethread.c +++ b/libavutil/slicethread.c @@ -239,7 +239,7 @@ int avpriv_slicethread_create(AVSliceThread **pctx, void *priv, int nb_threads) { *pctx = NULL; - return AVERROR(EINVAL); + return AVERROR(ENOSYS); } void avpriv_slicethread_execute(AVSliceThread *ctx, int nb_jobs, int execute_main)