From patchwork Tue Jul 13 07:55:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jai Luthra X-Patchwork-Id: 28915 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a5d:965a:0:0:0:0:0 with SMTP id d26csp4081442ios; Tue, 13 Jul 2021 00:55:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwDtrpIpM6BO62G0kL+U+t/ihq+wJRfTyL3lKUCxYMkxDyNTR7y+lmT1HLlUmMteg/UabQM X-Received: by 2002:a05:6402:2685:: with SMTP id w5mr3997009edd.71.1626162945539; Tue, 13 Jul 2021 00:55:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626162945; cv=none; d=google.com; s=arc-20160816; b=rxaeEOgRqS5eDvEVCVtl20Krv7TcEW/AYtOHb0rlxjeT2oZZ4ZLmjlqv3fAP+2bshA ecZZG5R2LjjfKQ9nG+xYWJoPuJxWwvLdzeOAPsZ+a0JrmRUQDu8lQ43pyls2LF/Oaolc 5lYrcJNJbEU1Q2L5SGtOM5hHauMHOUCeTlHC2qpBXD8fG2orhA2uOYZP174eIuWk+8jE g2ZisokuIem7ZaQkqsB8UHdo/6QFJAC+bCr6xSGb47MTpSgs9LsZjpt3MGJNro5LuNfJ a9q3sovju86N1Dohx/E2DAbe/YUio3Yazd6AVhDJapN1Dae9rfvoKsXHwqMMqXA/+JnO LZiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:dkim-signature:delivered-to; bh=2hLvxScJlp/z991IUrumxXiiuY4vj6nu3cdOB3K8K/c=; b=HtH+czzG9hDatu8yCIt2DvoWSdft2M/QLQFr0OHJR0+BsnLjuiJwVjFZX3XOcxMfVA rert2tynZ1+lU82i4i60ADdCI1J2toe+h8yjm6INoF3FYhlkunpmZjZh2nGFfeg5i6HL 9uQi4zHY/MSjpUTnkP9i5EFARDXKE2bWHYwsVpc/T/zpUg9xVRrsjcB7dn6/9YUDeZDM i3pkWLNWpr74rlQ/07Jvn9qo+46W8WhJfoO9NrTCDLA/5tPXY5UNn/AeYNbN399rkyvX cwMwP19CwtSbnunMTnVEXtiHNPn54z39qJVsJNxmpHdk6cOCT8omjvOWbY76tlFEiMjQ QQKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@jailuthra.in header.s=fm2 header.b=RXJ7YQYK; dkim=neutral (body hash did not verify) header.i=@messagingengine.com header.s=fm3 header.b=dS8+lnAV; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id l3si23246575ejd.203.2021.07.13.00.55.44; Tue, 13 Jul 2021 00:55:45 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@jailuthra.in header.s=fm2 header.b=RXJ7YQYK; dkim=neutral (body hash did not verify) header.i=@messagingengine.com header.s=fm3 header.b=dS8+lnAV; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6EC6968A944; Tue, 13 Jul 2021 10:55:42 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0E32968A4EC for ; Tue, 13 Jul 2021 10:55:34 +0300 (EEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 83E775C01A5; Tue, 13 Jul 2021 03:55:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 13 Jul 2021 03:55:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jailuthra.in; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=fm2; bh=UXD0eZqQPQ2rR9k/96n1LH1MqK OifrKKtL0gW2z+cAA=; b=RXJ7YQYK2s8mlubzF3DwI3Da1vJUq3bzCAl6SP+MzV RZEN7VeylQyOW7ONWIItpzYf5/Ftp0po2w3NiYe+R3mmrloMdilv2Q2nMZ8LHq03 KuAPZI9dGSY931OyVaLLkOMvyB+QL2oJk6/34mTkummJUiChYD+HbU0O6cc8RJIY FTQQMqnOYwHxMKQZdheQiOR5hnPS92cUWQ01ubHp8xVxHDcgOWYkJ8ZsTtdhm2ik fc6CKhVmBIEZDFFT14Tn13nZpBBE42wWF4G5D9SElPEeUj79IIVbFxHieVN28xL4 E+DBR1BMOamSuqFNM3eZ/K0C21lGcv35PfFcYtXa1nYw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=UXD0eZqQPQ2rR9k/9 6n1LH1MqKOifrKKtL0gW2z+cAA=; b=dS8+lnAVf36yF9UAwjjnmtXCugbJ+qkXU Jj/EMxiJ7TFwmxx5smw/Dh3rOWR4bBf+2kAPxDZh86VGQhmhVaYg60ybrxc8unGn 8HbR1q8FRvocq8J932pEwUM7qtXxVb8qTnOaGYWG+2rsm6YpuwMlsSBFpxISRfNK lHeE1LVyxoi4QGRVx7Wv1RMDMbxotqbTkN6yosLwIccfHG5LtlaL3lMUdZ83E7ds pBLqz7KSJUGo1AKfCMS9YePdRcxHyAXz1rJgq17NkwpYgPhFxf5BKBMalDTLtC/U ysROEfgzy9W/Hadsuub7yyotCpYZLO7bmTlw0AOnEUoBiD8I32rWQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudeggdeludcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffoggfgsedtkeertdertd dtnecuhfhrohhmpeflrghiucfnuhhthhhrrgcuoehmvgesjhgrihhluhhthhhrrgdrihhn qeenucggtffrrghtthgvrhhnpeduledthfdugfevfefhvdethfegjeegueetiefftdevhe ejiefggfefgfehvedvkeenucffohhmrghinhepghhithhhuhgsrdgtohhmnecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgvsehjrghilhhuth hhrhgrrdhinh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 13 Jul 2021 03:55:29 -0400 (EDT) From: Jai Luthra To: ffmpeg-devel@ffmpeg.org Date: Tue, 13 Jul 2021 13:25:25 +0530 Message-Id: <20210713075525.84497-1-me@jailuthra.in> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avfilter/vf_signature: Initialize all houghspace elements X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Oscar Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: QnIhTdZFZb6v Co-authored-by: Oscar --- The uninitialized score & dist values are used a few lines below this, leading to inconsistent mpeg7 matches. Original PR here: https://github.com/livepeer/FFmpeg/pull/4 libavfilter/signature_lookup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/signature_lookup.c b/libavfilter/signature_lookup.c index 272c717c77..f1d378237a 100644 --- a/libavfilter/signature_lookup.c +++ b/libavfilter/signature_lookup.c @@ -200,7 +200,7 @@ static MatchingInfo* get_matching_parameters(AVFilterContext *ctx, SignatureCont /* initialize houghspace */ for (i = 0; i < MAX_FRAMERATE; i++) { hspace[i] = av_malloc_array(2 * HOUGH_MAX_OFFSET + 1, sizeof(hspace_elem)); - for (j = 0; j < HOUGH_MAX_OFFSET; j++) { + for (j = 0; j < 2 * HOUGH_MAX_OFFSET + 1; j++) { hspace[i][j].score = 0; hspace[i][j].dist = 99999; }