From patchwork Thu Jul 29 06:00:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ming Qian X-Patchwork-Id: 29110 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a5d:965a:0:0:0:0:0 with SMTP id d26csp5517332ios; Wed, 28 Jul 2021 23:00:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwj2tC2U08bjAuvw9Qs4amDMUDQ45W2J1L6V7GkES4CdUAabGR5yKV6Ihvk3ptDRF3vafP X-Received: by 2002:a17:906:1fd3:: with SMTP id e19mr2983960ejt.421.1627538457813; Wed, 28 Jul 2021 23:00:57 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id di25si1894123edb.456.2021.07.28.23.00.57; Wed, 28 Jul 2021 23:00:57 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@nxp.com header.s=selector2 header.b=prhqaTBj; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2F56768A15F; Thu, 29 Jul 2021 09:00:53 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2050.outbound.protection.outlook.com [40.107.21.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A3D926880BA for ; Thu, 29 Jul 2021 09:00:44 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ANOvsCSbl03XQ/o6dn31U83PlTuVCYF0vdJSV1iE5XTG01QMhcCgExskyG+sD+NJcK1Cf7zn2Bk4B3HWlywgp0tF8pGR289jlwIuorKA6OwRi/L3Pqvdh3VKULkTjXGSantWiuol+TGnxiBCexYVDAwak/z79XYDqNr68DtGGIkeTKmlTpJIHByLBGBV3Mn3t8qnDbSbSKRYghXwpKiR4gj5SF1MwZg8xLQbwju7hA3xQsImmalOV4DILaP4GrPzol28FedHo2bajLV7S27uuJJW/wYMPQNEGIeGeN+eDf/BRr2IgnTRgXkLuGbdVI5ModhU5IIbVyGTd5LCm1gHww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+uFDMLMQA3ZNF4SbU2xK+FMj1DOBDd6Jg58Room9W8s=; b=FumMQVj7zPM3gW2hRORNuPxosX88fmXwyoVddzC0uI22qHLBgqJ48uHnNO+z1LiC944RYQa708ZvtsMQwDd7bll8rx+Dk+YM63ifB3qV/hRonbMBV5kWluFjqt1hKzMDQwUMGkIGsb/5jCe8gX8XjcMRRw8lsnho1XLHJ/CyS6CQelwkKt5dfEEGVQunbfF9hT6HmZ+Z8JEVxqaYoPHoSu6Xv1xxcsvUGXt/rFC26n5A92ZCRFNEikp0b15K+CpFHfpSwiXuqC6A6BdN20gwc4ROl6H9c8wbAXfK11sDbRGoXWe/QAfpJReUoo10d1Divse3i1Gzc2ILALTAcRrdTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+uFDMLMQA3ZNF4SbU2xK+FMj1DOBDd6Jg58Room9W8s=; b=prhqaTBjqwF8F5CUjcfq2f3fakYfv3HKjzq88mJlXn9qIun2qDK6io28Eb7YNHSjKVTQSqrjsk8FurgY9o86/QEttFyBzK0D0E491uruEQNiw4G4AAw9MVUcEbWDMyEdKhMq3DqRhFPHKGit6TyvtzHPQjzv78kCSJCvUQ8m0LU= Authentication-Results: ffmpeg.org; dkim=none (message not signed) header.d=none;ffmpeg.org; dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB6341.eurprd04.prod.outlook.com (2603:10a6:20b:d8::14) by AM7PR04MB7127.eurprd04.prod.outlook.com (2603:10a6:20b:113::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.21; Thu, 29 Jul 2021 06:00:42 +0000 Received: from AM6PR04MB6341.eurprd04.prod.outlook.com ([fe80::81e3:1e06:83ee:5db8]) by AM6PR04MB6341.eurprd04.prod.outlook.com ([fe80::81e3:1e06:83ee:5db8%3]) with mapi id 15.20.4352.031; Thu, 29 Jul 2021 06:00:42 +0000 From: Ming Qian To: ffmpeg-devel@ffmpeg.org Date: Thu, 29 Jul 2021 14:00:25 +0800 Message-Id: <20210729060027.9513-1-ming.qian@nxp.com> X-Mailer: git-send-email 2.32.0 X-ClientProxiedBy: SG2PR02CA0113.apcprd02.prod.outlook.com (2603:1096:4:92::29) To AM6PR04MB6341.eurprd04.prod.outlook.com (2603:10a6:20b:d8::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from lsv11149.swis.cn-sha01.nxp.com (119.31.174.70) by SG2PR02CA0113.apcprd02.prod.outlook.com (2603:1096:4:92::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18 via Frontend Transport; Thu, 29 Jul 2021 06:00:41 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a3d9071c-c784-4da2-5fb2-08d9525632d5 X-MS-TrafficTypeDiagnostic: AM7PR04MB7127: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1850; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iqx90au/4JXfMduAFLncGTuBNwI0jnaTR1Q+GumRruAqWO0aHmPcpSoXf75/vgtGNDGeK7O74DCPeONAaHxMQ1gXO5PxCPlyf0u/q9/k8L1HSH7WOdGU5WaUO1KrFrS4Yk8VvNaqy2HA1A/bjloy/3Dg2DDZFzQ8+QmGbyww7kxfHkGU6Ru3hwgvaBicxBT4ta4kWPoACzE2VPiEtmEbiUbb08nhaa4ySgkECNP8gIzlC8UbU2eqGwrATGXaxkamwrXKPjp1qi99eEDfEaxgBHru5ILWqvvU+2ifg4uSsvzw0k1G9ze4Y6Nb3W2PCvCaBkuQ/QawCVHNZVY0M5p2qyhvqFAo6v66hmtUNSVJ/zOmOK5cxJ5u251iVqLcQ9ygq47ZzSS3HcCmGjukL7STzz8DiO8jeXpAtUJnvJtEUXp+Nqg7Ytm2Qn6m4ud72UuhAtl+hQHtnb+A2rKgriMDnYBIMAomST1QyibLGIzRjryrk6SvzPC3pxBt+NpksOdf6Fo+tR7+H5OUQYriHyPsVzG95sB4cfj0tYcHVWeXFyBgjhjcqZ60hI0bAh9B0zTUH7zN7ftpF0emOZi7+0fYKCzfAE1vzjxGZd0d2OFPXyth0Zu7ObEgzll9LSCU7RcEVbbyVywAz2TgRNL/55VzxWKHKFwRWuO6rARTCud9HQjitRqSJayhmd1YEAVfG6wU0nUAAZmOU7BUZSEo3MBMww== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB6341.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(39860400002)(396003)(136003)(346002)(66476007)(44832011)(66946007)(66556008)(6916009)(316002)(478600001)(86362001)(186003)(2906002)(8936002)(5660300002)(6666004)(6486002)(1076003)(52116002)(7696005)(8676002)(36756003)(2616005)(38100700002)(956004)(38350700002)(26005)(83380400001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: iUeKlZ/oVd5BbzRQQsENIpvozZfXMys68JgI/NT4gx8ob6UT/UosV9MO7Kf9lhsEWosqzqND71xg1V1tD9KCgTA2k34+eP7QB8bCnIi3WDLn+z1IK6lePG/yM775psAxATwDFiOK6CcqBs2jHPbGir+u61AiKrlYoGS95uO3cdYX04qTgzUFyBkENpVGQU06Hw36V8nwHJiGJUy5v0pV4njerqt2anSWeeMt+5eoN4LgGIV/PMBDU7QRQKrN/6uLszKdD3/epzu/JCY5/9hd8lDzgcIREB7sdrxLm97P1eB3a6jCyzUTZ++kfaDktN3gif5Z64wqCi2nhZinQkweTw74nvfE4EZiC/kI8AhXmtw12x+ay9DIqmo8gQfqMqt7QcAuud78WhyBkaxpM+duX6xUmg+GDPZROd0GuK9fI02AsTh2lWed0bQ5egAX+lwKEc4FYMIcnsIBv7HlXSnir7dmOl73hQ9msDQEhhRrp5hTE3PI8D5Xu538CQC/4c/es6xfkHmwQGMZZMtzVfzCMTNgQiSSy+URRhfmBoZeSzsfRImgzx3MUrVFAZ17FGZWJiLUcwcqXKzmiVDm0n1QAlaFWAu3+wh5zwAQefXD4C0YhG9ULnbPXrwUkrwVeaUlNBsqDSBNrSQiRuBZLCO6cOq7cB4V0AkTf3lWWHghrwd/Pary0X3NH70jPrqyU93K8StZk1OoHGghzi54BAQwj1aykXB8rmGovgiTn5wZ9oYzq4kp04TKKMTTxBBDgAS8Hht8mT927/lASaGxqE2IAy3JL1LdXicvKytg1VzwrtYY2nrM92rOG+YAaRPXKyvv2dtRq69kE78/YuvwFTqUB8DcrUPb3Ih5F8vQEQY2yUGLiqtF2/lxmu91DzwQKFptP89F2x/BQWtv5Kx8meJr9qJE8p56iP/+Xz8NYHosITaMlf5yLy3T8o5ekxt0KOkgdMVOwdJ7qu6Iu+MdB9B5hafehxl6hWFzKVGub6DdvAXxHzhPRBzSQcwDVAMFnGnGCHNMEr04t9l1JsF/u4FRRTKrUmr/GOJRNjsQvp/ARa/9/FpQpIbLAZtKifDqtu5eb7N/8QJ2MP6EIHkI/eAlpkkZ9ToBpLH8kDJ0ezV+oM978pgZ9UrpvCMRhmYhU7cE61GdaVd5GIdJ/snC42l+a5xFxFshC3Bc/VFz+jQBSVM+N+fTfkKV3MEZ8IdwKkpgK7DMlECtVKftSx9Ruu1p0wat45qYQVRMnUJnx55vwjKwf5c2sn99h34REQQmIAs2dMdLFZPWnpEKoMw2G0gAPOLJMkyCQ/zgTKysbyDsgPGm2ZfPt2nKvTTRCdE9hu+V X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a3d9071c-c784-4da2-5fb2-08d9525632d5 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6341.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2021 06:00:42.5564 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5Sw7EMtFPxSXmC4xboI5qsnoM9xLoaZfcpkZ4SA3qLQ+osYIS7D8tgOf2TIgxyVnBIRX6v7rvbULpPPBro5zOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7127 Subject: [FFmpeg-devel] [PATCH v3 1/3] avcodec/v4l2_context: don't reinit output queue when dynamic resolution change X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 2VBYWfSDq7Ke in the v4l2 stateful video document, we can see the following description: During the resolution change sequence, the OUTPUT queue must remain streaming. Calling VIDIOC_STREAMOFF() on the OUTPUT queue would abort the sequence and initiate a seek. In principle, the OUTPUT queue operates separately from the CAPTURE queue and this remains true for the duration of the entire resolution change sequence as well. so don't reinit the output queue when handling the resolution change event Signed-off-by: Ming Qian --- libavcodec/v4l2_context.c | 27 ++------------------------- 1 file changed, 2 insertions(+), 25 deletions(-) diff --git a/libavcodec/v4l2_context.c b/libavcodec/v4l2_context.c index ff1ea8e57b08..dda5157698c3 100644 --- a/libavcodec/v4l2_context.c +++ b/libavcodec/v4l2_context.c @@ -162,9 +162,8 @@ static int v4l2_handle_event(V4L2Context *ctx) { V4L2m2mContext *s = ctx_to_m2mctx(ctx); struct v4l2_format cap_fmt = s->capture.format; - struct v4l2_format out_fmt = s->output.format; struct v4l2_event evt = { 0 }; - int full_reinit, reinit, ret; + int reinit, ret; ret = ioctl(s->fd, VIDIOC_DQEVENT, &evt); if (ret < 0) { @@ -180,25 +179,12 @@ static int v4l2_handle_event(V4L2Context *ctx) if (evt.type != V4L2_EVENT_SOURCE_CHANGE) return 0; - ret = ioctl(s->fd, VIDIOC_G_FMT, &out_fmt); - if (ret) { - av_log(logger(ctx), AV_LOG_ERROR, "%s VIDIOC_G_FMT\n", s->output.name); - return 0; - } - ret = ioctl(s->fd, VIDIOC_G_FMT, &cap_fmt); if (ret) { av_log(logger(ctx), AV_LOG_ERROR, "%s VIDIOC_G_FMT\n", s->capture.name); return 0; } - full_reinit = v4l2_resolution_changed(&s->output, &out_fmt); - if (full_reinit) { - s->output.height = v4l2_get_height(&out_fmt); - s->output.width = v4l2_get_width(&out_fmt); - s->output.sample_aspect_ratio = v4l2_get_sar(&s->output); - } - reinit = v4l2_resolution_changed(&s->capture, &cap_fmt); if (reinit) { s->capture.height = v4l2_get_height(&cap_fmt); @@ -206,18 +192,9 @@ static int v4l2_handle_event(V4L2Context *ctx) s->capture.sample_aspect_ratio = v4l2_get_sar(&s->capture); } - if (full_reinit || reinit) + if (reinit) s->reinit = 1; - if (full_reinit) { - ret = ff_v4l2_m2m_codec_full_reinit(s); - if (ret) { - av_log(logger(ctx), AV_LOG_ERROR, "v4l2_m2m_codec_full_reinit\n"); - return AVERROR(EINVAL); - } - goto reinit_run; - } - if (reinit) { if (s->avctx) ret = ff_set_dimensions(s->avctx, s->capture.width, s->capture.height);