From patchwork Sat Jul 31 17:48:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 29153 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:6c0f:0:0:0:0:0 with SMTP id a15csp260767ioh; Sat, 31 Jul 2021 10:55:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw4uZGdPQN9znwV2LZFayihf1zuNXZ6FkZelw73srY0LSpz0fxqUTbZNOr2APLJYUR24APg X-Received: by 2002:aa7:d4da:: with SMTP id t26mr10011398edr.42.1627754120087; Sat, 31 Jul 2021 10:55:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627754120; cv=none; d=google.com; s=arc-20160816; b=TLScnvZrF9wGZbMutxgkC4zx6b2J37Ruh47FVyy9bAuc3C4g/q7BPvMj9F1VbH+Hij 1ghjRGXAbOFif++t9lwUyyh3/2cR24+87bva8pWPd8asS7ms5nEvYGTJckX90KZaHvvO tMARIUSwTyT4ZDkZhKoViyCsRzvcaGH+IEPp2DOMVAxMGDCN1+CfP63ZHKHSZZuCjYzU kqtFJr2hvaVGzW0p/EWcR+u2v+pMgG6P7BSGT0NKBmIHjobwwU4Ija3LHVsBYWRz81eY G5Ajy/jJLmkkT0RDHXZQtbZHLqcQzPPAYFbbV6m5Kwftbo5k2y52M13B/LkkP7AXryxX bAwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:delivered-to; bh=mtTeTkgmTPLz4TrLTSFSye+FhbkA0xtW//7MjS85Tjg=; b=qF1D2VgR4rSYPmmt74t2mFNFwD5VNYxMvxEN64FR6szTi7bA+zLw5q2iQK+lwTJ6Rc dpmb8ZiQVXpWsc2VWI0D9f5wMF4Inyw4DFo/LGyGMH2d0En5U+bhqub2ooVk/0MUwyCg IEOqXwqq3vgIRO1ObSAqKuRa80iWOcqJ/1plANFnW0stq1aan55eH+E7NpIYCikbtLA5 kNdpFID6JO+U4T9u/Xte9NQrwzphHB3yy+awg6njHbUgQiYwiP7KWZrVd5SKePYmiknY rBx1++L1QaCZUWOe9RaiKUY1jTJUG5FKmdScUIQP5NUfUTe8Iu4ebx56cXdCF3fuDn2P PNhQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id v22si5341744eji.44.2021.07.31.10.55.19; Sat, 31 Jul 2021 10:55:20 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F329B689BFF; Sat, 31 Jul 2021 20:55:16 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-dmta-pe05-1.mx.upcmail.net (vie01a-dmta-pe05-1.mx.upcmail.net [84.116.36.11]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6A6F8689BFF for ; Sat, 31 Jul 2021 20:55:10 +0300 (EEST) Received: from [172.31.216.235] (helo=vie01a-pemc-psmtp-pe12.mail.upcmail.net) by vie01a-dmta-pe05.mx.upcmail.net with esmtp (Exim 4.92) (envelope-from ) id 1m9t7J-0030I4-0J for ffmpeg-devel@ffmpeg.org; Sat, 31 Jul 2021 19:49:45 +0200 Received: from localhost ([213.47.68.29]) by vie01a-pemc-psmtp-pe12.mail.upcmail.net with ESMTP id 9t6KmFgnHljeH9t6Km455S; Sat, 31 Jul 2021 19:48:44 +0200 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 213.47.68.29 X-CNFS-Analysis: v=2.3 cv=BoHjPrf5 c=1 sm=1 tr=0 a=2hcxjKEKjp0CzLx6oWAm4g==:117 a=2hcxjKEKjp0CzLx6oWAm4g==:17 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=ZZnuYtJkoWoA:10 a=nZOtpAppAAAA:20 a=xCxCWkUM3CW3Fgvun9UA:9 a=1fhp2MxaeJtTNGEnv6mo:22 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sat, 31 Jul 2021 19:48:42 +0200 Message-Id: <20210731174844.16646-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 X-CMAE-Envelope: MS4wfKjELNe2WpoH9hm6hV45SDqpD7CKNl4h5iSRsun3qbXzeLkjpfj1hiWKJtjgKOf6/wG15Ko81/emaoIFPy9IzfMqphgAdcK489pLic3G2gNd6n95MepO BfO12nHE0ba8vcDrnJk4y2G8UHnzgU9JYjCT11pxkMFZG78L9LbpgpNk Subject: [FFmpeg-devel] [PATCH 1/3] avcodec/sbrdsp_fixed: Fix negation overflow in sbr_neg_odd_64_c() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 2JXJBzjFQmnG Fixes: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself Fixes: 35593/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-5182217725804544 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/sbrdsp_fixed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/sbrdsp_fixed.c b/libavcodec/sbrdsp_fixed.c index 91fa664c08..43fcc90ae5 100644 --- a/libavcodec/sbrdsp_fixed.c +++ b/libavcodec/sbrdsp_fixed.c @@ -87,7 +87,7 @@ static void sbr_neg_odd_64_c(int *x) { int i; for (i = 1; i < 64; i += 2) - x[i] = -x[i]; + x[i] = -(unsigned)x[i]; } static void sbr_qmf_pre_shuffle_c(int *z)