diff mbox series

[FFmpeg-devel,v2,1/4] FATE: Update test refs for scale used in filter complex

Message ID 20210802164904.70998-1-fulinjie@zju.edu.cn
State New
Headers show
Series [FFmpeg-devel,v2,1/4] FATE: Update test refs for scale used in filter complex | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate fail Make fate failed
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate warning Make fate failed

Commit Message

Linjie Fu Aug. 2, 2021, 4:49 p.m. UTC 
From: Linjie Fu <linjie.justin.fu@gmail.com>

Since we prefer to use bicubic flags for scale filter to keep pace with
swscale.

Signed-off-by: Linjie Fu <linjie.justin.fu@gmail.com>
---
 tests/ref/fate/filter-scale2ref_keep_aspect | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Andreas Rheinhardt Aug. 2, 2021, 4:50 p.m. UTC | #1 
Linjie Fu:
> From: Linjie Fu <linjie.justin.fu@gmail.com>
> 
> Since we prefer to use bicubic flags for scale filter to keep pace with
> swscale.
> 
> Signed-off-by: Linjie Fu <linjie.justin.fu@gmail.com>
> ---
>  tests/ref/fate/filter-scale2ref_keep_aspect | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/ref/fate/filter-scale2ref_keep_aspect b/tests/ref/fate/filter-scale2ref_keep_aspect
> index 8dd0dbb13b..53c6fc14ec 100644
> --- a/tests/ref/fate/filter-scale2ref_keep_aspect
> +++ b/tests/ref/fate/filter-scale2ref_keep_aspect
> @@ -7,8 +7,8 @@
>  #dimensions 0: 160x120
>  #sar 0: 1/1
>  #stream#, dts,        pts, duration,     size, hash
> -0,          0,          0,        1,    57600, 9a19c23dc3a557786840d0098606d5f1
> -0,          1,          1,        1,    57600, e6fbdabaf1bb0d28afc648ed4d27e9f0
> -0,          2,          2,        1,    57600, 52924ed0a751214c50fb2e7a626c8cc5
> -0,          3,          3,        1,    57600, 67d5fd6ee71793f1cf8794d1c27afdce
> -0,          4,          4,        1,    57600, 85f7775f7b01afd369fc8919dc759d30
> +0,          0,          0,        1,    57600, 65fe9892ad710cc5763b04b390327d40
> +0,          1,          1,        1,    57600, 5e8d4524bc8889afa8769e851e998bc0
> +0,          2,          2,        1,    57600, 8f5e0e58d1f4c2104b82ef7a16850f1e
> +0,          3,          3,        1,    57600, cfe4142845e1445d33748493faa63cda
> +0,          4,          4,        1,    57600, bb491f3b01788773fb6129aef0f0abd2
> 
Changes to FATE should be in the same patch that warrants this; in your
case: In the patch that switches the scale filter. Otherwise you break
FATE in this commit and fix it in a later commit.

- Andreas
Linjie Fu Aug. 2, 2021, 5:01 p.m. UTC | #2 
Hi Andreas,
On Tue, Aug 3, 2021 at 12:50 AM Andreas Rheinhardt <
andreas.rheinhardt@outlook.com> wrote:

> Linjie Fu:
> > From: Linjie Fu <linjie.justin.fu@gmail.com>
> >
> > Since we prefer to use bicubic flags for scale filter to keep pace with
> > swscale.
> >
> > Signed-off-by: Linjie Fu <linjie.justin.fu@gmail.com>
> > ---
> >  tests/ref/fate/filter-scale2ref_keep_aspect | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/tests/ref/fate/filter-scale2ref_keep_aspect
> b/tests/ref/fate/filter-scale2ref_keep_aspect
> > index 8dd0dbb13b..53c6fc14ec 100644
> > --- a/tests/ref/fate/filter-scale2ref_keep_aspect
> > +++ b/tests/ref/fate/filter-scale2ref_keep_aspect
> > @@ -7,8 +7,8 @@
> >  #dimensions 0: 160x120
> >  #sar 0: 1/1
> >  #stream#, dts,        pts, duration,     size, hash
> > -0,          0,          0,        1,    57600,
> 9a19c23dc3a557786840d0098606d5f1
> > -0,          1,          1,        1,    57600,
> e6fbdabaf1bb0d28afc648ed4d27e9f0
> > -0,          2,          2,        1,    57600,
> 52924ed0a751214c50fb2e7a626c8cc5
> > -0,          3,          3,        1,    57600,
> 67d5fd6ee71793f1cf8794d1c27afdce
> > -0,          4,          4,        1,    57600,
> 85f7775f7b01afd369fc8919dc759d30
> > +0,          0,          0,        1,    57600,
> 65fe9892ad710cc5763b04b390327d40
> > +0,          1,          1,        1,    57600,
> 5e8d4524bc8889afa8769e851e998bc0
> > +0,          2,          2,        1,    57600,
> 8f5e0e58d1f4c2104b82ef7a16850f1e
> > +0,          3,          3,        1,    57600,
> cfe4142845e1445d33748493faa63cda
> > +0,          4,          4,        1,    57600,
> bb491f3b01788773fb6129aef0f0abd2
> >
> Changes to FATE should be in the same patch that warrants this; in your
> case: In the patch that switches the scale filter. Otherwise you break
> FATE in this commit and fix it in a later commit.

Thanks for the hints,  merged locally.

 - linjie
diff mbox series

Patch

diff --git a/tests/ref/fate/filter-scale2ref_keep_aspect b/tests/ref/fate/filter-scale2ref_keep_aspect
index 8dd0dbb13b..53c6fc14ec 100644
--- a/tests/ref/fate/filter-scale2ref_keep_aspect
+++ b/tests/ref/fate/filter-scale2ref_keep_aspect
@@ -7,8 +7,8 @@ 
 #dimensions 0: 160x120
 #sar 0: 1/1
 #stream#, dts,        pts, duration,     size, hash
-0,          0,          0,        1,    57600, 9a19c23dc3a557786840d0098606d5f1
-0,          1,          1,        1,    57600, e6fbdabaf1bb0d28afc648ed4d27e9f0
-0,          2,          2,        1,    57600, 52924ed0a751214c50fb2e7a626c8cc5
-0,          3,          3,        1,    57600, 67d5fd6ee71793f1cf8794d1c27afdce
-0,          4,          4,        1,    57600, 85f7775f7b01afd369fc8919dc759d30
+0,          0,          0,        1,    57600, 65fe9892ad710cc5763b04b390327d40
+0,          1,          1,        1,    57600, 5e8d4524bc8889afa8769e851e998bc0
+0,          2,          2,        1,    57600, 8f5e0e58d1f4c2104b82ef7a16850f1e
+0,          3,          3,        1,    57600, cfe4142845e1445d33748493faa63cda
+0,          4,          4,        1,    57600, bb491f3b01788773fb6129aef0f0abd2