diff mbox series

[FFmpeg-devel,v2] configure: [loongson] adjust MMI check in configure

Message ID 20210803040521.27642-1-jinbo@loongson.cn
State New
Headers show
Series [FFmpeg-devel,v2] configure: [loongson] adjust MMI check in configure
Related show

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

金波 Aug. 3, 2021, 4:05 a.m. UTC
After standardizing the use of 'pxor' in commit 'ebedd26', FFmpeg
build failed with upstream compiler, for 'pxor' is not supported
in time. This patch helps to workaround the build failure by
checking whether 'pxor' is supported during configuration, if not,
MMI will be disabled.
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

殷时友 Aug. 5, 2021, 12:52 a.m. UTC | #1
> -----原始邮件-----
> 发件人: "Jin Bo" <jinbo@loongson.cn>
> 发送时间: 2021-08-03 12:05:21 (星期二)
> 收件人: ffmpeg-devel@ffmpeg.org
> 抄送: 
> 主题: [FFmpeg-devel] [PATCH v2] configure: [loongson] adjust MMI check in configure
> 
> After standardizing the use of 'pxor' in commit 'ebedd26', FFmpeg
> build failed with upstream compiler, for 'pxor' is not supported
> in time. This patch helps to workaround the build failure by
> checking whether 'pxor' is supported during configuration, if not,
> MMI will be disabled.
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 94b30afe74..2aea0f841a 100755
> --- a/configure
> +++ b/configure
> @@ -5951,7 +5951,7 @@ elif enabled mips; then
>      enabled loongson3 && check_inline_asm loongson3 '"gsldxc1 $f0, 0($2, $3)"' '-mloongson-ext' && append MMIFLAGS '-mloongson-ext'
>  
>      # MMI can be detected at runtime too
> -    enabled mmi && check_inline_asm mmi '"punpcklhw $f0, $f0, $f0"' '-mloongson-mmi' && append MMIFLAGS '-mloongson-mmi'
> +    enabled mmi && check_inline_asm mmi '"pxor $f0, $f0, $f0"' '-mloongson-mmi' && append MMIFLAGS '-mloongson-mmi'
>  
>      if enabled bigendian && enabled msa; then
>          disable msa
> -- 
> 2.20.1
> 
LGTM
金波 Aug. 10, 2021, 9:01 a.m. UTC | #2
Ping.

&quot;yinshiyou-hf&quot; &lt;yinshiyou-hf@loongson.cn&gt;写道:
> > -----原始邮件-----
> > 发件人: "Jin Bo" <jinbo@loongson.cn>
> > 发送时间: 2021-08-03 12:05:21 (星期二)
> > 收件人: ffmpeg-devel@ffmpeg.org
> > 抄送: 
> > 主题: [FFmpeg-devel] [PATCH v2] configure: [loongson] adjust MMI check in configure
> > 
> > After standardizing the use of 'pxor' in commit 'ebedd26', FFmpeg
> > build failed with upstream compiler, for 'pxor' is not supported
> > in time. This patch helps to workaround the build failure by
> > checking whether 'pxor' is supported during configuration, if not,
> > MMI will be disabled.
> > ---
> >  configure | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/configure b/configure
> > index 94b30afe74..2aea0f841a 100755
> > --- a/configure
> > +++ b/configure
> > @@ -5951,7 +5951,7 @@ elif enabled mips; then
> >      enabled loongson3 && check_inline_asm loongson3 '"gsldxc1 $f0, 0($2, $3)"' '-mloongson-ext' && append MMIFLAGS '-mloongson-ext'
> >  
> >      # MMI can be detected at runtime too
> > -    enabled mmi && check_inline_asm mmi '"punpcklhw $f0, $f0, $f0"' '-mloongson-mmi' && append MMIFLAGS '-mloongson-mmi'
> > +    enabled mmi && check_inline_asm mmi '"pxor $f0, $f0, $f0"' '-mloongson-mmi' && append MMIFLAGS '-mloongson-mmi'
> >  
> >      if enabled bigendian && enabled msa; then
> >          disable msa
> > -- 
> > 2.20.1
> > 
> LGTM
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Michael Niedermayer Aug. 10, 2021, 2:35 p.m. UTC | #3
On Tue, Aug 10, 2021 at 05:01:13PM +0800, 金波 wrote:
> Ping.

will apply

thx

[...]
diff mbox series

Patch

diff --git a/configure b/configure
index 94b30afe74..2aea0f841a 100755
--- a/configure
+++ b/configure
@@ -5951,7 +5951,7 @@  elif enabled mips; then
     enabled loongson3 && check_inline_asm loongson3 '"gsldxc1 $f0, 0($2, $3)"' '-mloongson-ext' && append MMIFLAGS '-mloongson-ext'
 
     # MMI can be detected at runtime too
-    enabled mmi && check_inline_asm mmi '"punpcklhw $f0, $f0, $f0"' '-mloongson-mmi' && append MMIFLAGS '-mloongson-mmi'
+    enabled mmi && check_inline_asm mmi '"pxor $f0, $f0, $f0"' '-mloongson-mmi' && append MMIFLAGS '-mloongson-mmi'
 
     if enabled bigendian && enabled msa; then
         disable msa