diff mbox series

[FFmpeg-devel,4/4] avutil/tx: add a return at the end of non-void functions

Message ID 20210806133120.2914-4-jamrial@gmail.com
State Accepted
Commit 35331aa2662d4289585ab1bd4d1bf7699661cc5a
Headers show
Series [FFmpeg-devel,1/4] fftools/ffmpeg_filter: add a return at the end of non-void functions | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

James Almer Aug. 6, 2021, 1:31 p.m. UTC
Fixes compilation with GCC 11 when configured with --disable-optimizations

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavutil/tx.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Lynne Aug. 6, 2021, 1:49 p.m. UTC | #1
6 Aug 2021, 15:31 by jamrial@gmail.com:

> Fixes compilation with GCC 11 when configured with --disable-optimizations
>
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavutil/tx.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/libavutil/tx.c b/libavutil/tx.c
> index 25adb6b37e..fa81ada2f1 100644
> --- a/libavutil/tx.c
> +++ b/libavutil/tx.c
> @@ -38,6 +38,7 @@ static av_always_inline int mulinv(int n, int m)
>  if (((n * x) % m) == 1)
>  return x;
>  av_assert0(0); /* Never reached */
> +    return 0;
>  } 
>

LGTM, thanks. I did think it was a little suspicious it let me write it like that.
diff mbox series

Patch

diff --git a/libavutil/tx.c b/libavutil/tx.c
index 25adb6b37e..fa81ada2f1 100644
--- a/libavutil/tx.c
+++ b/libavutil/tx.c
@@ -38,6 +38,7 @@  static av_always_inline int mulinv(int n, int m)
         if (((n * x) % m) == 1)
             return x;
     av_assert0(0); /* Never reached */
+    return 0;
 }
 
 /* Guaranteed to work for any n, m where gcd(n, m) == 1 */