From patchwork Sun Aug 8 17:29:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: FFmpeg Technical Committee X-Patchwork-Id: 29358 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:6c0f:0:0:0:0:0 with SMTP id a15csp2206851ioh; Sun, 8 Aug 2021 10:30:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUysti59cUill51OXy7ZXeZOGyEZDvaMyhRYx/uuJX7I5GfaHWhRtBrx3wgAJW9ttGz6Sg X-Received: by 2002:a17:906:6009:: with SMTP id o9mr19279318ejj.266.1628443846111; Sun, 08 Aug 2021 10:30:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628443846; cv=none; d=google.com; s=arc-20160816; b=c8VAyPPEd/JPbM8ypMhbXR9oflY1obraURzmBhELxi2566LTI5LglKLTVxoGgoS/tb aNIYVKhZ/yeiaW0YyMdZ25SfHRDowd9iPxrIzvKs4sPeh/hLE+mWNhWMKV0knUgBvJRZ rgrCCzufoWP1Jkx6uHOgWLuw9HCb4vBRJo3/fYR0NkecD6N2ypDZCvPbkB5Ik6QToqG/ h9hG11Wt8bk0doj5gIokUEuQVE9fwfqURNsFCmQC3g47lX0Fr0mqiJ2iJKd/+s9h0tQd RAUclDuHil5ahk5spohVJ2XnuPx5HGOtYjYiLKS2QtpKr+PRfp/qydileyGWqfs4cDYv 25wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:delivered-to; bh=wglmNKaLvJ2sCeNHpB3jRZQZumgwlMxMWBMmFpmhOYM=; b=Qz/yLxRl2ItLqexl82nfDuBs63TJRT4GPxk23TGhU3TQhelBHdDohMzjht/0Ocf/bA EPtVbueeDb8Q36pS9CvqtmslDy4voDvQ8IpppUWA+YPcSVWIKeDMSOZupnGXgWs7Cgup LQrolWErEaCgDi44VCam5WcNoWkMMYAHh+N5mpySsTWKjQYrYNfpzhZk7PxI4Wg3T4pr go1OVbbnH6PLr7AoGTe/9jTePEEXJJmQ1zKCdEvsBCUbU+Odr1R67O/VdL2I+c707/Ev 6Ra02XI/W/1XyIKSdnC/M/OBlFM6rV9oQbKdzPOUIo0+S33wz6rGbnD9m9sTatDGc9Gp IXYA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id g24si4197167edj.498.2021.08.08.10.30.45; Sun, 08 Aug 2021 10:30:46 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 58DA168A4C3; Sun, 8 Aug 2021 20:29:59 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DF2BF689A81 for ; Sun, 8 Aug 2021 20:29:52 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 111A3240694 for ; Sun, 8 Aug 2021 19:29:48 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id GtVk9t2H9ejW for ; Sun, 8 Aug 2021 19:29:47 +0200 (CEST) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:2a00:c500:561:201::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "libav.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 55AD5240695 for ; Sun, 8 Aug 2021 19:29:46 +0200 (CEST) Received: by libav.khirnov.net (Postfix, from userid 1000) id 409DE3A0F56; Sun, 8 Aug 2021 19:29:46 +0200 (CEST) From: Anton Khirnov To: ffmpeg-devel@ffmpeg.org Date: Sun, 8 Aug 2021 19:29:37 +0200 Message-Id: <20210808172941.18238-6-anton@khirnov.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210808172941.18238-1-anton@khirnov.net> References: <20210808172941.18238-1-anton@khirnov.net> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 06/10] lavu/slicethread: return ENOSYS rather than EINVAL in the dummy func X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: bwLjdrZaYw6q EINVAL is the wrong error code here, since the arguments passed to the function are valid. The error is that the function is not implemented in the build, which corresponds to ENOSYS. --- libavutil/slicethread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/slicethread.c b/libavutil/slicethread.c index f928a5cf00..867ce32238 100644 --- a/libavutil/slicethread.c +++ b/libavutil/slicethread.c @@ -240,7 +240,7 @@ int avpriv_slicethread_create(AVSliceThread **pctx, void *priv, int nb_threads) { *pctx = NULL; - return AVERROR(EINVAL); + return AVERROR(ENOSYS); } void avpriv_slicethread_execute(AVSliceThread *ctx, int nb_jobs, int execute_main)