diff mbox series

[FFmpeg-devel,RFC] avformat/mov: add AVFMT_SHOW_IDS flag

Message ID 20210811062013.989-1-ffmpeg@gyani.pro
State New
Headers show
Series [FFmpeg-devel,RFC] avformat/mov: add AVFMT_SHOW_IDS flag | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate fail Make fate failed
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate warning Make fate failed

Commit Message

Gyan Doshi Aug. 11, 2021, 6:20 a.m. UTC 
The MOV muxer can store streamids as track ids but they aren't
visible when probing the result via lavf/dump or ffprobe due to
lack of this flag in the demuxer.

This current submission is just to get Patchwork FATE results.
Will be updated with changed refs, if any.
---
 libavformat/mov.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andreas Rheinhardt Aug. 11, 2021, 1:59 p.m. UTC | #1 
Gyan Doshi:
> The MOV muxer can store streamids as track ids but they aren't
> visible when probing the result via lavf/dump or ffprobe due to
> lack of this flag in the demuxer.
> 
> This current submission is just to get Patchwork FATE results.
> Will be updated with changed refs, if any.

You are actually supposed to run FATE yourself.

> ---
>  libavformat/mov.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index 46bc7b5aa3..c556390525 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -8216,5 +8216,5 @@ const AVInputFormat ff_mov_demuxer = {
>      .read_packet    = mov_read_packet,
>      .read_close     = mov_read_close,
>      .read_seek      = mov_read_seek,
> -    .flags          = AVFMT_NO_BYTE_SEEK | AVFMT_SEEK_TO_PTS,
> +    .flags          = AVFMT_NO_BYTE_SEEK | AVFMT_SEEK_TO_PTS | AVFMT_SHOW_IDS,
>  };
>
Gyan Doshi Aug. 11, 2021, 2:04 p.m. UTC | #2 
On 2021-08-11 07:29 pm, Andreas Rheinhardt wrote:
> Gyan Doshi:
>> The MOV muxer can store streamids as track ids but they aren't
>> visible when probing the result via lavf/dump or ffprobe due to
>> lack of this flag in the demuxer.
>>
>> This current submission is just to get Patchwork FATE results.
>> Will be updated with changed refs, if any.
> You are actually supposed to run FATE yourself.

Patchwork is going to test anyway. Might as well save CPU for better uses.

Regards,
Gyan
James Almer Aug. 11, 2021, 2:22 p.m. UTC | #3 
On 8/11/2021 11:04 AM, Gyan Doshi wrote:
> 
> 
> On 2021-08-11 07:29 pm, Andreas Rheinhardt wrote:
>> Gyan Doshi:
>>> The MOV muxer can store streamids as track ids but they aren't
>>> visible when probing the result via lavf/dump or ffprobe due to
>>> lack of this flag in the demuxer.
>>>
>>> This current submission is just to get Patchwork FATE results.
>>> Will be updated with changed refs, if any.
>> You are actually supposed to run FATE yourself.
> 
> Patchwork is going to test anyway. Might as well save CPU for better uses.

I don't think people will be amused with you using the mailing list to 
test your patches.
It's much faster and less noisy to just run make fate GEN=1 on your end, 
and send finished patches.

> 
> Regards,
> Gyan
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/libavformat/mov.c b/libavformat/mov.c
index 46bc7b5aa3..c556390525 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -8216,5 +8216,5 @@  const AVInputFormat ff_mov_demuxer = {
     .read_packet    = mov_read_packet,
     .read_close     = mov_read_close,
     .read_seek      = mov_read_seek,
-    .flags          = AVFMT_NO_BYTE_SEEK | AVFMT_SEEK_TO_PTS,
+    .flags          = AVFMT_NO_BYTE_SEEK | AVFMT_SEEK_TO_PTS | AVFMT_SHOW_IDS,
 };