diff mbox series

[FFmpeg-devel,2/2] avcodec/mlpenc: fix encoding stereo single stream in TrueHD

Message ID 20210918172105.5369-2-onemda@gmail.com
State Accepted
Commit cd7e25b14a2a27b73874b5f79a04ae5db738f7f6
Headers show
Series [FFmpeg-devel,1/2] avcodec/mlpdec: fix decoding single stereo stream in TrueHD
Related show

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_ppc success Make finished
andriy/make_fate_ppc success Make fate finished

Commit Message

Paul B Mahol Sept. 18, 2021, 5:21 p.m. UTC
Signed-off-by: Paul B Mahol <onemda@gmail.com>
---
 libavcodec/mlpenc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Anton Khirnov Sept. 20, 2021, 10:56 a.m. UTC | #1
Quoting Paul B Mahol (2021-09-18 19:21:05)
> Signed-off-by: Paul B Mahol <onemda@gmail.com>
> ---
>  libavcodec/mlpenc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Sure would be nice to have tests.
Paul B Mahol Sept. 20, 2021, 5:40 p.m. UTC | #2
On Mon, Sep 20, 2021 at 12:56 PM Anton Khirnov <anton@khirnov.net> wrote:

> Quoting Paul B Mahol (2021-09-18 19:21:05)
> > Signed-off-by: Paul B Mahol <onemda@gmail.com>
> > ---
> >  libavcodec/mlpenc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Sure would be nice to have tests.
>

Too soon, encoder is still experimental.


> --
> Anton Khirnov
>
Anton Khirnov Sept. 21, 2021, 6:43 a.m. UTC | #3
Quoting Paul B Mahol (2021-09-20 19:40:33)
> On Mon, Sep 20, 2021 at 12:56 PM Anton Khirnov <anton@khirnov.net> wrote:
> 
> > Quoting Paul B Mahol (2021-09-18 19:21:05)
> > > Signed-off-by: Paul B Mahol <onemda@gmail.com>
> > > ---
> > >  libavcodec/mlpenc.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Sure would be nice to have tests.
> >
> 
> Too soon, encoder is still experimental.

The decoder can still be tested, no?
Paul B Mahol Sept. 21, 2021, 6:53 a.m. UTC | #4
On Tue, Sep 21, 2021 at 8:43 AM Anton Khirnov <anton@khirnov.net> wrote:

> Quoting Paul B Mahol (2021-09-20 19:40:33)
> > On Mon, Sep 20, 2021 at 12:56 PM Anton Khirnov <anton@khirnov.net>
> wrote:
> >
> > > Quoting Paul B Mahol (2021-09-18 19:21:05)
> > > > Signed-off-by: Paul B Mahol <onemda@gmail.com>
> > > > ---
> > > >  libavcodec/mlpenc.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > Sure would be nice to have tests.
> > >
> >
> > Too soon, encoder is still experimental.
>
> The decoder can still be tested, no?
>

If its also not buggy.

>
> --
> Anton Khirnov
>
Anton Khirnov Sept. 21, 2021, 4:37 p.m. UTC | #5
Quoting Paul B Mahol (2021-09-21 08:53:17)
> On Tue, Sep 21, 2021 at 8:43 AM Anton Khirnov <anton@khirnov.net> wrote:
> 
> > Quoting Paul B Mahol (2021-09-20 19:40:33)
> > > On Mon, Sep 20, 2021 at 12:56 PM Anton Khirnov <anton@khirnov.net>
> > wrote:
> > >
> > > > Quoting Paul B Mahol (2021-09-18 19:21:05)
> > > > > Signed-off-by: Paul B Mahol <onemda@gmail.com>
> > > > > ---
> > > > >  libavcodec/mlpenc.c | 2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > Sure would be nice to have tests.
> > > >
> > >
> > > Too soon, encoder is still experimental.
> >
> > The decoder can still be tested, no?
> >
> 
> If its also not buggy.

If it's buggy then it can be fixed later and the tests updated. Don't
let that stop you.
diff mbox series

Patch

diff --git a/libavcodec/mlpenc.c b/libavcodec/mlpenc.c
index ef01c1d282..b2b3297669 100644
--- a/libavcodec/mlpenc.c
+++ b/libavcodec/mlpenc.c
@@ -626,7 +626,7 @@  static av_cold int mlp_encode_init(AVCodecContext *avctx)
             ctx->ch_modifier_thd0    = 0;
             ctx->ch_modifier_thd1    = 0;
             ctx->ch_modifier_thd2    = 0;
-            ctx->channel_arrangement = 1;
+            ctx->channel_arrangement = 0;
             break;
         case AV_CH_LAYOUT_5POINT0_BACK:
             ctx->ch_modifier_thd0    = 1;