From patchwork Fri Sep 24 06:28:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ming Shun Ho X-Patchwork-Id: 30542 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:6506:0:0:0:0:0 with SMTP id z6csp1196895iob; Thu, 23 Sep 2021 23:32:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxyfzeiDA8W3g/LYZhrfwAmfZc9CbUT/E9RRw5yT4CM9rPbDHpc/Q0+xsZCu6lJ4I0mLaRd X-Received: by 2002:a05:6402:5252:: with SMTP id t18mr3173893edd.13.1632465157082; Thu, 23 Sep 2021 23:32:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632465157; cv=none; d=google.com; s=arc-20160816; b=j2Rksv3FBIwrPB7cVzsthczK62rzDzwHVPEro0wWcN2Lk8W1u5zw9OB4K9/Y9RyY7z tIGEFw1orm+rbXr9WgWJbZL3TxgJeEUyCxUym7oNmIcwDTYHH9h84I1/i3JA6bjctoL+ tc/XEeg0buVxVUKchLmh8PemVL3vfrLHBKIxe5wWoR6iRuApms/xRp4tPz5rhvfBL7Ku oaZXpR7kFGQAON6KYUnTaEtkxAhqxPbmLZdZypHu5dykvVgMSl1EQ7jWY8KwWVkgcP5j ycB83QIhBpYr7x2fHtkS/g4azcXN9eu1cTgHcOmztDfdozwltnTb+8sufJxMPG1td/Eg BD6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to; bh=3wNzyw3gW5nLdQj3xWENyhzc8eEeCWDNYIMbbip0eSM=; b=MyYHrTtzeKXKHYHpYZG3N65P1RouwgckWG7jy9rAYlVqdWJv/SZuh8OeyPYNHBtUZ5 aFXSu04LMLQ+qlQY7UAsgIRC+GH1SrK/vrgKT/8ytkih3U8ZSuWaZJ9AD48T/jqB+Yl3 ZYpnuY5OUvRVXtx7ogabjntwRIq6uvqJsPmn+LHL5KiB1NWGAFojymUt8DG2hwK0LOfZ RdmQxEgG2GmxX3p7Wx93pt9eX0FMCpA274RuzwJ8YXUoh3IMnCPhXCmJim8V7Z91osDQ CAHWTIJWKMVa46tpbaRCuNk/08/PTlYmHSs4ydf9geST+mI+dWjyqsLnjMwk+jjLx0NB 6EyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=khHAHMVK; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id x22si2490147ejw.16.2021.09.23.23.32.36; Thu, 23 Sep 2021 23:32:37 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=khHAHMVK; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AB9C468A64A; Fri, 24 Sep 2021 09:32:22 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E57CC68A636 for ; Fri, 24 Sep 2021 09:32:15 +0300 (EEST) Received: by mail-pl1-f176.google.com with SMTP id j15so4365982plh.7 for ; Thu, 23 Sep 2021 23:32:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pVl5uspq7xtrtIL+i+e5DjRpxKoCbKR/0XfFSOk62Dk=; b=khHAHMVK8LbH/FIoQ2xwuZ0SNHAjaeLUGINrTlJbOsVg5+JlnrR6yNSp8HZqE/+bzn 88iALvXx1240WVDuHVSDsKfVJuTcEQnL07RKgnecUjoarLrEWbaFmgLF9AIekuMfr8Wg /ueRR9ITTSZu/owUeMjn6d2JAUy+Ndhc7RbdR0Pv3mvwoATEIE0J0BtszoAjFseptkGb jRVuMfFWrVw2qcZHo+OLFWXNlekQ7HfhC+R8LsqO3ufuWDsoiAwFzbJOdWi9jSvITvtr 5nIMm2/X0x1DZTykPehJWgKp8tPe4fxTytKf6JNLg5xIv00zvfWe5jPYT40w0OwbNo8h bQgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pVl5uspq7xtrtIL+i+e5DjRpxKoCbKR/0XfFSOk62Dk=; b=zIs7EUiAt/Tq18uxb/DEsUFJgIXus64u1iTuYtJZtik0iyg+dhaTlQSxRzlmkE7qVF 9xM9peE1vtffDZyc9qafAdn/t34Y2USmhea72vSdT1ZkpPBSs4TdjT3JrX+Gj/Zi7kJo +6HsIOr4BNRJehrrjcK55V8R8QK2l//9ulezi9tyUhQHk9TkVcEkBHCFAUi+fAyL49tn j6vTnNU3bbyhm3jTFAT26aexWnRcQ/YW5f4KPqkc1XVOpJOaMnpQUniNFMlHRsHd83sl cdEEeB3iGNEdwJ5oMamYkPtM27XCKYJn+E89/kxkrc634tlfQ0aFZ/PbQLLEJNM4aQhD TOmQ== X-Gm-Message-State: AOAM531z046sXaGUcLiiv0hH/eNCO91kJzMS73PbjY8SDVqvX42/HORQ xKZJCH6fw6tlNzCRUdOAexAXv0HU915efg== X-Received: by 2002:a17:902:8606:b029:12c:2625:76cf with SMTP id f6-20020a1709028606b029012c262576cfmr7863054plo.17.1632465134131; Thu, 23 Sep 2021 23:32:14 -0700 (PDT) Received: from localhost.localdomain ([103.252.202.177]) by smtp.gmail.com with ESMTPSA id d3sm7427886pfn.156.2021.09.23.23.32.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Sep 2021 23:32:13 -0700 (PDT) From: Ho Ming Shun To: ffmpeg-devel@ffmpeg.org Date: Fri, 24 Sep 2021 14:28:37 +0800 Message-Id: <20210924062838.7461-4-cyph1984@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210924062838.7461-1-cyph1984@gmail.com> References: <20210924062838.7461-1-cyph1984@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 3/4] avcodec/mmaldec: re-use AVPacket for extra_data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Ho Ming Shun Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: ngaHZAuJs3r8 extra_data and normal packets (from ff_decode_get_packet) processing do not overlap, thus we can re-use the spare AVPacket to send to ffmmal_add_packet. Furthermore, this removes allocation of AVPacket on the stack and stops using deprecated av_init_packet. --- libavcodec/mmaldec.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/libavcodec/mmaldec.c b/libavcodec/mmaldec.c index aab107d325..0aad7d0bb1 100644 --- a/libavcodec/mmaldec.c +++ b/libavcodec/mmaldec.c @@ -793,12 +793,10 @@ static int ffmmal_receive_frame(AVCodecContext *avctx, AVFrame *frame) AVPacket *avpkt = avctx->internal->ds.in_pkt; if (avctx->extradata_size && !ctx->extradata_sent) { - AVPacket pkt = {0}; - av_init_packet(&pkt); - pkt.data = avctx->extradata; - pkt.size = avctx->extradata_size; + avpkt->data = avctx->extradata; + avpkt->size = avctx->extradata_size; ctx->extradata_sent = 1; - if ((ret = ffmmal_add_packet(avctx, &pkt, 1)) < 0) + if ((ret = ffmmal_add_packet(avctx, avpkt, 1)) < 0) return ret; }