From patchwork Fri Sep 24 09:04:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ming Shun Ho X-Patchwork-Id: 30547 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:6506:0:0:0:0:0 with SMTP id z6csp1292024iob; Fri, 24 Sep 2021 02:06:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQFKjngCyrW5cJ2p2SqDEPhGqCPHSvCfsM2UXZYNA876BwQaVgsebpocp9SMA3DjRgVVwq X-Received: by 2002:a17:906:95d7:: with SMTP id n23mr9609215ejy.479.1632474407154; Fri, 24 Sep 2021 02:06:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632474407; cv=none; d=google.com; s=arc-20160816; b=KEmnSOHHVuDUZUVx6QMN54eBZlgUTunKLkXN0TyMYYzYTnCVVzLEKyxc0FhGlejrFB 0xYfYNRpv0w+CE+87EySVvwcbCDlQx2ashqZGGhB4xwuXpaL/hHoyRmzeTa0Njf3heA3 yOTebGdy835vXoyGN1MQ633McguDPN+1OJKEHZ24XwWg0Wiz8xx8jn7twiKAIjw21DuX LDC6UT8EitwmX0ei5rPdY5Nb4KCg/996iKcXQ/tgA0i1xR1khUyH1dxwHfVthmSBCYXj EkrYtz8EEl1KtHuG5ZrKrcNRKdX1aA1paum6+ohis/Jja6BjPOCV6cpMMPypSB9kGtoL 4RZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to; bh=R0sZpwfSHvARayBBukmyjqQ5x2OKI/8H2Fa+c8OM0gk=; b=tiZ6w6Q1bFx7cusm1EeZQ+ko9UWmjINkdXMhCbMvUCofmrcCYuBtSbSHUvcQjWRiJB vcI0SVf+jQ+ZAU27CatpTdWct0PFLm61Kxop46EiAfuXQJcYy57XAHhVcJ+z7oI9TNoq xqAnrfjG8Ral9L87vHfROgnyNsxOrAcDnEX7oghMiqvdHw80C5iliDMSePiu2lDvmA3X eENey+zWHLAYkz1OZs3Vc/zN+QG7EPXufLjL7DwvJ4XBnHAcFbDgRbm59KzVRNWHwAsG 6EFnJfej/2FpoD0VLIRYmUwmChmV1AExXDL7UKY7FIWIWkMybNRL4oyRYMMi25f3YHVq TA2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=Fcd775je; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id s7si8543543ejs.402.2021.09.24.02.06.46; Fri, 24 Sep 2021 02:06:47 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=Fcd775je; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2B76E68A62F; Fri, 24 Sep 2021 12:06:18 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 23FD368078A for ; Fri, 24 Sep 2021 12:06:10 +0300 (EEST) Received: by mail-pf1-f178.google.com with SMTP id k26so3747654pfi.5 for ; Fri, 24 Sep 2021 02:06:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EdlzZZ+wkuMBq2ZC380xHEvUeZzdAIQpQe3CSXPCyls=; b=Fcd775jeQKMUFiTMetQe4kgfPUHyJ9RE87cWI7BOul0WRILXFH52i33Qxk376NvAti /cY53FM6Hk+h2H5H2eO/xKleaTNc+etSUmv1YRJPNXfTYujCFJYyWIlNii/gcIAxic7Y aoBbBFOUp5sYFTVwqrUpi+/NB3i1/0QOtmE7+IsIlho83vylPtvhzjFZI+jyV55Xz3iT GMtPieUtJ1OmJlE1xTqg95mIAUdX9RYDWNV9dEQcVAa7H/4KxvIl514NXmbSGPXjKhXX n2XZUwQf6zRVPt0H1J8ZL8wb9de9vEQL4Bw3o/3DTuqOAsajqaffsEPp/JvZRSB3QA/r UGFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EdlzZZ+wkuMBq2ZC380xHEvUeZzdAIQpQe3CSXPCyls=; b=PMIURPU0jg92bPM188cLaABkEfYN+wU1GYq2ONMbFmrMRiLUDhfUHdR2AGZxVhqxQf tMAI2/cSo2aqoKnVtucwdoaW0t9rl20As98yosIVEVizhOhF3m1ddpInCPqo7N6uqDQd TQyHVaMnDD5n2h4ztXw3rtXZE27hQcnZF5FRtvgt9owRl+a996goPH805yy09RJyi7ku BSiBYUcvd02SvVBwnU2fxjCgXRUf0JpVcFxNtQjRy20ipyEHVT6MEDgTsmFoK8NgNZtw 7ZlICieV2M+rFTZrbGrVqY+6zW1N0vn1MZFrD0wDqpTPpHrS3XfUPoAdZqcCuIRrwYvf leaA== X-Gm-Message-State: AOAM531Dh7crSw92mEbMIG+ZsFTJRxaVeAN+ZY9br5bsMBktnx8iPBIu Q2BigofdBwVl3wKsR98AfCR3dBleXDKfEQ== X-Received: by 2002:a63:7d05:: with SMTP id y5mr2977699pgc.80.1632474368301; Fri, 24 Sep 2021 02:06:08 -0700 (PDT) Received: from localhost.localdomain ([103.252.202.177]) by smtp.gmail.com with ESMTPSA id s2sm8029279pfe.215.2021.09.24.02.06.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Sep 2021 02:06:08 -0700 (PDT) From: Ho Ming Shun To: ffmpeg-devel@ffmpeg.org Date: Fri, 24 Sep 2021 17:04:37 +0800 Message-Id: <20210924090438.11954-4-cyph1984@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210924090438.11954-1-cyph1984@gmail.com> References: <20210924090438.11954-1-cyph1984@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2 3/4] avcodec/mmaldec: re-use AVPacket for extra_data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Ho Ming Shun Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Am6oPUHsrRpH extra_data and normal packets (from ff_decode_get_packet) processing do not overlap, thus we can re-use the spare AVPacket to send to ffmmal_add_packet. Furthermore, this removes allocation of AVPacket on the stack and stops using deprecated av_init_packet. Signed-off-by: Ho Ming Shun --- libavcodec/mmaldec.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/libavcodec/mmaldec.c b/libavcodec/mmaldec.c index a8a568d239..6dbb991ae1 100644 --- a/libavcodec/mmaldec.c +++ b/libavcodec/mmaldec.c @@ -788,12 +788,10 @@ static int ffmmal_receive_frame(AVCodecContext *avctx, AVFrame *frame) AVPacket *avpkt = avctx->internal->ds.in_pkt; if (avctx->extradata_size && !ctx->extradata_sent) { - AVPacket pkt = {0}; - av_init_packet(&pkt); - pkt.data = avctx->extradata; - pkt.size = avctx->extradata_size; + avpkt->data = avctx->extradata; + avpkt->size = avctx->extradata_size; ctx->extradata_sent = 1; - if ((ret = ffmmal_add_packet(avctx, &pkt, 1)) < 0) + if ((ret = ffmmal_add_packet(avctx, avpkt, 1)) < 0) return ret; }