From patchwork Mon Sep 27 22:37:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 30609 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:6506:0:0:0:0:0 with SMTP id z6csp4602386iob; Mon, 27 Sep 2021 15:44:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw5on2k5aLCzxXzk3m9qxKxi3eGkHFXb3S9bPqVuBJkRaN4TRurqj8A8iqLea+KuQUdzENN X-Received: by 2002:a17:906:6b1a:: with SMTP id q26mr2887355ejr.185.1632782649076; Mon, 27 Sep 2021 15:44:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632782649; cv=none; d=google.com; s=arc-20160816; b=RPX830ndpQE8GmmOUIfDS55AaCeZnjiT+7JHODzKX+HfLvJ6O/jaaUHwjppI+CTuo+ CVvrCVGALFk/myBvx8DBfz7lMAqm6mBnH83cFeEFNDEH3bGlYezDqVbhVodEaxNJfINE 5KU+ReTO2ktbj3nIlOaWdUxhdYP3PAlAZcF2aYc7Zh1KJj+d4oB/FNPqIAN/O20ep1uW ImE14Rme8f8xiyOBnhMU9TVYHS5+FjZuaz4O1XWM3XFLOQI/nt5yLSsAO4mA5RXcfPZz ZgE8CGZSNi01euCHlFNyukL9fcfAOboTMDbDru36nhlmt4Za5IE+z76SwI+BuLGWO0v0 NUOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:delivered-to; bh=jOX4GtGoPpfhe/OtmiFEDodihan2NbMIy8MKmieyFtI=; b=BcSv/ma+Z/f1V95/gSWkX8KVyKCVj6l6uxd3qZA7lCEi6jLCdiImzTgcADyqGehD3p c9tLvEXstITdUhbprX3ctglj47Fed6Shr9RYcpc/vU1TCZ77HzJ9fDTiQBTP3VMu6s6Q uKrJo8xc6etLWkR/Kc12G3ZBimizOZPfUwcwYFd11xWfLoGP3cPZLWYfvMCHBSBrjxcx M0P7kLzh4WH9JcwDS+kc/klpLRgEEJ9Uq4GC65LAkYVz4TZeZHzfExEkOcY1+ZqMDDxb chCdrIzUKLWAZDyj5MDvXzInvd8oyesxtDyD61mEP1aRsMaex1AdpHftE1SoVMGiyPRH EXRA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id hs3si18700822ejc.368.2021.09.27.15.44.08; Mon, 27 Sep 2021 15:44:09 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9E082689F59; Tue, 28 Sep 2021 01:44:06 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-dmta-pe05-3.mx.upcmail.net (vie01a-dmta-pe05-3.mx.upcmail.net [84.116.36.13]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2F95268019F for ; Tue, 28 Sep 2021 01:44:00 +0300 (EEST) Received: from [172.31.216.235] (helo=vie01a-pemc-psmtp-pe12.mail.upcmail.net) by vie01a-dmta-pe05.mx.upcmail.net with esmtp (Exim 4.92) (envelope-from ) id 1mUzGR-00AiMf-0A for ffmpeg-devel@ffmpeg.org; Tue, 28 Sep 2021 00:38:23 +0200 Received: from localhost ([213.47.68.29]) by vie01a-pemc-psmtp-pe12.mail.upcmail.net with ESMTP id UzFTmCQ5fljeHUzFTmtFBh; Tue, 28 Sep 2021 00:37:23 +0200 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 213.47.68.29 X-CNFS-Analysis: v=2.3 cv=BoHjPrf5 c=1 sm=1 tr=0 a=2hcxjKEKjp0CzLx6oWAm4g==:117 a=2hcxjKEKjp0CzLx6oWAm4g==:17 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=ZZnuYtJkoWoA:10 a=NEAV23lmAAAA:8 a=Wtkdgx6NUtjDrLC6-jwA:9 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Tue, 28 Sep 2021 00:37:21 +0200 Message-Id: <20210927223722.25098-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 X-CMAE-Envelope: MS4wfAc8wxY+lIU9MPpuLL7nvkwsVTvhExQzC9dZ+U8qE90Dkyi8WO3hVWftI2w1f5wa7DtiS7+WsZ8aIx01mCg/lNitF9cvxWHivXlQJPf/Uvg7Wl20m4Vh A0znqnXLalk9GeWN37qZaDLs8U/liY1985MVZzsQWYYAZv+VnN6Lnq6z Subject: [FFmpeg-devel] [PATCH 1/2] avcodec/apedec: Fix undefined integer overflow in long_filter_ehigh_3830() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 9X/D5KEcj9qs Fixes: signed integer overflow: -2145648640 - 3357696 cannot be represented in type 'int' Fixes: 38899/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5358815017566208 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/apedec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c index 27d0ff35655..014b5615ece 100644 --- a/libavcodec/apedec.c +++ b/libavcodec/apedec.c @@ -979,7 +979,7 @@ static void long_filter_ehigh_3830(int32_t *buffer, int length) for (j = 7; j > 0; j--) delay[j] = delay[j - 1]; delay[0] = buffer[i]; - buffer[i] -= dotprod >> 9; + buffer[i] -= (unsigned)(dotprod >> 9); } }