From patchwork Wed Sep 29 19:16:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 30659 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:6506:0:0:0:0:0 with SMTP id z6csp682475iob; Wed, 29 Sep 2021 12:17:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwEqgD9WJEfN3EbQZwVtbwXwE/Y9zDBt75Yj7lNvnPejaW7armKXy52m7wodYnL/u9tQ8nX X-Received: by 2002:a17:906:7d42:: with SMTP id l2mr1753907ejp.467.1632943072094; Wed, 29 Sep 2021 12:17:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632943072; cv=none; d=google.com; s=arc-20160816; b=g9Q/ITg7ZftToMrOdqq0DA4nUGqkmuHQhlVdTlp3X3DkyMSfN69ybRXtWZA2aYTUBo wkbgUpMYtHGFYmfF+eDqM6I/2oDFqY8qA+t36tK82BVq5f77e9Hb4pqXXI+cNRAOOcme y13RD1BnSsfc5o6RjTSMmqht1pPqeiH8GvAZ6WOQAp4lnlBEROvzBacUjmlETCdaXKI2 BMdpquGXjqXb+WC0jv2anaTbML8s06MXttsgnCppfc8lisSXZVXpybRof96nOjjtsxg9 Op3qYAfzPOvw2AhvSz+NA1MG61yERfBL3r9Z624vZehoqJSGvR0y08swv1BrHaFTkmu6 KxNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:delivered-to; bh=CdSoZQXxePPLnVOF8i4VMJIO4i8cJ3HXDJrQmNgifHw=; b=oBxS74/pifEhHcAAKSGxjqf75JzcEysmZ99Q2MGpO7ICKKZePI57E90pTursX7pLpV ukGJTt2pHfjjcrxB8WEvcaYsmYOLHrTPjhCMXz9DbDLL9AbpjkcSMMgOrBvbBAi/+obx yc55sESHs/9U+KEIJ46DIJoEPVKNlCmL+57IUQmkZinWD2qNxWzJXMAwXgyW9ITwg35d N+bsX0YCPIxi+LQmNFgGqz3UQLvyEEqotQk0uFE9jizvERgJihsG1ZMTt2f6VjHukVRA 4Mz6eL8Hojah9uxRj4Vs1q2hwTZtg94Qrs5nXs24+t38Y0ApniRxN4Fly3xbky9k/pnr owzg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id c7si936363eja.538.2021.09.29.12.17.51; Wed, 29 Sep 2021 12:17:52 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C3C20680843; Wed, 29 Sep 2021 22:17:38 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-dmta-pe04-2.mx.upcmail.net (vie01a-dmta-pe04-2.mx.upcmail.net [62.179.121.164]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DEAAC68924E for ; Wed, 29 Sep 2021 22:17:30 +0300 (EEST) Received: from [172.31.216.235] (helo=vie01a-pemc-psmtp-pe12.mail.upcmail.net) by vie01a-dmta-pe04.mx.upcmail.net with esmtp (Exim 4.92) (envelope-from ) id 1mVf58-00GYJo-0C for ffmpeg-devel@ffmpeg.org; Wed, 29 Sep 2021 21:17:30 +0200 Received: from localhost ([213.47.68.29]) by vie01a-pemc-psmtp-pe12.mail.upcmail.net with ESMTP id Vf49myVr5ljeHVf4Am4EKZ; Wed, 29 Sep 2021 21:16:30 +0200 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 213.47.68.29 X-CNFS-Analysis: v=2.3 cv=BoHjPrf5 c=1 sm=1 tr=0 a=2hcxjKEKjp0CzLx6oWAm4g==:117 a=2hcxjKEKjp0CzLx6oWAm4g==:17 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=ZZnuYtJkoWoA:10 a=NEAV23lmAAAA:8 a=CrB1C1_abFsKnkldWO8A:9 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Wed, 29 Sep 2021 21:16:27 +0200 Message-Id: <20210929191629.9314-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 X-CMAE-Envelope: MS4wfKxsJQVBsB243tVlcawxSIQrGz+jRk/cba1q2Pe65n4K8ZMPDOfwI+SMFwoSRKZ/oPlYk8z8uOXJVHNnMX3mNUeHazKfkgrpZ5fZ98LYcKIkZNYn7R4m DtoOBY0Yq/hD49CuuL+a7ro4q82z2rhStp0amwrXXtBLZcA1FfpGgc4H Subject: [FFmpeg-devel] [PATCH 1/3] avformat/rmdec: Check for multiple audio_stream_info X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: yzUOTSFuWqX6 Fixes: memleak Fixes: 39166/clusterfuzz-testcase-minimized-ffmpeg_dem_IVR_fuzzer-5153276690038784 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/rmdec.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libavformat/rmdec.c b/libavformat/rmdec.c index d4ba6622a67..3a3f6aaf094 100644 --- a/libavformat/rmdec.c +++ b/libavformat/rmdec.c @@ -127,6 +127,10 @@ static int rm_read_audio_stream_info(AVFormatContext *s, AVIOContext *pb, uint32_t version; int ret; + // Duplicate tags + if (st->codecpar->codec_type == AVMEDIA_TYPE_AUDIO) + return AVERROR_INVALIDDATA; + /* ra type header */ version = avio_rb16(pb); /* version */ if (version == 3) {