diff mbox series

[FFmpeg-devel,1/3] swscale/swscale_internal: Avoid unsigned for slice parameters

Message ID 20210930171640.23713-1-michael@niedermayer.cc
State Accepted
Commit 9f40b5badbead0f454f195e88b4dc7950b40f665
Headers show
Series [FFmpeg-devel,1/3] swscale/swscale_internal: Avoid unsigned for slice parameters | expand

Commit Message

Michael Niedermayer Sept. 30, 2021, 5:16 p.m. UTC 
Mixing unsigned and signed often leads to unexpected arithmetic results.
Fixes: out of array write
Found-by: <durandal_1707>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libswscale/swscale_internal.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Paul B Mahol Sept. 30, 2021, 5:20 p.m. UTC | #1 
LGTM
Michael Niedermayer Sept. 30, 2021, 8:22 p.m. UTC | #2 
On Thu, Sep 30, 2021 at 07:20:44PM +0200, Paul B Mahol wrote:
> LGTM

will apply

thx

[...]
diff mbox series

Patch

diff --git a/libswscale/swscale_internal.h b/libswscale/swscale_internal.h
index e6e7b934b68..708facba676 100644
--- a/libswscale/swscale_internal.h
+++ b/libswscale/swscale_internal.h
@@ -311,8 +311,8 @@  typedef struct SwsContext {
     int              nb_slice_ctx;
 
     // values passed to current sws_receive_slice() call
-    unsigned int dst_slice_start;
-    unsigned int dst_slice_height;
+    int dst_slice_start;
+    int dst_slice_height;
 
     /**
      * Note that src, dst, srcStride, dstStride will be copied in the