diff mbox series

[FFmpeg-devel,2/2] Revert "arm: hevc_qpel: Fix the assembly to work with non-multiple of 8 widths"

Message ID 20211016173552.49482-2-jdek@itanimul.li
State New
Headers show
Series [FFmpeg-devel,1/2] lavc/arm: dont assign hevc_qpel non-multiple of 8 width stubs
Related show

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_ppc success Make finished
andriy/make_fate_ppc success Make fate finished

Commit Message

J. Dekker Oct. 16, 2021, 5:35 p.m. UTC
This reverts commit 2589060b92eeeb944c6e2b50e38412c0c5fabcf4.

Signed-off-by: J. Dekker <jdek@itanimul.li>
---
 libavcodec/arm/hevcdsp_qpel_neon.S | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

Comments

Martin Storsjö Oct. 18, 2021, 12:33 p.m. UTC | #1
On Sat, 16 Oct 2021, J. Dekker wrote:

> This reverts commit 2589060b92eeeb944c6e2b50e38412c0c5fabcf4.
>
> Signed-off-by: J. Dekker <jdek@itanimul.li>
> ---
> libavcodec/arm/hevcdsp_qpel_neon.S | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)

Ok, once commit 1/2 is finalized. But it would be good to explain why in 
the commit message too, e.g that the reverted commit just was added to 
appease the checkasm tests, but that this now has been fixed properly in 
the preceding patch. (It's probably good to first push the first patch so 
the commit hash for that gets settled, then mention that commit hash in 
this one before pushing it too.)

// Martin
diff mbox series

Patch

diff --git a/libavcodec/arm/hevcdsp_qpel_neon.S b/libavcodec/arm/hevcdsp_qpel_neon.S
index f71bec05ed..caa6efa766 100644
--- a/libavcodec/arm/hevcdsp_qpel_neon.S
+++ b/libavcodec/arm/hevcdsp_qpel_neon.S
@@ -237,7 +237,7 @@ 
         vld1.8    {d23}, [r2], r3
         bne 8b
         subs  r5, #8
-        ble       99f
+        beq       99f
         mov r4, r12
         add r6, #16
         mov r0, r6
@@ -280,7 +280,7 @@ 
         vld1.8    {d23}, [r2], r3
         bne 8b
         subs  r5, #8
-        ble       99f
+        beq       99f
         mov r4, r12
         add r6, #8
         mov r0, r6
@@ -310,7 +310,7 @@ 
         vld1.8    {d23}, [r2], r3
         bne 8b
         subs  r5, #8
-        ble       99f
+        beq       99f
         mov r4, r12
         add r6, #8
         mov r0, r6
@@ -377,7 +377,7 @@  endfunc
         vst1.16   {q7}, [r0], r1
         bne       8b
         subs      r5, #8
-        ble       99f
+        beq      99f
         mov       r4, r12
         add       r6, #16
         mov       r0, r6
@@ -417,7 +417,7 @@  endfunc
         vst1.8    d0, [r0], r1
         bne       8b
         subs      r5, #8
-        ble       99f
+        beq      99f
         mov       r4, r12
         add       r6, #8
         mov       r0, r6
@@ -446,7 +446,7 @@  endfunc
         vst1.8         d0, [r0], r1
         bne       8b
         subs      r5, #8
-        ble       99f
+        beq      99f
         mov       r4, r12
         add       r6, #8
         add       r10, #16
@@ -533,7 +533,7 @@  endfunc
         \filterh q7
         bne 8b
         subs  r5, #8
-        ble 99f
+        beq 99f
         mov r4, r12
         add r6, #16
         mov r0, r6
@@ -594,7 +594,7 @@  endfunc
         \filterh q7
         bne 8b
         subs  r5, #8
-        ble 99f
+        beq 99f
         mov r4, r12
         add r6, #8
         mov r0, r6
@@ -641,7 +641,7 @@  endfunc
         \filterh q7
         bne 8b
         subs  r5, #8
-        ble 99f
+        beq 99f
         mov r4, r12
         add r6, #8
         mov r0, r6