From patchwork Tue Nov 9 10:51:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: YuTong Song <13102179620@163.com> X-Patchwork-Id: 31340 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:d206:0:0:0:0:0 with SMTP id q6csp972875iob; Tue, 9 Nov 2021 02:52:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJxmRkhBWOppMYseCGMh9X6Rg8XoJZu9Wbh/DR43gkOrSRJvFGYIX/10ARQUESqo0iwbNZ8b X-Received: by 2002:a05:6402:2063:: with SMTP id bd3mr8700642edb.81.1636455141123; Tue, 09 Nov 2021 02:52:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1636455141; cv=none; d=google.com; s=arc-20160816; b=xkLOjrNv1vt9HiXNgkMXlhU+/LJGyOYi7Uhl2OYK+JXxUbK3iYqjFqOIUztcTNd1Mi GTxbDBbYwr16vEJwN0kmIEhBOrpKmDFIxY8F/ok7wUiE6qLj5X/Go6GY0dzz/94XkM7V CT+ZGd0OoFGQdTWtu32Re7U6mqw6u4wBP8AWfx4nPStkmlYDmOGdxnYVmteEnyyVWFX9 5Vgz/Jrxvr6b2UMlRan+VxsLHRQitmjvcO+QyhdCESRMiweGkL9n85x8zb68Xb7wT7y7 5RMl4dBUinxefGR3tnelOteAfARDffK21kyY2/NW874sZCpWK+srgOWBTo6TU/TGgmbi n7DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=pF2CbRyogqhRWOJT+v0STBJ1Yl3Ou1BbYXlsHQuqv9E=; b=q685tyrOfLDLerVwp9MqEb4mvvzASuC3MibICZU13HajAW2bZqGJSMpRl3bOvJ53lj H55HiyUFInbrQL+SloNbksUbiyOVeOxIsyzMKEW4x4A0JrjL/AWgUsciuXjF09AXM9F+ 5jZi//iBTX40ERgsEb0cS0ulk/MI+ZAVjtbO7nTJIjG0spNepw/2iTkJ7J0RIEl1VUDu LMbPllb/FMmRCKOHnzyDhQvrhFH6EVXdViYTln1p36HpD7kGnqQCGp+0FXA7njibNnAe MZpY+b4hmLyi2WQBjRH7Ro9jPiYrHuji9JlbYUEF7QFSQBlWHkwv4mz2Ew4xlxjIFdC6 YJFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@163.com header.s=s110527 header.b=NLNSO+rT; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=163.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id r15si32787107edx.487.2021.11.09.02.52.20; Tue, 09 Nov 2021 02:52:21 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@163.com header.s=s110527 header.b=NLNSO+rT; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1800768A113; Tue, 9 Nov 2021 12:52:16 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from m12-11.163.com (m12-11.163.com [220.181.12.11]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D2403689A24 for ; Tue, 9 Nov 2021 12:52:08 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=q/F8I SDuRwfYJVO0sDgkdSa+J0FEjvdfFU1sdv65j2o=; b=NLNSO+rTSUWSxYaZJsxKa Kj1IvLHYP00HpDIZT4vM5iFpPkLvmWXU88ud3iTYZQgWsF9RBxRw0g5rIuxy7LIE VuWdzCzeqz8+N6ndGabpAe5vfz4x1iJgriz3MIZyIAqkpY9j/lIpVs83VzlLCd7t 9dHG5yo2Ojf6tmWqnu+DCw= Received: from localhost.localdomain (unknown [103.107.216.230]) by smtp7 (Coremail) with SMTP id C8CowACX68jVUophAc+dDw--.42090S2; Tue, 09 Nov 2021 18:52:05 +0800 (CST) From: 13102179620@163.com To: ffmpeg-devel@ffmpeg.org Date: Tue, 9 Nov 2021 18:51:58 +0800 Message-Id: <20211109105158.9629-1-13102179620@163.com> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 X-CM-TRANSID: C8CowACX68jVUophAc+dDw--.42090S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrKFyxGr4UWFW7WFWrCF4fuFg_yoW3XFc_GF W8WFy8Ars0van7ta1UZFWrKw42gFs5ZrW8twsrtrW7AF95JFs8AwnrZrnIgw15Ja1UCF95 Kw1xXryxtw1aqjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU81KZJUUUUU== X-Originating-IP: [103.107.216.230] X-CM-SenderInfo: jprtiiisrxmlisq6il2tof0z/1tbiZRVGj18ZR2Ah6AAAsR Subject: [FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc: fix pixel buffer memory leak X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: songyutong Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: CqKSHREuYC5R From: songyutong In function vtenc_populate_extradata(), there is a manually created pixel buffer that has not been released. So we should use CVPixelBufferRelease to release this pixel buffer at the end, otherwise will cause a memory leak. --- libavcodec/videotoolboxenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index 8a02d3d1a0..c06b506cc9 100644 --- a/libavcodec/videotoolboxenc.c +++ b/libavcodec/videotoolboxenc.c @@ -2548,6 +2548,7 @@ static int vtenc_populate_extradata(AVCodecContext *avctx, pe_cleanup: + CVPixelBufferRelease(pix_buf); if(vtctx->session) CFRelease(vtctx->session);