diff mbox series

[FFmpeg-devel,v2,1/2] avfilter: add a hflip_vulkan filter

Message ID 20211118041850.7597-1-jianhua.wu@intel.com
State New
Headers show
Series [FFmpeg-devel,v2,1/2] avfilter: add a hflip_vulkan filter
Related show

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_ppc success Make finished
andriy/make_fate_ppc success Make fate finished

Commit Message

Wu Jianhua Nov. 18, 2021, 4:18 a.m. UTC
The following command is on how to apply hflip_vulkan filter:

ffmpeg -init_hw_device vulkan -i input.264 -vf hwupload=extra_hw_frames=16,hflip_vulkan,hwdownload,format=yuv420p output.264

Signed-off-by: Wu Jianhua <jianhua.wu@intel.com>
---
 configure                     |   1 +
 libavfilter/Makefile          |   1 +
 libavfilter/allfilters.c      |   1 +
 libavfilter/vf_hflip_vulkan.c | 276 ++++++++++++++++++++++++++++++++++
 4 files changed, 279 insertions(+)
 create mode 100644 libavfilter/vf_hflip_vulkan.c

Comments

Andreas Rheinhardt Nov. 18, 2021, 4:38 a.m. UTC | #1
Wu Jianhua:
> The following command is on how to apply hflip_vulkan filter:
> 
> ffmpeg -init_hw_device vulkan -i input.264 -vf hwupload=extra_hw_frames=16,hflip_vulkan,hwdownload,format=yuv420p output.264
> 
> Signed-off-by: Wu Jianhua <jianhua.wu@intel.com>
> ---
>  configure                     |   1 +
>  libavfilter/Makefile          |   1 +
>  libavfilter/allfilters.c      |   1 +
>  libavfilter/vf_hflip_vulkan.c | 276 ++++++++++++++++++++++++++++++++++
>  4 files changed, 279 insertions(+)
>  create mode 100644 libavfilter/vf_hflip_vulkan.c
> 

> +
> +static const AVOption hflip_vulkan_options[] = {
> +    { NULL },
> +};
> +
> +AVFILTER_DEFINE_CLASS(hflip_vulkan);
> +

What is the point of this class with its empty options?

> +static const AVFilterPad hflip_vulkan_inputs[] = {
> +    {
> +        .name         = "default",
> +        .type         = AVMEDIA_TYPE_VIDEO,
> +        .filter_frame = &hflip_vulkan_filter_frame,
> +        .config_props = &ff_vk_filter_config_input,
> +    }
> +};
> +
> +static const AVFilterPad hflip_vulkan_outputs[] = {
> +    {
> +        .name         = "default",
> +        .type         = AVMEDIA_TYPE_VIDEO,
> +        .config_props = &ff_vk_filter_config_output,
> +    }
> +};
> +
> +const AVFilter ff_vf_hflip_vulkan = {
> +    .name           = "hflip_vulkan",
> +    .description    = NULL_IF_CONFIG_SMALL("Horizontally flip the input video in Vulkan"),
> +    .priv_size      = sizeof(HFlipVulkanContext),
> +    .init           = &ff_vk_filter_init,
> +    .uninit         = &hflip_vulkan_uninit,
> +    FILTER_INPUTS(hflip_vulkan_inputs),
> +    FILTER_OUTPUTS(hflip_vulkan_outputs),
> +    FILTER_SINGLE_PIXFMT(AV_PIX_FMT_VULKAN),
> +    .priv_class     = &hflip_vulkan_class,
> +    .flags_internal = FF_FILTER_FLAG_HWFRAME_AWARE,
> +};
>
Wu Jianhua Nov. 18, 2021, 5:04 a.m. UTC | #2
Andreas Rheinhardt wrote:
> Wu Jianhua:
> > The following command is on how to apply hflip_vulkan filter:
> >
> > ffmpeg -init_hw_device vulkan -i input.264 -vf
> >
> hwupload=extra_hw_frames=16,hflip_vulkan,hwdownload,format=yuv420p
> > output.264
> >
> > Signed-off-by: Wu Jianhua <jianhua.wu@intel.com>
> > ---
> >  configure                     |   1 +
> >  libavfilter/Makefile          |   1 +
> >  libavfilter/allfilters.c      |   1 +
> >  libavfilter/vf_hflip_vulkan.c | 276
> > ++++++++++++++++++++++++++++++++++
> >  4 files changed, 279 insertions(+)
> >  create mode 100644 libavfilter/vf_hflip_vulkan.c
> >
> 
> > +
> > +static const AVOption hflip_vulkan_options[] = {
> > +    { NULL },
> > +};
> > +
> > +AVFILTER_DEFINE_CLASS(hflip_vulkan);
> > +
> 
> What is the point of this class with its empty options?

The AVFILTER_DEFINE_CLASS needs the hflip_vulkan_options and the reason why it's NULL
is that the most other filters do it like that.

> 
> > +static const AVFilterPad hflip_vulkan_inputs[] = {
> > +    {
> > +        .name         = "default",
> > +        .type         = AVMEDIA_TYPE_VIDEO,
> > +        .filter_frame = &hflip_vulkan_filter_frame,
> > +        .config_props = &ff_vk_filter_config_input,
> > +    }
> > +};
> > +
> > +static const AVFilterPad hflip_vulkan_outputs[] = {
> > +    {
> > +        .name         = "default",
> > +        .type         = AVMEDIA_TYPE_VIDEO,
> > +        .config_props = &ff_vk_filter_config_output,
> > +    }
> > +};
> > +
> > +const AVFilter ff_vf_hflip_vulkan = {
> > +    .name           = "hflip_vulkan",
> > +    .description    = NULL_IF_CONFIG_SMALL("Horizontally flip the input
> video in Vulkan"),
> > +    .priv_size      = sizeof(HFlipVulkanContext),
> > +    .init           = &ff_vk_filter_init,
> > +    .uninit         = &hflip_vulkan_uninit,
> > +    FILTER_INPUTS(hflip_vulkan_inputs),
> > +    FILTER_OUTPUTS(hflip_vulkan_outputs),
> > +    FILTER_SINGLE_PIXFMT(AV_PIX_FMT_VULKAN),
> > +    .priv_class     = &hflip_vulkan_class,
> > +    .flags_internal = FF_FILTER_FLAG_HWFRAME_AWARE, };
> >
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org
> with subject "unsubscribe".
Andreas Rheinhardt Nov. 18, 2021, 5:26 a.m. UTC | #3
Wu, Jianhua:
> Andreas Rheinhardt wrote:
>> Wu Jianhua:
>>> The following command is on how to apply hflip_vulkan filter:
>>>
>>> ffmpeg -init_hw_device vulkan -i input.264 -vf
>>>
>> hwupload=extra_hw_frames=16,hflip_vulkan,hwdownload,format=yuv420p
>>> output.264
>>>
>>> Signed-off-by: Wu Jianhua <jianhua.wu@intel.com>
>>> ---
>>>  configure                     |   1 +
>>>  libavfilter/Makefile          |   1 +
>>>  libavfilter/allfilters.c      |   1 +
>>>  libavfilter/vf_hflip_vulkan.c | 276
>>> ++++++++++++++++++++++++++++++++++
>>>  4 files changed, 279 insertions(+)
>>>  create mode 100644 libavfilter/vf_hflip_vulkan.c
>>>
>>
>>> +
>>> +static const AVOption hflip_vulkan_options[] = {
>>> +    { NULL },
>>> +};
>>> +
>>> +AVFILTER_DEFINE_CLASS(hflip_vulkan);
>>> +
>>
>> What is the point of this class with its empty options?
> 
> The AVFILTER_DEFINE_CLASS needs the hflip_vulkan_options and the reason why it's NULL
> is that the most other filters do it like that.
> 

And why do you add an AVClass at all?
(The reason that there are some filters with AVClass and empty options
is a bug in avfilter_init_str() which errors out when given options for
a filter without AVClass, although it is perfectly fine to set options
on a filter without AVClass, namely generic AVFilter options (this is
important for e.g. framesync filters, but not for this filter here).)

>>
>>> +static const AVFilterPad hflip_vulkan_inputs[] = {
>>> +    {
>>> +        .name         = "default",
>>> +        .type         = AVMEDIA_TYPE_VIDEO,
>>> +        .filter_frame = &hflip_vulkan_filter_frame,
>>> +        .config_props = &ff_vk_filter_config_input,
>>> +    }
>>> +};
>>> +
>>> +static const AVFilterPad hflip_vulkan_outputs[] = {
>>> +    {
>>> +        .name         = "default",
>>> +        .type         = AVMEDIA_TYPE_VIDEO,
>>> +        .config_props = &ff_vk_filter_config_output,
>>> +    }
>>> +};
>>> +
>>> +const AVFilter ff_vf_hflip_vulkan = {
>>> +    .name           = "hflip_vulkan",
>>> +    .description    = NULL_IF_CONFIG_SMALL("Horizontally flip the input
>> video in Vulkan"),
>>> +    .priv_size      = sizeof(HFlipVulkanContext),
>>> +    .init           = &ff_vk_filter_init,
>>> +    .uninit         = &hflip_vulkan_uninit,
>>> +    FILTER_INPUTS(hflip_vulkan_inputs),
>>> +    FILTER_OUTPUTS(hflip_vulkan_outputs),
>>> +    FILTER_SINGLE_PIXFMT(AV_PIX_FMT_VULKAN),
>>> +    .priv_class     = &hflip_vulkan_class,
>>> +    .flags_internal = FF_FILTER_FLAG_HWFRAME_AWARE, };
>>>
Wu Jianhua Nov. 18, 2021, 5:59 a.m. UTC | #4
> Andreas Rheinhardt: 
> Wu, Jianhua:
> > Andreas Rheinhardt wrote:
> >> Wu Jianhua:
> >>> The following command is on how to apply hflip_vulkan filter:
> >>>
> >>> ffmpeg -init_hw_device vulkan -i input.264 -vf
> >>>
> >>
> hwupload=extra_hw_frames=16,hflip_vulkan,hwdownload,format=yuv420p
> >>> output.264
> >>>
> >>> Signed-off-by: Wu Jianhua <jianhua.wu@intel.com>
> >>> ---
> >>>  configure                     |   1 +
> >>>  libavfilter/Makefile          |   1 +
> >>>  libavfilter/allfilters.c      |   1 +
> >>>  libavfilter/vf_hflip_vulkan.c | 276
> >>> ++++++++++++++++++++++++++++++++++
> >>>  4 files changed, 279 insertions(+)
> >>>  create mode 100644 libavfilter/vf_hflip_vulkan.c
> >>>
> >>
> >>> +
> >>> +static const AVOption hflip_vulkan_options[] = {
> >>> +    { NULL },
> >>> +};
> >>> +
> >>> +AVFILTER_DEFINE_CLASS(hflip_vulkan);
> >>> +
> >>
> >> What is the point of this class with its empty options?
> >
> > The AVFILTER_DEFINE_CLASS needs the hflip_vulkan_options and the
> > reason why it's NULL is that the most other filters do it like that.
> >
> 
> And why do you add an AVClass at all?
> (The reason that there are some filters with AVClass and empty options is a
> bug in avfilter_init_str() which errors out when given options for a filter
> without AVClass, although it is perfectly fine to set options on a filter without
> AVClass, namely generic AVFilter options (this is important for e.g. framesync
> filters, but not for this filter here).)
> 

Simply I think it is a convention. Yeah. It's not needed at all. I'll remove it and update later.
Paul B Mahol Nov. 18, 2021, 10:23 a.m. UTC | #5
On Thu, Nov 18, 2021 at 6:59 AM Wu, Jianhua <jianhua.wu@intel.com> wrote:

> > Andreas Rheinhardt:
> > Wu, Jianhua:
> > > Andreas Rheinhardt wrote:
> > >> Wu Jianhua:
> > >>> The following command is on how to apply hflip_vulkan filter:
> > >>>
> > >>> ffmpeg -init_hw_device vulkan -i input.264 -vf
> > >>>
> > >>
> > hwupload=extra_hw_frames=16,hflip_vulkan,hwdownload,format=yuv420p
> > >>> output.264
> > >>>
> > >>> Signed-off-by: Wu Jianhua <jianhua.wu@intel.com>
> > >>> ---
> > >>>  configure                     |   1 +
> > >>>  libavfilter/Makefile          |   1 +
> > >>>  libavfilter/allfilters.c      |   1 +
> > >>>  libavfilter/vf_hflip_vulkan.c | 276
> > >>> ++++++++++++++++++++++++++++++++++
> > >>>  4 files changed, 279 insertions(+)
> > >>>  create mode 100644 libavfilter/vf_hflip_vulkan.c
> > >>>
> > >>
> > >>> +
> > >>> +static const AVOption hflip_vulkan_options[] = {
> > >>> +    { NULL },
> > >>> +};
> > >>> +
> > >>> +AVFILTER_DEFINE_CLASS(hflip_vulkan);
> > >>> +
> > >>
> > >> What is the point of this class with its empty options?
> > >
> > > The AVFILTER_DEFINE_CLASS needs the hflip_vulkan_options and the
> > > reason why it's NULL is that the most other filters do it like that.
> > >
> >
> > And why do you add an AVClass at all?
> > (The reason that there are some filters with AVClass and empty options
> is a
> > bug in avfilter_init_str() which errors out when given options for a
> filter
> > without AVClass, although it is perfectly fine to set options on a
> filter without
> > AVClass, namely generic AVFilter options (this is important for e.g.
> framesync
> > filters, but not for this filter here).)
> >
>
> Simply I think it is a convention. Yeah. It's not needed at all. I'll
> remove it and update later.
>

Do not do it if it breaks timeline support.
Paul B Mahol Nov. 18, 2021, 10:24 a.m. UTC | #6
On Thu, Nov 18, 2021 at 6:27 AM Andreas Rheinhardt <
andreas.rheinhardt@outlook.com> wrote:

> Wu, Jianhua:
> > Andreas Rheinhardt wrote:
> >> Wu Jianhua:
> >>> The following command is on how to apply hflip_vulkan filter:
> >>>
> >>> ffmpeg -init_hw_device vulkan -i input.264 -vf
> >>>
> >> hwupload=extra_hw_frames=16,hflip_vulkan,hwdownload,format=yuv420p
> >>> output.264
> >>>
> >>> Signed-off-by: Wu Jianhua <jianhua.wu@intel.com>
> >>> ---
> >>>  configure                     |   1 +
> >>>  libavfilter/Makefile          |   1 +
> >>>  libavfilter/allfilters.c      |   1 +
> >>>  libavfilter/vf_hflip_vulkan.c | 276
> >>> ++++++++++++++++++++++++++++++++++
> >>>  4 files changed, 279 insertions(+)
> >>>  create mode 100644 libavfilter/vf_hflip_vulkan.c
> >>>
> >>
> >>> +
> >>> +static const AVOption hflip_vulkan_options[] = {
> >>> +    { NULL },
> >>> +};
> >>> +
> >>> +AVFILTER_DEFINE_CLASS(hflip_vulkan);
> >>> +
> >>
> >> What is the point of this class with its empty options?
> >
> > The AVFILTER_DEFINE_CLASS needs the hflip_vulkan_options and the reason
> why it's NULL
> > is that the most other filters do it like that.
> >
>
> And why do you add an AVClass at all?
> (The reason that there are some filters with AVClass and empty options
> is a bug in avfilter_init_str() which errors out when given options for
> a filter without AVClass, although it is perfectly fine to set options
> on a filter without AVClass, namely generic AVFilter options (this is
> important for e.g. framesync filters, but not for this filter here).)
>

There are abandoned patches of yours that resolved this.

>
> >>
> >>> +static const AVFilterPad hflip_vulkan_inputs[] = {
> >>> +    {
> >>> +        .name         = "default",
> >>> +        .type         = AVMEDIA_TYPE_VIDEO,
> >>> +        .filter_frame = &hflip_vulkan_filter_frame,
> >>> +        .config_props = &ff_vk_filter_config_input,
> >>> +    }
> >>> +};
> >>> +
> >>> +static const AVFilterPad hflip_vulkan_outputs[] = {
> >>> +    {
> >>> +        .name         = "default",
> >>> +        .type         = AVMEDIA_TYPE_VIDEO,
> >>> +        .config_props = &ff_vk_filter_config_output,
> >>> +    }
> >>> +};
> >>> +
> >>> +const AVFilter ff_vf_hflip_vulkan = {
> >>> +    .name           = "hflip_vulkan",
> >>> +    .description    = NULL_IF_CONFIG_SMALL("Horizontally flip the
> input
> >> video in Vulkan"),
> >>> +    .priv_size      = sizeof(HFlipVulkanContext),
> >>> +    .init           = &ff_vk_filter_init,
> >>> +    .uninit         = &hflip_vulkan_uninit,
> >>> +    FILTER_INPUTS(hflip_vulkan_inputs),
> >>> +    FILTER_OUTPUTS(hflip_vulkan_outputs),
> >>> +    FILTER_SINGLE_PIXFMT(AV_PIX_FMT_VULKAN),
> >>> +    .priv_class     = &hflip_vulkan_class,
> >>> +    .flags_internal = FF_FILTER_FLAG_HWFRAME_AWARE, };
> >>>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
Wu Jianhua Nov. 19, 2021, 2:49 p.m. UTC | #7
Paul B Mahol wrote:
> Sent: Thursday, November 18, 2021 6:24 PM
> To: FFmpeg development discussions and patches <ffmpeg-
> devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] avfilter: add a hflip_vulkan filter
> 
> On Thu, Nov 18, 2021 at 6:59 AM Wu, Jianhua <jianhua.wu@intel.com> wrote:
> 
> > > Andreas Rheinhardt:
> > > Wu, Jianhua:
> > > > Andreas Rheinhardt wrote:
> > > >> Wu Jianhua:
> > > >>> The following command is on how to apply hflip_vulkan filter:
> > > >>>
> > > >>> ffmpeg -init_hw_device vulkan -i input.264 -vf
> > > >>>
> > > >>
> > >
> hwupload=extra_hw_frames=16,hflip_vulkan,hwdownload,format=yuv420p
> > > >>> output.264
> > > >>>
> > > >>> Signed-off-by: Wu Jianhua <jianhua.wu@intel.com>
> > > >>> ---
> > > >>>  configure                     |   1 +
> > > >>>  libavfilter/Makefile          |   1 +
> > > >>>  libavfilter/allfilters.c      |   1 +
> > > >>>  libavfilter/vf_hflip_vulkan.c | 276
> > > >>> ++++++++++++++++++++++++++++++++++
> > > >>>  4 files changed, 279 insertions(+)  create mode 100644
> > > >>> libavfilter/vf_hflip_vulkan.c
> > > >>>
> > > >>
> > > >>> +
> > > >>> +static const AVOption hflip_vulkan_options[] = {
> > > >>> +    { NULL },
> > > >>> +};
> > > >>> +
> > > >>> +AVFILTER_DEFINE_CLASS(hflip_vulkan);
> > > >>> +
> > > >>
> > > >> What is the point of this class with its empty options?
> > > >
> > > > The AVFILTER_DEFINE_CLASS needs the hflip_vulkan_options and the
> > > > reason why it's NULL is that the most other filters do it like that.
> > > >
> > >
> > > And why do you add an AVClass at all?
> > > (The reason that there are some filters with AVClass and empty
> > > options
> > is a
> > > bug in avfilter_init_str() which errors out when given options for a
> > filter
> > > without AVClass, although it is perfectly fine to set options on a
> > filter without
> > > AVClass, namely generic AVFilter options (this is important for e.g.
> > framesync
> > > filters, but not for this filter here).)
> > >
> >
> > Simply I think it is a convention. Yeah. It's not needed at all. I'll
> > remove it and update later.
> >
> 
> Do not do it if it breaks timeline support.
> 

Got it. I'll keep them here in the next version.

Thanks,
Jianhua
diff mbox series

Patch

diff --git a/configure b/configure
index 1b47f6512d..f1551063d0 100755
--- a/configure
+++ b/configure
@@ -3614,6 +3614,7 @@  frei0r_filter_deps="frei0r"
 frei0r_src_filter_deps="frei0r"
 fspp_filter_deps="gpl"
 gblur_vulkan_filter_deps="vulkan libglslang"
+hflip_vulkan_filter_deps="vulkan libglslang"
 histeq_filter_deps="gpl"
 hqdn3d_filter_deps="gpl"
 interlace_filter_deps="gpl"
diff --git a/libavfilter/Makefile b/libavfilter/Makefile
index 07b4a639ec..31d922f75c 100644
--- a/libavfilter/Makefile
+++ b/libavfilter/Makefile
@@ -298,6 +298,7 @@  OBJS-$(CONFIG_GREYEDGE_FILTER)               += vf_colorconstancy.o
 OBJS-$(CONFIG_GUIDED_FILTER)                 += vf_guided.o
 OBJS-$(CONFIG_HALDCLUT_FILTER)               += vf_lut3d.o framesync.o
 OBJS-$(CONFIG_HFLIP_FILTER)                  += vf_hflip.o
+OBJS-$(CONFIG_HFLIP_VULKAN_FILTER)           += vf_hflip_vulkan.o vulkan.o
 OBJS-$(CONFIG_HISTEQ_FILTER)                 += vf_histeq.o
 OBJS-$(CONFIG_HISTOGRAM_FILTER)              += vf_histogram.o
 OBJS-$(CONFIG_HQDN3D_FILTER)                 += vf_hqdn3d.o
diff --git a/libavfilter/allfilters.c b/libavfilter/allfilters.c
index 29da7ef0d2..82c50cba49 100644
--- a/libavfilter/allfilters.c
+++ b/libavfilter/allfilters.c
@@ -283,6 +283,7 @@  extern const AVFilter ff_vf_greyedge;
 extern const AVFilter ff_vf_guided;
 extern const AVFilter ff_vf_haldclut;
 extern const AVFilter ff_vf_hflip;
+extern const AVFilter ff_vf_hflip_vulkan;
 extern const AVFilter ff_vf_histeq;
 extern const AVFilter ff_vf_histogram;
 extern const AVFilter ff_vf_hqdn3d;
diff --git a/libavfilter/vf_hflip_vulkan.c b/libavfilter/vf_hflip_vulkan.c
new file mode 100644
index 0000000000..9d164199fe
--- /dev/null
+++ b/libavfilter/vf_hflip_vulkan.c
@@ -0,0 +1,276 @@ 
+/*
+ * copyright (c) 2021 Wu Jianhua <jianhua.wu@intel.com>
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * FFmpeg is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with FFmpeg; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+#include "libavutil/random_seed.h"
+#include "libavutil/opt.h"
+#include "vulkan.h"
+#include "internal.h"
+
+#define CGS 32
+
+typedef struct HFlipVulkanContext {
+    FFVulkanContext vkctx;
+    FFVkQueueFamilyCtx qf;
+    FFVkExecContext *exec;
+    FFVulkanPipeline *pl;
+
+    VkDescriptorImageInfo input_images[3];
+    VkDescriptorImageInfo output_images[3];
+
+    int initialized;
+} HFlipVulkanContext;
+
+static av_cold int init_filter(AVFilterContext *ctx, AVFrame *in)
+{
+    int err = 0;
+    FFSPIRVShader *shd;
+    HFlipVulkanContext *s = ctx->priv;
+    const int planes = av_pix_fmt_count_planes(s->vkctx.output_format);
+
+    FFVulkanDescriptorSetBinding image_descs[] = {
+        {
+            .name       = "input_image",
+            .type       = VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
+            .dimensions = 2,
+            .elems      = planes,
+            .stages     = VK_SHADER_STAGE_COMPUTE_BIT,
+            .updater    = s->input_images,
+        },
+        {
+            .name       = "output_image",
+            .type       = VK_DESCRIPTOR_TYPE_STORAGE_IMAGE,
+            .mem_layout = ff_vk_shader_rep_fmt(s->vkctx.output_format),
+            .mem_quali  = "writeonly",
+            .dimensions = 2,
+            .elems      = planes,
+            .stages     = VK_SHADER_STAGE_COMPUTE_BIT,
+            .updater    = s->output_images,
+        },
+    };
+
+    image_descs[0].sampler = ff_vk_init_sampler(ctx, 1, VK_FILTER_LINEAR);
+    if (!image_descs[0].sampler)
+            return AVERROR_EXTERNAL;
+
+    ff_vk_qf_init(ctx, &s->qf, VK_QUEUE_COMPUTE_BIT, 0);
+
+    {
+        s->pl = ff_vk_create_pipeline(ctx, &s->qf);
+        if (!s->pl)
+            return AVERROR(ENOMEM);
+
+        shd = ff_vk_init_shader(ctx, s->pl, "hflip_compute", image_descs[0].stages);
+        if (!shd)
+            return AVERROR(ENOMEM);
+
+        ff_vk_set_compute_shader_sizes(ctx, shd, (int [3]){ CGS, 1, 1 });
+        RET(ff_vk_add_descriptor_set(ctx, s->pl, shd, image_descs, FF_ARRAY_ELEMS(image_descs), 0));
+
+        GLSLC(0, void main()                                                                   );
+        GLSLC(0, {                                                                             );
+        GLSLC(1,     ivec2 size;                                                               );
+        GLSLC(1,     const ivec2 pos = ivec2(gl_GlobalInvocationID.xy);                        );
+        for (int i = 0; i < planes; i++) {
+            GLSLC(0,                                                                           );
+            GLSLF(1, size = imageSize(output_image[%i]);                                     ,i);
+            GLSLC(1, if (IS_WITHIN(pos, size)) {                                               );
+            GLSLF(2,     vec4 res = texture(input_image[%i], ivec2(size.x - pos.x, pos.y));  ,i);
+            GLSLF(2,     imageStore(output_image[%i], pos, res);                             ,i);
+            GLSLC(1, }                                                                         );
+        }
+        GLSLC(0, }                                                                             );
+
+        RET(ff_vk_compile_shader(ctx, shd, "main"));
+        RET(ff_vk_init_pipeline_layout(ctx, s->pl));
+        RET(ff_vk_init_compute_pipeline(ctx, s->pl));
+    }
+
+    RET(ff_vk_create_exec_ctx(ctx, &s->exec, &s->qf));
+    s->initialized = 1;
+
+fail:
+    return err;
+}
+
+static av_cold void hflip_vulkan_uninit(AVFilterContext *avctx)
+{
+    HFlipVulkanContext *s = avctx->priv;
+    ff_vk_filter_uninit(avctx);
+
+    s->initialized = 0;
+}
+
+static int process_frames(AVFilterContext *avctx, AVFrame *outframe, AVFrame *inframe)
+{
+    int err = 0;
+    VkCommandBuffer cmd_buf;
+    HFlipVulkanContext *s = avctx->priv;
+    FFVulkanFunctions *vk = &s->vkctx.vkfn;
+    AVVkFrame *in = (AVVkFrame *)inframe->data[0];
+    AVVkFrame *out = (AVVkFrame *)outframe->data[0];
+    const int planes = av_pix_fmt_count_planes(s->vkctx.output_format);
+    const VkFormat *input_formats = av_vkfmt_from_pixfmt(s->vkctx.input_format);
+    const VkFormat *output_formats = av_vkfmt_from_pixfmt(s->vkctx.output_format);
+
+    ff_vk_start_exec_recording(avctx, s->exec);
+    cmd_buf = ff_vk_get_exec_buf(avctx, s->exec);
+
+    for (int i = 0; i < planes; i++) {
+        RET(ff_vk_create_imageview(avctx, s->exec, &s->input_images[i].imageView,
+                                   in->img[i],
+                                   input_formats[i],
+                                   ff_comp_identity_map));
+
+        RET(ff_vk_create_imageview(avctx, s->exec, &s->output_images[i].imageView,
+                                   out->img[i],
+                                   output_formats[i],
+                                   ff_comp_identity_map));
+
+        s->input_images[i].imageLayout  = VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL;
+        s->output_images[i].imageLayout = VK_IMAGE_LAYOUT_GENERAL;
+    }
+
+    ff_vk_update_descriptor_set(avctx, s->pl, 0);
+
+    for (int i = 0; i < planes; i++) {
+        VkImageMemoryBarrier barriers[] = {
+            {
+                .sType                       = VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER,
+                .srcAccessMask               = 0,
+                .dstAccessMask               = VK_ACCESS_SHADER_READ_BIT,
+                .oldLayout                   = in->layout[i],
+                .newLayout                   = s->input_images[i].imageLayout,
+                .srcQueueFamilyIndex         = VK_QUEUE_FAMILY_IGNORED,
+                .dstQueueFamilyIndex         = VK_QUEUE_FAMILY_IGNORED,
+                .image                       = in->img[i],
+                .subresourceRange.aspectMask = VK_IMAGE_ASPECT_COLOR_BIT,
+                .subresourceRange.levelCount = 1,
+                .subresourceRange.layerCount = 1,
+            },
+            {
+                .sType                       = VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER,
+                .srcAccessMask               = 0,
+                .dstAccessMask               = VK_ACCESS_SHADER_WRITE_BIT,
+                .oldLayout                   = out->layout[i],
+                .newLayout                   = s->output_images[i].imageLayout,
+                .srcQueueFamilyIndex         = VK_QUEUE_FAMILY_IGNORED,
+                .dstQueueFamilyIndex         = VK_QUEUE_FAMILY_IGNORED,
+                .image                       = out->img[i],
+                .subresourceRange.aspectMask = VK_IMAGE_ASPECT_COLOR_BIT,
+                .subresourceRange.levelCount = 1,
+                .subresourceRange.layerCount = 1,
+            },
+        };
+
+        vk->CmdPipelineBarrier(cmd_buf, VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT,
+                               VK_PIPELINE_STAGE_COMPUTE_SHADER_BIT, 0,
+                               0, NULL, 0, NULL, FF_ARRAY_ELEMS(barriers), barriers);
+
+        in->layout[i]  = barriers[0].newLayout;
+        in->access[i]  = barriers[0].dstAccessMask;
+
+        out->layout[i] = barriers[1].newLayout;
+        out->access[i] = barriers[1].dstAccessMask;
+    }
+
+    ff_vk_bind_pipeline_exec(avctx, s->exec, s->pl);
+    vk->CmdDispatch(cmd_buf, FFALIGN(s->vkctx.output_width, CGS)/CGS,
+                    s->vkctx.output_height, 1);
+
+    ff_vk_add_exec_dep(avctx, s->exec, inframe, VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT);
+    ff_vk_add_exec_dep(avctx, s->exec, outframe, VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT);
+
+    err = ff_vk_submit_exec_queue(avctx, s->exec);
+    if (err)
+        return err;
+
+    ff_vk_qf_rotate(&s->qf);
+
+    return 0;
+fail:
+    ff_vk_discard_exec_deps(avctx, s->exec);
+    return err;
+}
+
+static int hflip_vulkan_filter_frame(AVFilterLink *link, AVFrame *in)
+{
+    int err;
+    AVFrame *out = NULL;
+    AVFilterContext *ctx = link->dst;
+    HFlipVulkanContext *s = ctx->priv;
+    AVFilterLink *outlink = ctx->outputs[0];
+
+    out = ff_get_video_buffer(outlink, outlink->w, outlink->h);
+    if (!out) {
+        err = AVERROR(ENOMEM);
+        goto fail;
+    }
+
+    if (!s->initialized)
+        RET(init_filter(ctx, in));
+
+    RET(process_frames(ctx, out, in));
+
+    RET(av_frame_copy_props(out, in));
+
+    av_frame_free(&in);
+
+    return ff_filter_frame(outlink, out);
+
+fail:
+    av_frame_free(&in);
+    av_frame_free(&out);
+    return err;
+}
+
+static const AVOption hflip_vulkan_options[] = {
+    { NULL },
+};
+
+AVFILTER_DEFINE_CLASS(hflip_vulkan);
+
+static const AVFilterPad hflip_vulkan_inputs[] = {
+    {
+        .name         = "default",
+        .type         = AVMEDIA_TYPE_VIDEO,
+        .filter_frame = &hflip_vulkan_filter_frame,
+        .config_props = &ff_vk_filter_config_input,
+    }
+};
+
+static const AVFilterPad hflip_vulkan_outputs[] = {
+    {
+        .name         = "default",
+        .type         = AVMEDIA_TYPE_VIDEO,
+        .config_props = &ff_vk_filter_config_output,
+    }
+};
+
+const AVFilter ff_vf_hflip_vulkan = {
+    .name           = "hflip_vulkan",
+    .description    = NULL_IF_CONFIG_SMALL("Horizontally flip the input video in Vulkan"),
+    .priv_size      = sizeof(HFlipVulkanContext),
+    .init           = &ff_vk_filter_init,
+    .uninit         = &hflip_vulkan_uninit,
+    FILTER_INPUTS(hflip_vulkan_inputs),
+    FILTER_OUTPUTS(hflip_vulkan_outputs),
+    FILTER_SINGLE_PIXFMT(AV_PIX_FMT_VULKAN),
+    .priv_class     = &hflip_vulkan_class,
+    .flags_internal = FF_FILTER_FLAG_HWFRAME_AWARE,
+};