From patchwork Wed Nov 24 11:57:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Werner Robitza X-Patchwork-Id: 31623 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:d206:0:0:0:0:0 with SMTP id q6csp10298318iob; Wed, 24 Nov 2021 03:58:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJxbvqNiDMZ5YKTQh0o09CPYVUYl+38++gT+U1PAAOrlHD6ejzP8YMjbqw8+1nYKZNEfPQ0q X-Received: by 2002:a17:907:2627:: with SMTP id aq7mr18744478ejc.483.1637755083100; Wed, 24 Nov 2021 03:58:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1637755083; cv=none; d=google.com; s=arc-20160816; b=QyKFHcmloIznPGDvDP2SzQa4XjbV9/CwcO8/602aZYZOI0dpDq/yCHRX5srmEEYPrY HXUDJzqTrKYWxE5sUA3WYqS0xOYR/Y/ycU6n4zbW6ptjDs1lVuXZjIEtKo2ktD/QapSl v8pCuwejX3MwYdcZHrbvuynPAbmShPYArFLZIgRn66ecmZQ2vV+8jh3eSrat5a4kJ8FB cJ/YOzW9myeP+Pt26MTzR4AJV2sYy3jhrp6s4A1WSe4GDPFKy1Yq+HKBI/Trc4G9m+Eq ySzOKcCD3oeOKMYtOiPrNsqopcHmAF8g1sXfNAFhocGcz4VML+8DT0h61z3UcEDNQu/9 Ev+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=hI7If9g9HQtvGQwTyRN0VbSF1dpljJ0//zyHG7DqP4c=; b=EQIDan8+E/8yYMZEPRcSvww0JNEbyrghClp+krG/9WVRDBk9s3rLwAUwqbU+jZ98aY QghuY7aixdKRKz25fAWzyFSNzpa9I08dEMUqsd6z3vodDDTfcC2k3RrWujCXYCHgkMfT 0nkYYXL1AsOiempvLHZ9C/q4xX23zeiDEJVsgaMpiPmIRe9uv+mFTpedjEh+6i25/CrW iD5HoLDgy4N2HU9ujhLo+5fFpy+eMdkVXyKd1WQ61d8Mu1N9K4m5J8KaKa5yngLlYDVw AGQwFoWv8T5dhuqO63xb3vdFToAUCK0Z6GfxLgW2p23Dsp03ViOPEQzSHILJOyu/0fX5 C5sA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=a1P6IkAO; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id hd20si45865368ejc.86.2021.11.24.03.58.02; Wed, 24 Nov 2021 03:58:03 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=a1P6IkAO; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7B345689F08; Wed, 24 Nov 2021 13:57:58 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DFF9868A36E for ; Wed, 24 Nov 2021 13:57:51 +0200 (EET) Received: by mail-wr1-f44.google.com with SMTP id d24so3817072wra.0 for ; Wed, 24 Nov 2021 03:57:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ckf5aVQRoqvy2UCqXfXDsfHWXWsfdoj6VQ38f/Wv8TQ=; b=a1P6IkAOxdfwpw0aXt2iPvs58E+Bral+7maJHMo/aMOMM81DrJIVeD2JBjH8cxO8Sg sLIgxWDpV2XO16CRUDAhkGdD+FKR/FnUkkAfi3bXZTN64Z8e5nDpa7yO4vRMCbr8Cl2X antpWhjPNNFXAO0zh4Ug49/jTNJSnN7APPlqfOiZ2KqcUbvsHqRu4HItRzZJUw89DNOe CrymWuwX4xbmh+tJBa0QSaCURYzUAMWdOAjxQH0Qjka3lPRSCw2Su25XsFl4Rcn9zDNN 9r5g0fm5UDelUvSTXIiUjbycjVkggBvpmJ0sZHMNcRgkq5kBFZwUtFjW3SaUNsoEEdli ErgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ckf5aVQRoqvy2UCqXfXDsfHWXWsfdoj6VQ38f/Wv8TQ=; b=zKS0Isc6r5O3xmLzg4DjLIT8aMZdiXM/wWmh3C409u6pscpW5++eyjdM5lYoyDd9Yo j0ASpms3/7PMbkE0i4puFbtGlWJ8t0F0Z6bywmcdOFvqVcITPRDtRF5aSb4yQlMBbE3G eRDP5G7xAltOr9panRTbgRfJnhjMTj/z+2jVaJKa4OjQ1KtuY+t3WEpPPvfk829JQalW eJ6WaDCsyJ9mht0B2qjuZEMK93ebvsctMWziMJ/HP3XisxuUaMyueSwMsLhK2pXwYfSn zCpecH4H71yKvLNCXFWL8RCgybjfKVxBM4SA694lXo6eJHeg1XR2Gf1+ssA/hiCFxoQH wJ/g== X-Gm-Message-State: AOAM5336ZTrGhNZaYhibetHNG/cNxWuJMsqsbGAWLdkjMTlwVH7utUyU ThpH92pOAgRrNdMcM21cAmwJ7ezmigVwqA== X-Received: by 2002:a05:6000:18ad:: with SMTP id b13mr18066565wri.195.1637755071083; Wed, 24 Nov 2021 03:57:51 -0800 (PST) Received: from cerberus.fritz.box (dynamic-2k8il700l1ds6pdxmo-pd01.res.v6.highway.a1.net. [2001:871:25f:3765:7f:e933:b88e:7c80]) by smtp.gmail.com with ESMTPSA id d9sm14671466wre.52.2021.11.24.03.57.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Nov 2021 03:57:50 -0800 (PST) From: Werner Robitza To: ffmpeg-devel@ffmpeg.org Date: Wed, 24 Nov 2021 12:57:38 +0100 Message-Id: <20211124115738.84650-1-werner.robitza@gmail.com> X-Mailer: git-send-email 2.33.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] swscale: fix deprecation message for JPEG X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Werner Robitza Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: a4AmxlJncpcW This message frequently confuses end users, making them think that they are doing something wrong [1]. The fact that the "J" format itself is deprecated should not be bothering the end users. Since the format can only be changed when the handle_jpeg() function is called, this means we can tell the users about the fact that the JPEG conversion is causing this, and that they should check the range. [1]: https://superuser.com/q/1273920/48078 [2]: https://superuser.com/q/1663477/48078 Signed-off-by: Werner Robitza --- libswscale/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libswscale/utils.c b/libswscale/utils.c index c726922527..78f84d990a 100644 --- a/libswscale/utils.c +++ b/libswscale/utils.c @@ -1291,7 +1291,7 @@ av_cold int sws_init_context(SwsContext *c, SwsFilter *srcFilter, c->dstRange |= handle_jpeg(&c->dstFormat); if(srcFormat!=c->srcFormat || dstFormat!=c->dstFormat) - av_log(c, AV_LOG_WARNING, "deprecated pixel format used, make sure you did set range correctly\n"); + av_log(c, AV_LOG_WARNING, "pixel format was changed automatically for JPEG, make sure the color range is set correctly\n"); if (!c->contrast && !c->saturation && !c->dstFormatBpp) sws_setColorspaceDetails(c, ff_yuv2rgb_coeffs[SWS_CS_DEFAULT], c->srcRange,