From patchwork Thu Dec 2 13:11:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Guillem X-Patchwork-Id: 31880 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:cd86:0:0:0:0:0 with SMTP id d128csp69825iog; Thu, 2 Dec 2021 05:11:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJylawDRUhY7rEiNxXwlX47sB6UfBEHCCwxTDK9k9K7NS9M+xuXROpfJSLJXveaph/3l1zEH X-Received: by 2002:a05:6402:5208:: with SMTP id s8mr17452064edd.394.1638450715401; Thu, 02 Dec 2021 05:11:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1638450715; cv=none; d=google.com; s=arc-20160816; b=NmoJe3Aog9fAomXkE1TPuBxZbvpXwoFlHThbomo4uBEaP3Ak7xhn9sQ3X8/GDwFeht DzzyH8zp+SKbQHaGLSf93tjZp3Hv1Z4+LX1YsSLyR99e4h2n7rtltZiPW3HztrczY0QN bkin8oh+Ky/PHL28J31+0zRM8lu8563frBFO03ZEiqyiOT57w4P8uRy5w9+vZ1JfoxEe ayujNgfsMg3w4Y0ZrF9csNNB7s5Lpkv6YfONBhNltnrO1VsUxcubePzOqAyaNBr2C4tX onlRR+EvcGN4qtdH/efx0Fe+MCtuT9I8EN7qbHrM1krjJP4ymPa9VIQhd5JkOWDZlS99 RHBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :dkim-signature:dkim-signature:delivered-to; bh=Jm4egPDQrfcuMW8bdkeC6Zx2V3tqR0NRgBpG5ea/YO8=; b=s0X5lavEUtKTUFWmqghIZc461/2hD04WTy0r2JK1CVbmMHzcjtArw+SkMo6hwu+QsX CHvCQYqplKocgVdbgH/Qa8dBQsgRQdrpmslPXCYrxv1sdoCCsgA3QY2tSyJn61yVkiOw xGEY36Ed6Uxr7ijYlLCsnGxS4EWrLgrN/JuLx5KAldjvsSOmwnwjqYPbIMvRtBOXakHC hDCkSoIt8DOg5+M3jZ77Xvg+XuRRFnfS2XAJam2quqNg4oAjWDGB2IMo52yFztF4wX7X nzd6tTACfKXz5io5TxBFQ1SX9uQ/z2bwA+HL8OgwVTvoOkC0FrFwO9Ffmppom+kPPH6b PUdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gllm.fr header.s=fm1 header.b=qJC3jRkw; dkim=neutral (body hash did not verify) header.i=@messagingengine.com header.s=fm1 header.b=aZn3nbjQ; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gllm.fr Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id k12si4662901ejx.21.2021.12.02.05.11.54; Thu, 02 Dec 2021 05:11:55 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gllm.fr header.s=fm1 header.b=qJC3jRkw; dkim=neutral (body hash did not verify) header.i=@messagingengine.com header.s=fm1 header.b=aZn3nbjQ; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gllm.fr Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C253368A037; Thu, 2 Dec 2021 15:11:50 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 07F0E68AF5C for ; Thu, 2 Dec 2021 15:11:44 +0200 (EET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 0A67C3201CD3 for ; Thu, 2 Dec 2021 08:11:38 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 02 Dec 2021 08:11:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gllm.fr; h=from :to:subject:date:message-id:mime-version :content-transfer-encoding; s=fm1; bh=qow1uI4FwTaJkZtQJ/JaHn0vjw H5YPkb4Arfhmv824E=; b=qJC3jRkwPxPDRXgAy5WGdEHxgvYkVnBqVusa2unNPH 7OYDFXsC7PEUQYdLAOIYqDjv6dx+d3d6TIqAN8MXRRPSbjTMIVANwhLCkdemDppZ lm+kyfQQHAAIjuNMhrSx6LzYv3mx5Vb8Re0Nux/oucY29uh00huD35/+WWt4gsON ADyRkiA+AbK/3M2D7P/DrUaWeEqHuTmfQB3fuHzFdAQACXJR8gO1Opd1zWeNEEOv ahvNWPNLfkLPFSio7fvq3nUf5q8w29tabJSQFDWv8diP0o0fCmbDtPHtoGv8Lqi8 Y2fmEEF2W5lKeIiZUhB6vIH35MDPEXUjzcjIyw9xkhuA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=qow1uI4FwTaJkZtQJ /JaHn0vjwH5YPkb4Arfhmv824E=; b=aZn3nbjQO/scYXUqPOkM6maiUzMvA3aH5 FCI1Z5dxnnkoupiQ/J5CIQVjE7Qvrrp80OUTdWiGT2OwgR0eegwAKIdvDykG5BSZ 3ZGfkRhBow20H2uTEhAW/R/fiHMumm0Nn95jnH6QLvhN/cv4pAEVNGz6bMq5/M61 0BHfNDgx+rlWYwMuAvX246mZFjnsis3w9unNkpeV4HQzHM+pZtsroX5IhaUdnQGh zjvoe0kMzNUDOVjLaQv/HG/BSCnRdY+t6WLQxRqstylC/FNHMdWVM/82Bxj6XX+a pF/V6vdLzcaV6Ks4DSYLNcL4AzZRqsdCV1RDet3KqSBjqWPx1s4Jg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrieehgdeglecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffoggfgsedtkeertdertd dtnecuhfhrohhmpefvhhhomhgrshcuifhuihhllhgvmhcuoehthhhomhgrshesghhllhhm rdhfrheqnecuggftrfgrthhtvghrnhepgfdtlefgvedttdeludeftefgfeejheeghfdvve ffvefgtdevtdekjeeikeevgfejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepthhhohhmrghssehglhhlmhdrfhhr X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Thu, 2 Dec 2021 08:11:37 -0500 (EST) From: Thomas Guillem To: ffmpeg-devel@ffmpeg.org Date: Thu, 2 Dec 2021 14:11:36 +0100 Message-Id: <20211202131136.681702-1-thomas@gllm.fr> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avcodec/pthread_frame: fix hw_device_ctx leak X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: UXzY8Hsii4J4 Reproduced when using the VAAPI va module on VLC 4.0. No leaks when setting thread count to 1. --- libavcodec/pthread_frame.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c index 73b1b7d7d9..4c578aa44a 100644 --- a/libavcodec/pthread_frame.c +++ b/libavcodec/pthread_frame.c @@ -747,6 +747,7 @@ void ff_frame_thread_free(AVCodecContext *avctx, int thread_count) av_buffer_unref(&ctx->internal->pool); av_freep(&ctx->internal); av_buffer_unref(&ctx->hw_frames_ctx); + av_buffer_unref(&ctx->hw_device_ctx); } av_frame_free(&p->frame);