From patchwork Fri Dec 3 17:19:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 31916 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:cd86:0:0:0:0:0 with SMTP id d128csp955656iog; Fri, 3 Dec 2021 09:21:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJxG7vxuhdXzQJEI77jS6EavKO9Gy7auZPFo2ppgAOq0heQJ8bTbAuZ3RqhSBgUhE8i+34MT X-Received: by 2002:aa7:df9a:: with SMTP id b26mr27422394edy.107.1638552089444; Fri, 03 Dec 2021 09:21:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1638552089; cv=none; d=google.com; s=arc-20160816; b=0Dh66EzxA4BX0DGCc1DGtuUrMzfZNL1cMs9//aWXTGnt6lg0nYIrp8FGBfl0V0p0SP VOlqRclDcFYi2OKsDKE/WBzX41q0r532Vz70U2k4Y0Sl+hPP37rX6yThym+Vy9nSFSyF NOQ8sJnzs/On6d26SjvyLliRRPZ3/zyr2I29irGaWlaigupt1FSPL8eh76eaUjYUDnrL YxX9pus39KRIYAx79P8fC8KHiUzvdOK6P/h4n6KrJ8KQS0WrXnvzurC1Nkm4K2wvBkA8 OOIq2jZL02c7fW+JxDC4SAjBXm1n95teOcyFS9+GjfLszzmx5bhS5q0HLKXwZF32kumu KLjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:delivered-to; bh=Qkf4jYu5L0tAIgCeTvwQOA761cpJ55YYjMmakG6WVB0=; b=IRo13PrL+CuwkrJml0Dz4FAWWewM9ds9h0UbYceOhy/clHe0X1aIooVSjqrQT/98Lo oKuo70lQgMtapiT0DHngBe4Xeek9tFuyRuD5SPhtqzcgzTIdyi0nt59I/3Yoqm9cuu0w Ry7o1wF3tSphdC6iNMQJXSxCPhecn8z/QApd1EDjXOgfdJulFJQIb9maCkk8OIMG0ORo V3y16HvVMWmb4FGaPK8zuMkz4oPEhRJKE16eQOYhhsh2SzYRfF+jcQwNBj9EOLisQLLj ZrbUu+bIdhbUdIVUBBFbECsNYhk2jmKgFh8uC5cN8hhZgQc6Yx3xYKkGg48xO9HynN5A DZdw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id gt40si5479346ejc.310.2021.12.03.09.21.29; Fri, 03 Dec 2021 09:21:29 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5C13168AE46; Fri, 3 Dec 2021 19:21:07 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-dmta-pe02-1.mx.upcmail.net (vie01a-dmta-pe02-1.mx.upcmail.net [62.179.121.157]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C2B4368AAE6 for ; Fri, 3 Dec 2021 19:20:57 +0200 (EET) Received: from [172.31.216.235] (helo=vie01a-pemc-psmtp-pe12.mail.upcmail.net) by vie01a-dmta-pe02.mx.upcmail.net with esmtp (Exim 4.92) (envelope-from ) id 1mtCEz-00DNEn-0L for ffmpeg-devel@ffmpeg.org; Fri, 03 Dec 2021 18:20:57 +0100 Received: from localhost ([213.47.68.29]) by vie01a-pemc-psmtp-pe12.mail.upcmail.net with ESMTP id tCE1m7BjkSgGFtCE1mKblG; Fri, 03 Dec 2021 18:19:57 +0100 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 213.47.68.29 X-CNFS-Analysis: v=2.3 cv=f8Q2+96M c=1 sm=1 tr=0 a=2hcxjKEKjp0CzLx6oWAm4g==:117 a=2hcxjKEKjp0CzLx6oWAm4g==:17 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=ZZnuYtJkoWoA:10 a=NEAV23lmAAAA:8 a=v20YgqwhIr7Q-Qh6m88A:9 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Fri, 3 Dec 2021 18:19:55 +0100 Message-Id: <20211203171956.12231-3-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211203171956.12231-1-michael@niedermayer.cc> References: <20211203171956.12231-1-michael@niedermayer.cc> X-CMAE-Envelope: MS4wfLd6wMgCCOCghu0cFGwb4Qn3hHuNZoAWd8F2exKFbXdj4qKkTDwVOgeH9d8NWgvhv/rbMao0VkCpusG2LR8t78K1fjHK1yhJVd7IYGwj5VcpEp5YHt1A d+2ZbNPNMPAG1CySsK0LSI/kisjrRDus2hRfpRzitnLGItM8jAVy39XB Subject: [FFmpeg-devel] [PATCH 3/4] avcodec/alacdsp: fix integer overflow in decorrelate_stereo() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Abec65gdfsZO Fixes: signed integer overflow: -16777216 * 131 cannot be represented in type 'int' Fixes: 23835/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-5669943160078336 Fixes: 41101/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-4636330705944576 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/alacdsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/alacdsp.c b/libavcodec/alacdsp.c index 9996eb4319d..8718d1b6b1d 100644 --- a/libavcodec/alacdsp.c +++ b/libavcodec/alacdsp.c @@ -34,7 +34,7 @@ static void decorrelate_stereo(int32_t *buffer[2], int nb_samples, a = buffer[0][i]; b = buffer[1][i]; - a -= (b * decorr_left_weight) >> decorr_shift; + a -= (int)(b * (unsigned)decorr_left_weight) >> decorr_shift; b += a; buffer[0][i] = b;