| Message ID | 20211214040806.178814-1-ullysses.a.eoff@intel.com |
|---|---|
| State | Accepted |
| Commit | cde2efb5dac2358c919229015d18629ca739b602 |
| Headers | show |
| Series | [FFmpeg-devel] MAINTAINERS: Add Haihao Xiang for vaapi | expand |
| Context | Check | Description |
|---|---|---|
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
| andriy/make_ppc | success | Make finished |
| andriy/make_fate_ppc | success | Make fate finished |
> -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of U. Artie > Eoff > Sent: Tuesday, December 14, 2021 5:08 AM > To: ffmpeg-devel@ffmpeg.org > Cc: U. Artie Eoff <ullysses.a.eoff@intel.com> > Subject: [FFmpeg-devel] [PATCH] MAINTAINERS: Add Haihao Xiang for vaapi > > Current listed maintainers for vaapi plugin are > not reponsive and/or currently active in the > ffmpeg community. Thus, vaapi plugin patches > (and qsv plugin) have generally gone ignored or > lost in the ether for too long. > > Remove Gwenole Beauchesne from vaapi maintainer > who has not been active since 2016. > > Current alternative maintainer for vaapi is Mark > Thompson whom has not been active since > March/April 2021. > > Therefore, add Haihao Xiang to vaapi maintainer > who's primary role is FFmpeg development with a > focus on the vaapi and qsv plugins. Haihao has > over a decade of media experience and many years > of FFmpeg development experience, amongst other > media frameworks. > > The additional patch for adding Haihao as qsv > plugin maintainer has been submitted previously: > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210608141134.27448-1- > zhongli_dev@126.com/ > > This will help FFmpeg to continue to be the leading > multimedia framework by allowing these plugins to be > actively improved, enhanced, and maintained for existing > and future HW platforms. > > Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com> > --- > MAINTAINERS | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index dcac46003ecd..fddf065a3abb 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -274,8 +274,8 @@ Hardware acceleration: > dxva2* Hendrik Leppkes, Laurent Aimar, > Steve Lhomme > d3d11va* Steve Lhomme > mediacodec* Matthieu Bouron, Aman Gupta > - vaapi* Gwenole Beauchesne > - vaapi_encode* Mark Thompson > + vaapi* Haihao Xiang > + vaapi_encode* Mark Thompson, Haihao Xiang > vdpau* Philip Langdale, Carl Eugen Hoyos > videotoolbox* Rick Kern, Aman Gupta > > -- Whatever it might count: This has my support. Haihao is the most suitable candidate from all who I've been working with on QSV issues (on and off-list) in the past two years. The current situation is far from ideal. In other areas, commits are pushed timely and frequently, while there's hardly any progress made in the Intel area, despite the amount of developer resources they are providing. Even the most trivial and straightforward patches are lying around for months without action. It really shouldn't be like that. @Artie - you might want to update the patch and also add him for QSV. Kind regards, softworkz
On Tue, 14 Dec 2021 16:39:40 +0000 "Eoff, Ullysses A" <ullysses.a.eoff@intel.com> wrote: > I have not seen any objections. > I just added Mark to CC using their email found on this ML. > Unfortunately, we don't have current email contact for > Gwenole (whom has not worked on ffmpeg for ~6 years). > Who else can make the approval, aside from the inactive people > previously listed? Are people reluctant to approve? I'll give it my approval to have on the record. If the old maintainers want to emerge from the woodwork and object after the fact, they are welcome to do so, but we can't just sit around indefinitely. The contributions here are clear, and I can't see either of them objecting, given my past interactions. --phil
On Tue, Dec 14, 2021 at 12:16:16PM -0800, Philip Langdale wrote: > On Tue, 14 Dec 2021 16:39:40 +0000 > "Eoff, Ullysses A" <ullysses.a.eoff@intel.com> wrote: > > > I have not seen any objections. > > I just added Mark to CC using their email found on this ML. > > Unfortunately, we don't have current email contact for > > Gwenole (whom has not worked on ffmpeg for ~6 years). > > Who else can make the approval, aside from the inactive people > > previously listed? > > Are people reluctant to approve? I dont think so, iam just extra carefull as someone on IRC noticed that "everyone and their grandmother who's worked for intel's got push access" There where also some complaints about code quality/cleanlyness toward intels contributions So i just wanted to make sure there are no objections (iam not conciously aware of any objections to these MAINTAINER additions ATM) > I'll give it my approval to have on > the record. If the old maintainers want to emerge from the woodwork and > object after the fact, they are welcome to do so, but we can't just sit > around indefinitely. The contributions here are clear, and I can't see > either of them objecting, given my past interactions. I suggest you apply these if noone raises any objections in the next 2-3 days, in fact people had a really long time already ... thx [...]
> -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Michael > Niedermayer > Sent: Tuesday, December 14, 2021 10:40 PM > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] MAINTAINERS: Add Haihao Xiang for vaapi > > On Tue, Dec 14, 2021 at 12:16:16PM -0800, Philip Langdale wrote: > > On Tue, 14 Dec 2021 16:39:40 +0000 > > "Eoff, Ullysses A" <ullysses.a.eoff@intel.com> wrote: > > > > > I have not seen any objections. > > > I just added Mark to CC using their email found on this ML. > > > Unfortunately, we don't have current email contact for > > > Gwenole (whom has not worked on ffmpeg for ~6 years). > > > Who else can make the approval, aside from the inactive people > > > previously listed? > > > > Are people reluctant to approve? > > I dont think so, iam just extra carefull as someone on IRC noticed that > "everyone and their grandmother who's worked for intel's got push access" > > There where also some complaints about code quality/cleanlyness > toward intels contributions That's true. There are differences, and my expressed support is specifically tied to the person, not about having just "somebody". I have my reservations about too early adoption of oneVPL and I think the patchset "Cleanup QSV Filters.." is doing too many things at once, but well - being a maintainer still doesn't mean that one could merge anything without consent. But the current situation, like having two or three people working full-time on the subject being depending on somebody who isn't following progress and unable assess, evaluate and test proposed changes is quite awkward. > So i just wanted to make sure there are no objections (iam not conciously > aware of any objections to these MAINTAINER additions ATM) > > > > I'll give it my approval to have on > > the record. If the old maintainers want to emerge from the woodwork and > > object after the fact, they are welcome to do so, but we can't just sit > > around indefinitely. I'm actually wondering, whether registered maintainers that do not respond anymore to contributions for a certain amount of time, shouldn't be unregistered automatically at some point? Kind regards, softworkz
> -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > Michael Niedermayer > Sent: Wednesday, December 15, 2021 5:40 AM > To: FFmpeg development discussions and patches <ffmpeg- > devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] MAINTAINERS: Add Haihao Xiang for > vaapi > > On Tue, Dec 14, 2021 at 12:16:16PM -0800, Philip Langdale wrote: > > On Tue, 14 Dec 2021 16:39:40 +0000 > > "Eoff, Ullysses A" <ullysses.a.eoff@intel.com> wrote: > > > > > I have not seen any objections. > > > I just added Mark to CC using their email found on this ML. > > > Unfortunately, we don't have current email contact for Gwenole (whom > > > has not worked on ffmpeg for ~6 years). > > > Who else can make the approval, aside from the inactive people > > > previously listed? > > > > Are people reluctant to approve? > > I dont think so, iam just extra carefull as someone on IRC noticed that > "everyone and their grandmother who's worked for intel's got push access" Lynne may have misunderstanding, as I know, the author he mentioned in IRC is not from Intel. > > There where also some complaints about code quality/cleanlyness toward > intels contributions So i just wanted to make sure there are no objections > (iam not conciously aware of any objections to these MAINTAINER additions > ATM) We care about the code quality, every patch sent to upstream will pass our internal review and ci test firstly. We defined an upstream process here https://github.com/intel-media-ci/cartwheel-ffmpeg#upstream-process. If we missed something in the internal review, please give review comments during the public review. We will try our best to fix all issues. Push code only when it's no objections. We know the current code quality is not so good. This is why we send many patches to improve it. But most of the patches are not merged since original maintainers are not so active. Having an active maintainer will help this. Haihao is a good candidate for the vaapi/qsv maintainer. He is the libva api maintainer for 10+ years. He will review and monitor all patches related to Intel. Hope this will address your code quality concerns. > > > > I'll give it my approval to have on > > the record. If the old maintainers want to emerge from the woodwork and > > object after the fact, they are welcome to do so, but we can't just sit > > around indefinitely. The contributions here are clear, and I can't see > > either of them objecting, given my past interactions. > > I suggest you apply these if noone raises any objections in the next > 2-3 days, in fact people had a really long time already ... Thank you Michael, Philip, Softworkz, U.Arite, and all help on this. > > thx > > [...] > -- > Michael GnuPG fingerprint: > 9FF2128B147EF6730BADF133611EC787040B0FAB > > Freedom in capitalist society always remains about the same as it was in > ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
On Tue, Dec 14, 2021 at 10:31:40PM +0000, Soft Works wrote: > > > > -----Original Message----- > > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Michael > > Niedermayer > > Sent: Tuesday, December 14, 2021 10:40 PM > > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH] MAINTAINERS: Add Haihao Xiang for vaapi > > > > On Tue, Dec 14, 2021 at 12:16:16PM -0800, Philip Langdale wrote: > > > On Tue, 14 Dec 2021 16:39:40 +0000 > > > "Eoff, Ullysses A" <ullysses.a.eoff@intel.com> wrote: > > > > > > > I have not seen any objections. > > > > I just added Mark to CC using their email found on this ML. > > > > Unfortunately, we don't have current email contact for > > > > Gwenole (whom has not worked on ffmpeg for ~6 years). > > > > Who else can make the approval, aside from the inactive people > > > > previously listed? > > > > > > Are people reluctant to approve? > > > > I dont think so, iam just extra carefull as someone on IRC noticed that > > "everyone and their grandmother who's worked for intel's got push access" > > > > There where also some complaints about code quality/cleanlyness > > toward intels contributions > > That's true. There are differences, and my expressed support is > specifically tied to the person, not about having just "somebody". > > I have my reservations about too early adoption of oneVPL and I think > the patchset "Cleanup QSV Filters.." is doing too many things at once, > but well - being a maintainer still doesn't mean that one could merge > anything without consent. > > But the current situation, like having two or three people working full-time > on the subject being depending on somebody who isn't following progress > and unable assess, evaluate and test proposed changes is quite awkward. yes > > > So i just wanted to make sure there are no objections (iam not conciously > > aware of any objections to these MAINTAINER additions ATM) > > > > > > > I'll give it my approval to have on > > > the record. If the old maintainers want to emerge from the woodwork and > > > object after the fact, they are welcome to do so, but we can't just sit > > > around indefinitely. > > I'm actually wondering, whether registered maintainers that do not > respond anymore to contributions for a certain amount of time, > shouldn't be unregistered automatically at some point? If they never react they should be removed when a new volunteer is added. they should be informed about that when possible though. Also when there is noone else, then listing the last maintainer even if (s)he is mostly inactive still can make sense as it gives at least some point of contact thx [...]
On Wed, 2021-12-15 at 15:32 +0100, Michael Niedermayer wrote: > On Tue, Dec 14, 2021 at 10:31:40PM +0000, Soft Works wrote: > > > > > > > -----Original Message----- > > > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Michael > > > Niedermayer > > > Sent: Tuesday, December 14, 2021 10:40 PM > > > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> > > > Subject: Re: [FFmpeg-devel] [PATCH] MAINTAINERS: Add Haihao Xiang for > > > vaapi > > > > > > On Tue, Dec 14, 2021 at 12:16:16PM -0800, Philip Langdale wrote: > > > > On Tue, 14 Dec 2021 16:39:40 +0000 > > > > "Eoff, Ullysses A" <ullysses.a.eoff@intel.com> wrote: > > > > > > > > > I have not seen any objections. > > > > > I just added Mark to CC using their email found on this ML. > > > > > Unfortunately, we don't have current email contact for > > > > > Gwenole (whom has not worked on ffmpeg for ~6 years). > > > > > Who else can make the approval, aside from the inactive people > > > > > previously listed? > > > > > > > > Are people reluctant to approve? > > > > > > I dont think so, iam just extra carefull as someone on IRC noticed that > > > "everyone and their grandmother who's worked for intel's got push access" > > > > > > There where also some complaints about code quality/cleanlyness > > > toward intels contributions > > > > That's true. There are differences, and my expressed support is > > specifically tied to the person, not about having just "somebody". > > > > I have my reservations about too early adoption of oneVPL and I think > > the patchset "Cleanup QSV Filters.." is doing too many things at once, > > but well - being a maintainer still doesn't mean that one could merge > > anything without consent. > > > > But the current situation, like having two or three people working full-time > > on the subject being depending on somebody who isn't following progress > > and unable assess, evaluate and test proposed changes is quite awkward. > > yes > > > > > > > So i just wanted to make sure there are no objections (iam not conciously > > > aware of any objections to these MAINTAINER additions ATM) > > > > > > > > > > I'll give it my approval to have on > > > > the record. If the old maintainers want to emerge from the woodwork and > > > > object after the fact, they are welcome to do so, but we can't just sit > > > > around indefinitely. > > > > I'm actually wondering, whether registered maintainers that do not > > respond anymore to contributions for a certain amount of time, > > shouldn't be unregistered automatically at some point? > > If they never react they should be removed when a new volunteer is added. > they should be informed about that when possible though. > Also when there is noone else, then listing the last maintainer even if > (s)he is mostly inactive still can make sense as it gives at least some point > of contact Thanks all of you for your kink support. I'm glad to maintain vaapi plugin, will offer efforts to improve / enhance vaapi plugins and make it more useful to vaapi user. I'd appreciate it if someone could make the approval and apply this patch. Thanks Haihao
On Mon, 20 Dec 2021 07:36:02 +0000 "Xiang, Haihao" <haihao.xiang@intel.com> wrote: > Thanks all of you for your kink support. I'm glad to maintain vaapi > plugin, will offer efforts to improve / enhance vaapi plugins and > make it more useful to vaapi user. I'd appreciate it if someone could > make the approval and apply this patch. > Applied. --phil
diff --git a/MAINTAINERS b/MAINTAINERS index dcac46003ecd..fddf065a3abb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -274,8 +274,8 @@ Hardware acceleration: dxva2* Hendrik Leppkes, Laurent Aimar, Steve Lhomme d3d11va* Steve Lhomme mediacodec* Matthieu Bouron, Aman Gupta - vaapi* Gwenole Beauchesne - vaapi_encode* Mark Thompson + vaapi* Haihao Xiang + vaapi_encode* Mark Thompson, Haihao Xiang vdpau* Philip Langdale, Carl Eugen Hoyos videotoolbox* Rick Kern, Aman Gupta
Current listed maintainers for vaapi plugin are not reponsive and/or currently active in the ffmpeg community. Thus, vaapi plugin patches (and qsv plugin) have generally gone ignored or lost in the ether for too long. Remove Gwenole Beauchesne from vaapi maintainer who has not been active since 2016. Current alternative maintainer for vaapi is Mark Thompson whom has not been active since March/April 2021. Therefore, add Haihao Xiang to vaapi maintainer who's primary role is FFmpeg development with a focus on the vaapi and qsv plugins. Haihao has over a decade of media experience and many years of FFmpeg development experience, amongst other media frameworks. The additional patch for adding Haihao as qsv plugin maintainer has been submitted previously: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210608141134.27448-1-zhongli_dev@126.com/ This will help FFmpeg to continue to be the leading multimedia framework by allowing these plugins to be actively improved, enhanced, and maintained for existing and future HW platforms. Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com> --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)