From patchwork Sun Dec 19 19:21:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Diederick C. Niehorster" X-Patchwork-Id: 32731 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:cd86:0:0:0:0:0 with SMTP id d128csp3695603iog; Sun, 19 Dec 2021 11:23:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJzsSImc4rx1WwjFM80+SA3R98yepkKIzg8PjW6w2CsnMgZvs3AxwGcg8d6gaNAnzZwYxrWf X-Received: by 2002:a05:6402:b41:: with SMTP id bx1mr8276085edb.292.1639941785183; Sun, 19 Dec 2021 11:23:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1639941785; cv=none; d=google.com; s=arc-20160816; b=1DVlbG25dyIyntw3rVCnsJ1uKZzfARR1nz82ed4ZkC3l7SgJ2wB0Sp1tp+rxd4gGD/ tcP1z+5nI3BC7CWFvkahoNIMmwzMmlcLhokmkB7Mqm7HAqBpOruXuzPSbk3cP4syFUjq dpINmisXaiKxiFRHm6lU+CYduGosaNaqGVPC0hNOTi1hSA0WffN/ZYKUFnWo6S1j0Yn3 H7D4SKfjTuP9wxv/BblwUw1GnYfs5kb3mUSw3Pq7lY+X6ijcd7vh8kB/FoURQtryZqII PJQdLYthC/pRJ2oCAF7U/KflVNXXlRArGUM9eWVNJ1eG7A91CTurBgQP0klXmNNGQiRp 3qMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to; bh=3j0QrtQQHAeI1Zzn+f4NBkwbXDFahor9ccyTUmhV678=; b=wZlVTfAAKq+ZBUIPGLKWT+27ySpUJb6zSZK5PvIQlXPjPi9h3uc5ODUNQ/mJGXrWLt YG1yMw7hmleTvzJGTLoPvs9MgTUQw5Ej+mDHaZ52H/QW3l4RQUKLpfINIa+RkKgaeL2p fp7WpAuhzwmT89/YxapF2FPdSoQ0SB14nGvsakFWRfILYz/oOU7e6fA+2K2h3UC50d4Z rJbXdHPaZXIjguy134mlvol6VFfgDXmdJnW3nilRKfPX2zX6i/fSwPnR1ZDSX9L9kZWu gGe14mQ2CWaCzrMO6SfahmLAOcoO/uWDtDHgeqMsez0ACVKxua9BotG6vJbtYACzLcY2 ufog== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=AOeYmYrF; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id nb21si1369734ejc.723.2021.12.19.11.23.04; Sun, 19 Dec 2021 11:23:05 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=AOeYmYrF; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EFE9568AF90; Sun, 19 Dec 2021 21:22:33 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B558768AF55 for ; Sun, 19 Dec 2021 21:22:32 +0200 (EET) Received: by mail-lf1-f52.google.com with SMTP id b22so16914904lfb.9 for ; Sun, 19 Dec 2021 11:22:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PRQUajDDzo0yckQUc1NGOreX/fguC3LwegFuv42BzkQ=; b=AOeYmYrFAR3CDrLyijiWZ1iKBc4Bw+f/Ur6ajJRnW2Gqv8RGHi1owYjZO9fNWaICXt mS0PAHchqsAxqmq8JgYjQrfTTarDf3CQVjDR3Gj3ljbWCYtKEoJuy8IYwugw3JrfrEF2 lMFv6QVi+4cUwjb8pb4EOaugvro8gLfEIF8025MCF8Ts9/5DIzF7K2C3hyU67RxowUPF xDrmk+kl+RtrC3EHHE76Xju+U185kyOFcuVLfdXhKOYB1aD9pRkxeMssole79+1Ysy0E 5WK6E+TLMSWez8kTvApFG132GoYsgVZBikSesr5QXEfcn8P81O2/NGa4amxGHgTaiGVH 7erQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PRQUajDDzo0yckQUc1NGOreX/fguC3LwegFuv42BzkQ=; b=YvHTXo12JXMeTrqevcD+O4ARcUG7yAtVzxo7PWHsRLOl93cXY+VIHWL0YtTAa8fLLI We0gO0f8loZFNi8r8aCDs9kYDAk3YPbiiK/ucHOfZuOskoPFMQIhOCwu5gqxhYxDwhCX G9LNxjU/pcJxeaxoUDSPIiJcnLKTr586iz8VIQrGe6VPtrKB++3Tpdq5ef7UOQJ13hTm pF8sjOU7UN441WsH6+bR1pfQgs0zQi5I0O67+89VZ7X0UxIgVgc590MiN5IRg05UonJd jn7lMCPImhTEwDVmKW+FcZM8sdJeFxITKf13CrXOJ7G0JGZbFutpZE1zBgJK9EnmWG6U s+oQ== X-Gm-Message-State: AOAM533E5xNfloSHZKsRbCDck7f94pnt9NvmbMOT3nsDTaIUwYr3w3ro 5Er2vlZdKT/ZanLvkgJT78RYaCoMC2lUs5eT X-Received: by 2002:a05:6512:210f:: with SMTP id q15mr4607937lfr.112.1639941751788; Sun, 19 Dec 2021 11:22:31 -0800 (PST) Received: from localhost.localdomain (84-217-56-54.customers.ownit.se. [84.217.56.54]) by smtp.gmail.com with ESMTPSA id a17sm2326693ljq.72.2021.12.19.11.22.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Dec 2021 11:22:31 -0800 (PST) From: Diederick Niehorster To: ffmpeg-devel@ffmpeg.org Date: Sun, 19 Dec 2021 20:21:27 +0100 Message-Id: <20211219192134.1296-7-dcnieho@gmail.com> X-Mailer: git-send-email 2.28.0.windows.1 In-Reply-To: <20211219192134.1296-1-dcnieho@gmail.com> References: <20211219192134.1296-1-dcnieho@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v5 06/13] avdevice/dshow: set no-seek flags X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Diederick Niehorster Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 0gAsQMPbIv3P avdevice/dshow is a realtime device and as such does not support seeking. Therefore, its demuxer format should define the AVFMT_NOBINSEARCH, AVFMT_NOGENSEARCH and AVFMT_NO_BYTE_SEEK flags. With these flags set, attempting to seek (with, e.g., avformat_seek_file()) correctly yields -1 (operation not permitted) instead of -22 (invalid argument). This actually seems to apply to many other devices, at least the gdigrab, v4l2, vfwcap, x11grab, fbdev, kmsgrab and android_camera devices, from reading the source. Signed-off-by: Diederick Niehorster --- libavdevice/dshow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c index 5e6eb9c85d..0ef3b3d13e 100644 --- a/libavdevice/dshow.c +++ b/libavdevice/dshow.c @@ -1329,6 +1329,6 @@ const AVInputFormat ff_dshow_demuxer = { .read_header = dshow_read_header, .read_packet = dshow_read_packet, .read_close = dshow_read_close, - .flags = AVFMT_NOFILE, + .flags = AVFMT_NOFILE | AVFMT_NOBINSEARCH | AVFMT_NOGENSEARCH | AVFMT_NO_BYTE_SEEK, .priv_class = &dshow_class, };