From patchwork Thu Dec 30 06:11:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "zozobreak@163.com" X-Patchwork-Id: 32946 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:cd86:0:0:0:0:0 with SMTP id d128csp12801683iog; Wed, 29 Dec 2021 22:12:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJz2ugfCe3jNvvsrrtOlWRpamfSscJNr8qDiW/9G34DOfeP/FgKcgmGBmoRvL1VRjol2UYk3 X-Received: by 2002:a05:6402:1012:: with SMTP id c18mr28984075edu.67.1640844723703; Wed, 29 Dec 2021 22:12:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1640844723; cv=none; d=google.com; s=arc-20160816; b=Wk/LD1PHfcN3WqkgtH3tnkDGQQq9HLrUvyfmkGOmDAPDdFIomBJ6fTPRjYbpoPnJVZ s8Nizf89BZZSx/uPICo6hDvXFaaOAPDWoziAP+9thcn6JkbPAkkU639PnCQz7aeL6n0W KMLPV/IbigaeNHibIApXlpPAw9xgYoEfuhO9pUYSEXEg3mRsWKqubeI4pycWvD9nTGZw 9VaPoc3DfcEWNw12l8w6i2Z3tpNsgs+33mJQI8Ro28Mq7ojeqM3NAR1wEOWyqAcbIzXu JGFESRJQwfyTb9YlzkH/6Lk0rh5wiFXwvA9Ht0tEMdzgtYwOE6PrycS4UGuKDblJdrl5 nqGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=5uKQxyQCVy5wPOCoIipuxQ54xGXXhr24x2QBiDTKfS4=; b=mtcEOgU4gpxORQl32KOK0F1NKlp8E0Ld0+qDFsbSqWA7ts/ji+RaO8uX6HYSVkU+3b p7qIjtjB++gAScCsm4jHWTraVt3rAR3IfdcKaTmATNkDVRnNCMrVNT2n57buC+VJGgOA RKfxpZbdZbNB/KrNezANxz8WtDatOrz7Jkahs+AGk7lg2cobzLzPIpPvQE7I7WykcP8Z xYg7M8BROI2AGkSREt3krU1/numnZgNlI4r3+g3V6x9cA6J0KH229yrH7lcidIySKZ8d 25VYIrIvRoXY7tY7CNS6tP9V3r8xzRWXZkZAra1JR43Gk/EV7o27nn0QDFX657+PFscv J2CQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@163.com header.s=s110527 header.b=MfZPtY+g; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=163.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id gq22si11339925ejb.716.2021.12.29.22.12.02; Wed, 29 Dec 2021 22:12:03 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@163.com header.s=s110527 header.b=MfZPtY+g; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C558068A466; Thu, 30 Dec 2021 08:11:59 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-m974.mail.163.com (mail-m974.mail.163.com [123.126.97.4]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0F27568A306 for ; Thu, 30 Dec 2021 08:11:51 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=kiqWL FsV5TY0s7XiZEKULrcSgdbeEoJiTZIVcnEdEfA=; b=MfZPtY+g/ZaVmQvz4PhpC CqvcZIHi8vhyO+tX4Td2gYmUi9odDtjt0i+3fU0E+N/pLMQ0mBSiwHOTb+zViTnM /+kXNMUW4tmA51865ABrH5GAqvp+9ULJGutDdd/djco5v7gVOGeCg9N4V2oHWUze pKSjNkA7b0hThVqrIeY47w= Received: from wuque-pc2.dev-wh.douyu.tv (unknown [220.249.79.114]) by smtp4 (Coremail) with SMTP id HNxpCgBXDSajTc1hpiGkDQ--.1041S2; Thu, 30 Dec 2021 14:11:48 +0800 (CST) From: zourenyi To: ffmpeg-devel@ffmpeg.org Date: Thu, 30 Dec 2021 14:11:45 +0800 Message-Id: <20211230061145.20864-1-zozobreak@163.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CM-TRANSID: HNxpCgBXDSajTc1hpiGkDQ--.1041S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7XFWUAw1DWFy3CF45CryfWFg_yoWDtrb_Ca yxCr13GF4DGay2k3WfWr4YyF97uan8C3W3uas7tws0gFZxGr1UGFykXF98Cr15W3Z7GFW3 KF4Fvr1vkw4xKjkaLaAFLSUrUUUU1b8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRAvtZ3UUUUU== X-Originating-IP: [220.249.79.114] X-CM-SenderInfo: p2r20upuhdyqqrwthudrp/xtbBlwR5w1SIlrbIogAAs- Subject: [FFmpeg-devel] [PATCH v5] avcodec/libx264: add warning log when droping picture at 'h264_select_output_frame' X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: zourenyi Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: vqWLYndYb/dv since there is only debug log 'no picture ooo' when droping a picture, I spent much time to troubleshooting a wrong sps 'num_reorder_frames' param changed by webrtc's 'ParseAndRewriteSps', FFmpeg keeped silence about this error, so a warning log is much helpfull about this. Signed-off-by: zourenyi --- libavcodec/h264_slice.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c index c21004df97..f347d8ee1a 100644 --- a/libavcodec/h264_slice.c +++ b/libavcodec/h264_slice.c @@ -1533,7 +1533,13 @@ static int h264_select_output_frame(H264Context *h) } } } else { - av_log(h->avctx, AV_LOG_DEBUG, "no picture %s\n", out_of_order ? "ooo" : ""); + if (out_of_order) { + av_log(h->avctx, AV_LOG_WARNING, + "drop picture(%c, %d/%" PRId64 ") because out of order\n", + av_get_picture_type_char(out->f->pict_type), out->poc, out->f->pts); + } else { + av_log(h->avctx, AV_LOG_DEBUG, "no picture\n"); + } } return 0;