From patchwork Fri Dec 31 10:53:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Khirnov X-Patchwork-Id: 32961 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:cd86:0:0:0:0:0 with SMTP id d128csp13864798iog; Fri, 31 Dec 2021 02:54:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJwSFuhGJ5uDnE54vVjFYYqJ98LuedVSPn2THh5FFr/cuIWvFVb6tCzTO6W/5Whb1Hsiam7t X-Received: by 2002:a17:907:6d08:: with SMTP id sa8mr27105118ejc.28.1640948073563; Fri, 31 Dec 2021 02:54:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1640948073; cv=none; d=google.com; s=arc-20160816; b=gBhDKC3VqjJkgYh4EJ+xYE99c6AO7WihLROqiVSIbzhfszggiIGwKcmCL/QF+8tJ+w 8YsmesJw9UgA/qstpdGytSM72RZ07dLs3jz9p8StZSrZYknHN/DnoainKiy+uUFsf+IZ 3nv7ZFC7q61BBppOt02tZjde0+YMHzalhUeFigFnfU+7Jg9rUSn6cirVdLMNJvvt29hV vY5blPXCMam+/Tk2kGHHTWmzgxuV4ekPEZAInggs8E0ESFLMgSBjQBBlFmIdqA3YEHlK H2hegUjWyewrNRw7k8woJLbXXvDdXdD2FHREJChcK0oZ6MSEJobt41bF+4+0aaERhTRR 4EOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:delivered-to; bh=+nQSqQAPRRQJrDChtFcoBtoxUgw/mXpjrczxLsB9mEU=; b=VwFRvsR5CshOy3XAhUFKy+InOFkKC+2e0KS6QTsmtQ/Rs0xZ6xq4uf20059m8UjH6y 2oCkgh1nbSNSFONjnQUy/YdP+j5DOU/ecoGWL/tMpHYhhPMSxDlJH4YKA7QsDKg3QuTt LJlFqgVISraFkbSbUbH7cLT3pTjtQcIfkileFVUMltZyS8nPudrKDe1iVRn2Zn99rDTY NuRi+8JQLRrFvxrVdE7H1WGx7TmHo58StGthZZ4FvnG1fSFNvrdnSyr29xuZEsnGT/kX j4tkDimFkGMy7oDUAKwl6GXByr6NKV1nntXOdJol7kYOe7mnvkMe9DC38RETo37CRXMT 7LDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id z20si14545404edi.289.2021.12.31.02.54.33; Fri, 31 Dec 2021 02:54:33 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D432168AFF8; Fri, 31 Dec 2021 12:53:35 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2144168AF88 for ; Fri, 31 Dec 2021 12:53:27 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 7B6D824050B for ; Fri, 31 Dec 2021 11:53:23 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id aDGc4DjG5dGR for ; Fri, 31 Dec 2021 11:53:22 +0100 (CET) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:2a00:c500:561:201::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "libav.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id AD6B3240507 for ; Fri, 31 Dec 2021 11:53:19 +0100 (CET) Received: by libav.khirnov.net (Postfix, from userid 1000) id AA7C83A0769; Fri, 31 Dec 2021 11:53:19 +0100 (CET) From: Anton Khirnov To: ffmpeg-devel@ffmpeg.org Date: Fri, 31 Dec 2021 11:53:06 +0100 Message-Id: <20211231105307.30946-6-anton@khirnov.net> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211231105307.30946-1-anton@khirnov.net> References: <20211231105307.30946-1-anton@khirnov.net> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 6/7] lavu/fifo: drop useless comments X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: cTK7DHFhUINl This object was never intended to be thread-safe, so these carry no useful information. --- libavutil/fifo.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/libavutil/fifo.c b/libavutil/fifo.c index 171c1aa9cd..f38e8ff089 100644 --- a/libavutil/fifo.c +++ b/libavutil/fifo.c @@ -144,7 +144,6 @@ int av_fifo_generic_write(AVFifoBuffer *f, void *src, int size, memcpy(wptr, src, len); src = (uint8_t *)src + len; } -// Write memory barrier needed for SMP here in theory wptr += len; if (wptr >= f->end) wptr = f->buffer; @@ -197,7 +196,6 @@ int av_fifo_generic_peek_at(AVFifoBuffer *f, void *dest, int offset, int buf_siz int av_fifo_generic_peek(AVFifoBuffer *f, void *dest, int buf_size, void (*func)(void *, void *, int)) { -// Read memory barrier needed for SMP here in theory uint8_t *rptr = f->rptr; do { @@ -208,7 +206,6 @@ int av_fifo_generic_peek(AVFifoBuffer *f, void *dest, int buf_size, memcpy(dest, rptr, len); dest = (uint8_t *)dest + len; } -// memory barrier needed for SMP here in theory rptr += len; if (rptr >= f->end) rptr -= f->end - f->buffer; @@ -221,7 +218,6 @@ int av_fifo_generic_peek(AVFifoBuffer *f, void *dest, int buf_size, int av_fifo_generic_read(AVFifoBuffer *f, void *dest, int buf_size, void (*func)(void *, void *, int)) { -// Read memory barrier needed for SMP here in theory do { int len = FFMIN(f->end - f->rptr, buf_size); if (func) @@ -230,7 +226,6 @@ int av_fifo_generic_read(AVFifoBuffer *f, void *dest, int buf_size, memcpy(dest, f->rptr, len); dest = (uint8_t *)dest + len; } -// memory barrier needed for SMP here in theory av_fifo_drain(f, len); buf_size -= len; } while (buf_size > 0);