From patchwork Sun Jan 2 14:51:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Wu, Jianhua" X-Patchwork-Id: 33011 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:cd86:0:0:0:0:0 with SMTP id d128csp15455921iog; Sun, 2 Jan 2022 06:52:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJyvrRcsS9DYU+jC/s88wtbEbTV67nFvIgFGU3iAbL3kRC9xOvXCWITgD1cCvMSjTIMUCCST X-Received: by 2002:a05:6402:2747:: with SMTP id z7mr41311659edd.124.1641135133426; Sun, 02 Jan 2022 06:52:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1641135133; cv=none; d=google.com; s=arc-20160816; b=0Mv4fWnRlXLjWKyPGBpNlhP6EIiu9HIwhQfwAxubKdWKYJzH906hcKQ0vPGxuJGF9a AZWsu+3GVF74fWuJhtkYsiUeY/zfvN6Kw788FOwTR724CG4rbvlDZz3dAwY8IJMYHNWz AG6h86QCqRZB3HRYLEM4+5Yjw4jg2GSc/AWD4CeJ5LPTjKfslujk4ukDwKopWJrUTFop PCM1p+OzImqvOPSf6n0wMFK+ai5bI7umCtwEdGlzhP3M6rP7AA7J5e9nQfDEkD7W4IJD lSgHEtWXv6WYu6bLBmjvJ2Ek52oBmbjGb1OUA76qcWg5jwEPNPsQoy9jHkSTK4lcXnum VA6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=RfeGPbDGZducksrpKRpStKTQodJ5KGDKPqnqTh5yGI8=; b=kWBPmYurSXrHXI9ynMkiweGTSgyI1L/4BxhJnh4vGaq/QA0U52j1pUjl1FbxGNvWbB A+vBIzrmk9hE0b5jfneYwFwyhjan/bW3xPm4md1nYgjvKvXPEnPDIdr/OiyvYQ6whZLZ aV8tGXlSCFzwo2V/oy7+Kjrmuo0X1JdOa0SZqyBuwDwDiTmsvVbxAWlGd8mjIcmA6vs6 L7W8dzjfVtWVqTPhdOQ2wAatVkpuvDTTON8xlF7rQohUr1Gm+Bl5aySm/nMPZRN13uFb GlEN8uDDVXRo7vL712RBL/UfYNHnoLMA+EQxiVgyL7k12501rYME/82qJuHNPYbHhGKO XJWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=j3ywziRD; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id qf36si17989663ejc.638.2022.01.02.06.52.13; Sun, 02 Jan 2022 06:52:13 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=j3ywziRD; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C819468B15E; Sun, 2 Jan 2022 16:52:10 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AF2AC6807A1 for ; Sun, 2 Jan 2022 16:52:03 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641135129; x=1672671129; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=7Xcg7RMm0ipNu3c/78JM+ZpIc82f5NE1RPqvRMb29zE=; b=j3ywziRDMaELttSVUtUiP5ukch6Bxd/3HsBsyQ+llOSApTEhMr2QolbE OKT/FZVaXUM9A1OEECVFuVNxf1HqOz7v9APV0AkrOj38XofzDeAhUlrd1 dTs5i7LQgOUQXCxbU0z4R6pscpKC4VnABuuzgr4tD5ub+bEyg6W96vMq2 6KPVqa+KVhNPNjBWpexgz/dI3CIVncukSizKzNfL6CqCyIFKST1lSRqwH fUqlw7QvYUOY8SNEcm2KPvRE0DmXE333t1QcvOZq/68ViNAawFI98M0e3 G4XTiCAxdFV+12EVZO+axhH+ae3LWSPmT1mADvqi3wAzuU5reieZTv17j w==; X-IronPort-AV: E=McAfee;i="6200,9189,10214"; a="221965995" X-IronPort-AV: E=Sophos;i="5.88,256,1635231600"; d="scan'208";a="221965995" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2022 06:52:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,256,1635231600"; d="scan'208";a="667176291" Received: from chenwenbin-z390-aorus-ultra.sh.intel.com ([10.239.35.110]) by fmsmga001.fm.intel.com with ESMTP; 02 Jan 2022 06:52:00 -0800 From: Wu Jianhua To: ffmpeg-devel@ffmpeg.org Date: Sun, 2 Jan 2022 22:51:38 +0800 Message-Id: <20220102145142.4083918-1-jianhua.wu@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/5] avutil/hwcontext_vulkan: fixed validation error VUID 01387 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Wu Jianhua Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: nonvEmGp9EXb This commit fixed the validation error that occurred on the Windows platform. Validation Error: [ VUID-vkCreateDevice-ppEnabledExtensionNames-01387 ] Object 0: \ handle = 0x2ab1cfa0db0, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0x12537a2c | \ Missing extension required by the device extension VK_EXT_hdr_metadata: VK_KHR_swapchain. \ The Vulkan spec states: All required device extensions for each extension in the \ VkDeviceCreateInfo::ppEnabledExtensionNames list must also be present in that list \ (https://vulkan.lunarg.com/doc/view/1.2.198.1/windows/1.2-extensions/vkspec.html#\ VUID-vkCreateDevice-ppEnabledExtensionNames-01387) Signed-off-by: Wu Jianhua --- libavutil/hwcontext_vulkan.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index 83a7527198..a2a175a063 100644 --- a/libavutil/hwcontext_vulkan.c +++ b/libavutil/hwcontext_vulkan.c @@ -335,7 +335,11 @@ typedef struct VulkanOptExtension { } VulkanOptExtension; static const VulkanOptExtension optional_instance_exts[] = { - /* For future use */ + /* Misc or required by other extensions */ +#ifdef _WIN32 + { VK_KHR_WIN32_SURFACE_EXTENSION_NAME, FF_VK_EXT_NO_FLAG }, + { VK_KHR_SURFACE_EXTENSION_NAME, FF_VK_EXT_NO_FLAG }, +#endif }; static const VulkanOptExtension optional_device_exts[] = { @@ -344,6 +348,9 @@ static const VulkanOptExtension optional_device_exts[] = { { VK_EXT_HDR_METADATA_EXTENSION_NAME, FF_VK_EXT_NO_FLAG }, { VK_KHR_SAMPLER_YCBCR_CONVERSION_EXTENSION_NAME, FF_VK_EXT_NO_FLAG }, { VK_KHR_SYNCHRONIZATION_2_EXTENSION_NAME, FF_VK_EXT_NO_FLAG }, +#ifdef _WIN32 + { VK_KHR_SWAPCHAIN_EXTENSION_NAME, FF_VK_EXT_NO_FLAG }, +#endif /* Imports/exports */ { VK_KHR_EXTERNAL_MEMORY_FD_EXTENSION_NAME, FF_VK_EXT_EXTERNAL_FD_MEMORY },