From patchwork Mon Jan 3 15:59:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Anthony Lemieux X-Patchwork-Id: 33035 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:cd86:0:0:0:0:0 with SMTP id d128csp16231638iog; Mon, 3 Jan 2022 08:00:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJxHG97BoYwqduPwN92tu89457NhT6NtUM7TkHXzNdVVWVWDI/FyB65ZB6iVVQYB+RpjNf4t X-Received: by 2002:aa7:cd71:: with SMTP id ca17mr5561718edb.19.1641225604568; Mon, 03 Jan 2022 08:00:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1641225604; cv=none; d=google.com; s=arc-20160816; b=yx9ojJNJAvGqyc5HCvCfpif9NIIHVopzi9WeiyCm6m3xVvrofwTewxK9Bhk5SmhTHs vY2SrSrEU4pHGeHTpGXuOBlBE8QT6snIDTJRzX5LkjV2WgxITzULsAfrVDvCtWvmTT+q +z7jN8mYQ0wL2OdN+FPBVyHffpd0oCMwto8bT816FvmD/CU1jyCVwCplHcQctS0sW0F6 ott5ZJdQk9HxiSIJL328IeRMvVI8lJTiISZMddlt1GXATuJo1AmtQ9JovrVkraDLaV7n uPbOO52vGABw+fHvVevAitS+M4IY8ppUnzviC+Zj18ymu/ADoBDoXLFjKFsHcM5W1Fyw sk/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :delivered-to; bh=mlts4IHGw9X7XTZ8eyKhnxgF1f/R/Fi2YRrjVRidllA=; b=UwtZeOTN1Is/Q79QAWdHihAaSiCYpnDeAHVvuZDNvUgFF3My0FcUMGRJRyF0KnXFs9 vDRm+6khLheBnnStfFpwKZpRZBhgQEIiOgHS9sjM0M8k+RNmCIScEq3q+sll27JK+dQ0 +wpX9Nd9HMEfdLKOdyrVhE1o67xZjg3nDgNbRHaAP8i1CpHQzsQJ9igOoeKlsZZuDuvR gFmA9NqLFHyexA0B67Ty24VC3KZsmgGoS9NMBm6GkQied0F+i4DD7eEBgHn+2q+vZf7K NeUsee6QnSaqayG1IPv3MMjDiTs9CzRog57CqL1v9GXNJ6ysw67nSM55QER8H9rtH1mF 1cJA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id s5si20880780edd.240.2022.01.03.08.00.03; Mon, 03 Jan 2022 08:00:04 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 717FC68B199; Mon, 3 Jan 2022 17:59:59 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 71407680297 for ; Mon, 3 Jan 2022 17:59:52 +0200 (EET) Received: by mail-pj1-f50.google.com with SMTP id l10-20020a17090a384a00b001b22190e075so32774027pjf.3 for ; Mon, 03 Jan 2022 07:59:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hffl/RjUo9yVFcsZ6wcuW60hNI6ubPNGOXwUDCjN6FU=; b=h7D6LVTYgqOlIqyJLO0R1G14Jz3zaDvan7DGy/JGkVmoJ+q9vqQd7nu72hmLxhyfeY FZhdV4FGBP0lygqMtsl8gLxk5aNHhlgom1mjqeuyelKlLifDUcN82CfYVCNrD5EAphUI VO5HjJi50RbUPLK/enDLrFZZ/RQV0d758jQ17QxM2WSe/Oh3dtRteYrjh+T1ArBSI8ru LOFkso3E2PK5zkZSg+jszBtv9aeAFFZzu/tZ9uVbof/dy8YXw7S4b4kunztZn841Ij6J EFDnB2dr0oDeNU26tpK8PbjdhGh7SMjw5rYmelJ1rERWDgNOQAA1FgLlR1/T5dv6BLFh CyMQ== X-Gm-Message-State: AOAM533i4+y0uO6Ljf03sG2/a1LN+eZPkAtqda+freE/xe+lNTmOi3DF rc2+m1YgBCu5+MAJk+aaZnJO+rjnZew= X-Received: by 2002:a17:90b:4ad2:: with SMTP id mh18mr55733134pjb.197.1641225590167; Mon, 03 Jan 2022 07:59:50 -0800 (PST) Received: from localhost (76-14-89-2.sf-cable.astound.net. [76.14.89.2]) by smtp.gmail.com with ESMTPSA id g19sm32261189pfv.19.2022.01.03.07.59.47 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Jan 2022 07:59:49 -0800 (PST) Received: by localhost (sSMTP sendmail emulation); Mon, 03 Jan 2022 07:59:29 -0800 From: pal@sandflow.com To: ffmpeg-devel@ffmpeg.org Date: Mon, 3 Jan 2022 07:59:19 -0800 Message-Id: <20220103155919.12015-1-pal@sandflow.com> X-Mailer: git-send-email 2.34.1.windows.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v1] avformat/imf: fix bad free() when directory name of the input url is empty X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Pierre-Anthony Lemieux Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: U79G/6CydrSn From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: Found through manual fuzzing. libavformat/imfdec.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c index f17064cfcd..4e42db8d30 100644 --- a/libavformat/imfdec.c +++ b/libavformat/imfdec.c @@ -622,11 +622,15 @@ static int imf_read_header(AVFormatContext *s) int ret = 0; c->interrupt_callback = &s->interrupt_callback; + tmp_str = av_strdup(s->url); if (!tmp_str) return AVERROR(ENOMEM); + c->base_url = av_strdup(av_dirname(tmp_str)); + av_freep(&tmp_str); + if (!c->base_url) + return AVERROR(ENOMEM); - c->base_url = av_dirname(tmp_str); if ((ret = ffio_copy_url_options(s->pb, &c->avio_opts)) < 0) return ret;