| Message ID | 20220104200626.21573-1-michael@niedermayer.cc |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel] doc/developer: patches should not cross libs or mix MAINTAINER changes in | expand |
| Context | Check | Description |
|---|---|---|
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
| andriy/make_ppc | success | Make finished |
| andriy/make_fate_ppc | fail | Make fate failed |
4 Jan 2022, 21:06 by michael@niedermayer.cc: > maintainer part inspired by IRC comments by lynne > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > --- > doc/developer.texi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/doc/developer.texi b/doc/developer.texi > index addee0d8263..eae3ade48a7 100644 > --- a/doc/developer.texi > +++ b/doc/developer.texi > @@ -683,6 +683,10 @@ are notoriously left unchecked, which is a serious problem. > @item > Test your code with valgrind and or Address Sanitizer to ensure it's free > of leaks, out of array accesses, etc. > + > +@item > +Changes to 2 libs which change both versions should be in 2 seperate patches. > +Non cosmetic changes to @file{MAINTAINERS} should not be in a patch with other changes. > @end enumerate > LGTM
Michael Niedermayer: > maintainer part inspired by IRC comments by lynne > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > --- > doc/developer.texi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/doc/developer.texi b/doc/developer.texi > index addee0d8263..eae3ade48a7 100644 > --- a/doc/developer.texi > +++ b/doc/developer.texi > @@ -683,6 +683,10 @@ are notoriously left unchecked, which is a serious problem. > @item > Test your code with valgrind and or Address Sanitizer to ensure it's free > of leaks, out of array accesses, etc. > + > +@item > +Changes to 2 libs which change both versions should be in 2 seperate patches. ^ ^ maybe spell this out a (I presume that the pre- and post-release version bump patches are supposed to be exempt from this?) > +Non cosmetic changes to @file{MAINTAINERS} should not be in a patch with other changes. > @end enumerate > > @chapter Patch review process >
diff --git a/doc/developer.texi b/doc/developer.texi index addee0d8263..eae3ade48a7 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -683,6 +683,10 @@ are notoriously left unchecked, which is a serious problem. @item Test your code with valgrind and or Address Sanitizer to ensure it's free of leaks, out of array accesses, etc. + +@item +Changes to 2 libs which change both versions should be in 2 seperate patches. +Non cosmetic changes to @file{MAINTAINERS} should not be in a patch with other changes. @end enumerate @chapter Patch review process
maintainer part inspired by IRC comments by lynne Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- doc/developer.texi | 4 ++++ 1 file changed, 4 insertions(+)