From patchwork Wed Jan 5 08:31:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Martin_Storsj=C3=B6?= X-Patchwork-Id: 33083 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:cd86:0:0:0:0:0 with SMTP id d128csp520287iog; Wed, 5 Jan 2022 00:31:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJxTNtwgrCFHIcwGg4a8qgk22o0F2h9Ec20BSxruxO0k+f85IIXmsMDI4LMek5uPod1RwMMV X-Received: by 2002:a17:907:72c6:: with SMTP id du6mr37970546ejc.552.1641371507241; Wed, 05 Jan 2022 00:31:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1641371507; cv=none; d=google.com; s=arc-20160816; b=V8lY/nnr4nh2VvnLE3dM8Uy+3q2/s/gZtXn52NcBz5ka1or3jO8hxFgxDteAsR0gvB bJaZiHKhzosCPNHGDZOdXcD2f810jqEVeu7EZKGNVbCf3guVnr9cXoft8855/UZbOe3n VIrtUzh5VbB9zIgnc3hT9FHMtandX8GDo2ePYpfG0H1GuiDhaK2ObwE5k9+38G+NCP9p yffmIeXSPpebUvUcscGZYz9GXhHswZ4/lu6l3PblYhC6V+oG50R9rX7rfdxabvmzb9BJ p7NwedLxNvpQlEmTok42JmW0ABQpTlGoUovGG6lnpgxALzGm6Na2PAwom78/gGgV6c2f 9guw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=b59fdLZX47nwSxg2wYmk7nSUVuYeCdHYgnzRJAQqEog=; b=Q9rtDEKyzNQ9bEwddyCRwEEYYgQuWtwC14qVDpV4th7Ajzc2Pk07S/dt+sCYuDBVf0 kcTQxz/DMv6Fn5YDEoKMHRkLmsoy+KbI852XCWG/slSCNrXtfdo1l3jN4EhsNe6TaDYL qTxX6ARE3nr1bQ2uAdeNsScjbxDsqerJ70BRVd4g9aP+hIY1iWHc4S1cQLfdjsnx1jvP +cncYQMczu5bxrSjGsAcueqx3O8wxkzHPVx7ot30zpDD9w35yl0VPewdJN6210tL7ShH +lJJV+CCBHkFRnx9XNNXsIxNNzyvpNPgNZ+V93xnoX8ES9T1T4OzSP+SriAgFWNovRbb 9TGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@martin-st.20210112.gappssmtp.com header.s=20210112 header.b=u0TkJfZ6; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id nc41si20872513ejc.520.2022.01.05.00.31.46; Wed, 05 Jan 2022 00:31:47 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@martin-st.20210112.gappssmtp.com header.s=20210112 header.b=u0TkJfZ6; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 156FC68AB64; Wed, 5 Jan 2022 10:31:21 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8368568A948 for ; Wed, 5 Jan 2022 10:31:10 +0200 (EET) Received: by mail-lf1-f43.google.com with SMTP id u13so87321177lff.12 for ; Wed, 05 Jan 2022 00:31:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20210112.gappssmtp.com; s=20210112; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=H1vlAhhGicFkOPQQoC8DNfYe294SvOue8FnK+F/ejMc=; b=u0TkJfZ6Wev3xjEJPJIp+A8/mfWFFE+UT5dPXTSDxCq8lFrUcyiE7XrDqBzMcVVB7/ lRcwvX7qeU2Xxt6ieqSiJJw8PmgQYpyc96BeC1RiIzEiVqeDC/EMqgKpZPEPBCRI6wL9 N44sjkrkEmTsKBqySndTWwv5FDQNx8ksuq73Z1vEP6Qvzf/cduHi2QnNrYFzXKDg/Xho dpNgzmWP5vDe4Lz05j/wnPUW/z51AnQ4+Q0ayJGNtFGmRpIxw4xTfbPTQBuwA37fvj+T PHggK0/ntT/iZKLxq6bXd1U249JWk1rwWQ1MbqFhX4Kx2RHkeeyxpRBrG4/BGVQGhvjJ qCmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=H1vlAhhGicFkOPQQoC8DNfYe294SvOue8FnK+F/ejMc=; b=FNlP6g2vFZdXATLd2qNy4wL4kS+wUF4R3FeNNdV1P1KwyOn/mklEIzMhFJ+vitX8u1 Kn/MBu29P9IFLTI5KmP15tPtuZPZ7RYzteaoPuwUFGgWXIya2SL7HXA1wF3DtXar8J7l 6jT3WG22JyvlYUMHJDQyltz/Kpg515GJ66Qz4sTuITW+cga9/DwRRt5s05Nv5By022X9 Yc/8TB3wHuPnMwFHEqiDADIrDso3quX82vuBYumxDn+tNafZNMOyowtqD5HTomYRj6V1 KYQCyXX/s1o/EdJ7luRY1P116FOacLLgHF9UPLKXWbK7/VTYDNkxApf6g4/vpu9gTjH5 5y+w== X-Gm-Message-State: AOAM532LMLLjT5ZY/G9olbMeTV7TpxgC0QjfiJ5qZGJzq2A22/GWZ/M/ VfEVJBl/JCiT15WxPEyUNquBi7DxMOfeAV9E X-Received: by 2002:ac2:4895:: with SMTP id x21mr47832269lfc.336.1641371469504; Wed, 05 Jan 2022 00:31:09 -0800 (PST) Received: from localhost.localdomain (dsl-tkubng21-58c01c-243.dhcp.inet.fi. [88.192.28.243]) by smtp.gmail.com with ESMTPSA id w25sm3631055lfl.229.2022.01.05.00.31.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jan 2022 00:31:09 -0800 (PST) From: =?utf-8?q?Martin_Storsj=C3=B6?= To: ffmpeg-devel@ffmpeg.org Date: Wed, 5 Jan 2022 10:31:07 +0200 Message-Id: <20220105083107.1930899-4-martin@martin.st> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220105083107.1930899-1-martin@martin.st> References: <20220105083107.1930899-1-martin@martin.st> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 4/4] aarch64: Disable ff_hevc_sao_band_filter_8x8_8_neon out of precaution X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: EpJr1xfQPfNm While this function on its own passes all of fate-hevc, there's indications that the function might need to handle widths that aren't a multiple of 8 (noted in commit f63f9be37c799ddc835af358034630d31fb7db02, which later was reverted). --- libavcodec/aarch64/hevcdsp_init_aarch64.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/aarch64/hevcdsp_init_aarch64.c b/libavcodec/aarch64/hevcdsp_init_aarch64.c index c785e46f79..1e40be740c 100644 --- a/libavcodec/aarch64/hevcdsp_init_aarch64.c +++ b/libavcodec/aarch64/hevcdsp_init_aarch64.c @@ -75,7 +75,11 @@ av_cold void ff_hevc_dsp_init_aarch64(HEVCDSPContext *c, const int bit_depth) c->idct_dc[1] = ff_hevc_idct_8x8_dc_8_neon; c->idct_dc[2] = ff_hevc_idct_16x16_dc_8_neon; c->idct_dc[3] = ff_hevc_idct_32x32_dc_8_neon; - c->sao_band_filter[0] = ff_hevc_sao_band_filter_8x8_8_neon; + // This function is disabled, as it doesn't handle widths that aren't + // an even multiple of 8 correctly. fate-hevc doesn't exercise that + // for the current size, but if enabled for bigger sizes, the cases + // of non-multiple of 8 seem to arise. +// c->sao_band_filter[0] = ff_hevc_sao_band_filter_8x8_8_neon; } if (bit_depth == 10) { c->add_residual[0] = ff_hevc_add_residual_4x4_10_neon;