From patchwork Mon Jan 17 05:11:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Chen, Wenbin" X-Patchwork-Id: 33638 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:cd86:0:0:0:0:0 with SMTP id d128csp2453875iog; Sun, 16 Jan 2022 21:13:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJx0iR63V/P6XHAQN4rR/9jBiTGz9x9ddy3na0DyQa5V6p9Gx/DKNVWvh2WvFES5Vm3nZojs X-Received: by 2002:a17:907:72cb:: with SMTP id du11mr1650119ejc.703.1642396388611; Sun, 16 Jan 2022 21:13:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642396388; cv=none; d=google.com; s=arc-20160816; b=gtCbBwhTMwzaV+H/UxOilLaF1LytQyjtXUotcyfFiG/Kkc9uE8dnOotUUD4GQSVilj scfMUQW2iNV1vDKrwhp9iWdaD4ZcBXGqBLH0Gfo/8bHnnbHy6HBA23okBuEKKWMix4i4 fSMjfwLgPrB4V7HKuoVeG+Brfq+AWdOj+7VlAQNXQBXea9Dj3bG1ah4PsglXCW3O3sBT IRO03qs5ihBMObFwlETPtoqRECl02LRjYxxknwcs2f3LSFnqAMgnAWkZ4k4NeJUgCfB7 1vJyEtz3qgwY9Qi7JmxcdVikBPtJDb0jKmnwF5AFj6wTbz6VQrESVf3ArSXQBPmHse7N cl/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=zDblUfaUWkduXok3dRcQb/Hu6F8xx6gHxZxHewQVR0s=; b=OrQBg7Tk400MKdr/zmLRapk0lTe5LUSj+UZq1Rsz8OrNN67KaHApzFQfvDnV/uBVbm OhsrWRu9j950p2SemqTdeXA4LAYpryMZvEnXHL9i0zSYHwIu2XGWpC5dHkvJokD0W3SM z3hOMdfePe1bYqCC81FDRega3OvaXW4TFkPwBUKeWGLNziwWcMM0u/hg2acj0STqOMQm 5WO9yASgH+ciGmk2EPIjz/Sn8j8XzKHKJSDgPepkNpNWAT1b3N1g2FEzx9vOiHPy133y HMz9JIdxYpp7yc/C4dVNQB6HG7gufF4Be7VY4PBy6QyQZyXV9UQnPhjvDV+V3eiBoZay kNaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=dbtNem+N; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id u7si5405330edd.562.2022.01.16.21.13.08; Sun, 16 Jan 2022 21:13:08 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=dbtNem+N; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3004068AF5D; Mon, 17 Jan 2022 07:12:53 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 630B068A62B for ; Mon, 17 Jan 2022 07:12:46 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642396371; x=1673932371; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=jkJeUzTPcYOOK21owa9GY7LpexH3i1aR7W9WnDtBFog=; b=dbtNem+Nll2CGvKvyIi1uxQMYoA4/CGCWvgAGomMItgznVDc2njYMp42 YOPnZPD4FR6sVuxGXbIxSq/ph+akUZ8ZitZhqV9VhCiUqjXV6knGficS9 YL1mPr/bK/pTsTc4rq0cFkCW5lw059CliGHll3Tm9GMEwqTkfbq2RX5u5 6W//FjwJv+qgxpGKxiyY4hp3PFtdbER/AEwn1NDqmFdN02kaq9cQSHep3 tOBRLomEBP3PGmU7tGBHm5b9opa58VeAUCaV2T+inFltuQ6EdU2ckABxE x+m/WJInKbaljdKqjN2RmUitmHY+Nk6xDHhhaG0GdG3SDRfegE3xLTACP Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10229"; a="242111662" X-IronPort-AV: E=Sophos;i="5.88,294,1635231600"; d="scan'208";a="242111662" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2022 21:12:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,294,1635231600"; d="scan'208";a="517278346" Received: from chenwenbin-z390-aorus-ultra.sh.intel.com ([10.239.35.110]) by orsmga007.jf.intel.com with ESMTP; 16 Jan 2022 21:12:41 -0800 From: Wenbin Chen To: ffmpeg-devel@ffmpeg.org Date: Mon, 17 Jan 2022 13:11:20 +0800 Message-Id: <20220117051122.628422-2-wenbin.chen@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220117051122.628422-1-wenbin.chen@intel.com> References: <20220117051122.628422-1-wenbin.chen@intel.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH V5 2/4] libavcodec/qsvenc: Add DisableDeblockingIdc support to qsv X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: MK/DJwB4Z7wd Add dblk_idc option to 264_qsv and hevc_qsv. Turining on this opion can disable deblocking. Signed-off-by: Wenbin Chen --- doc/encoders.texi | 6 ++++++ libavcodec/qsvenc.c | 7 +++++++ libavcodec/qsvenc.h | 3 +++ 3 files changed, 16 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index 68921fbd40..6fc94daa11 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -3299,6 +3299,9 @@ This flag controls changing of frame type from B to P. @item @var{b_strategy} This option controls usage of B frames as reference. +@item @var{dblk_idc} +This option disable deblocking. It has value in range 0~2. + @item @var{cavlc} If set, CAVLC is used; if unset, CABAC is used for encoding. @@ -3391,6 +3394,9 @@ Enable rate distortion optimization. @item @var{max_frame_size} Maximum encoded frame size in bytes. +@item @var{dblk_idc} +This option disable deblocking. It has value in range 0~2. + @item @var{idr_interval} Distance (in I-frames) between IDR frames. @table @samp diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index b3728d28d5..e18a96e216 100644 --- a/libavcodec/qsvenc.c +++ b/libavcodec/qsvenc.c @@ -346,6 +346,10 @@ static void dump_video_param(AVCodecContext *avctx, QSVEncContext *q, av_log(avctx, AV_LOG_VERBOSE, "FrameRateExtD: %"PRIu32"; FrameRateExtN: %"PRIu32" \n", info->FrameInfo.FrameRateExtD, info->FrameInfo.FrameRateExtN); +#if QSV_HAVE_DISABLEDEBLOCKIDC + av_log(avctx, AV_LOG_VERBOSE, "DisableDeblockingIdc: %"PRIu32" \n", co2->DisableDeblockingIdc); +#endif + } static void dump_video_vp9_param(AVCodecContext *avctx, QSVEncContext *q, @@ -889,6 +893,9 @@ static int init_video_param(AVCodecContext *avctx, QSVEncContext *q) q->extco2.ExtBRC = q->extbrc ? MFX_CODINGOPTION_ON : MFX_CODINGOPTION_OFF; if (q->max_frame_size >= 0) q->extco2.MaxFrameSize = q->max_frame_size; +#if QSV_HAVE_DISABLEDEBLOCKIDC + q->extco2.DisableDeblockingIdc = q->dblk_idc; +#endif #if QSV_VERSION_ATLEAST(1, 9) if (avctx->qmin >= 0 && avctx->qmax >= 0 && avctx->qmin > avctx->qmax) { diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h index 31516b8e55..08e902be74 100644 --- a/libavcodec/qsvenc.h +++ b/libavcodec/qsvenc.h @@ -44,6 +44,7 @@ #define QSV_HAVE_TRELLIS QSV_VERSION_ATLEAST(1, 8) #define QSV_HAVE_MAX_SLICE_SIZE QSV_VERSION_ATLEAST(1, 9) +#define QSV_HAVE_DISABLEDEBLOCKIDC QSV_VERSION_ATLEAST(1, 9) #define QSV_HAVE_BREF_TYPE QSV_VERSION_ATLEAST(1, 8) #define QSV_HAVE_LA QSV_VERSION_ATLEAST(1, 7) @@ -97,6 +98,7 @@ { "b_strategy", "Strategy to choose between I/P/B-frames", OFFSET(qsv.b_strategy), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, 1, VE }, \ { "forced_idr", "Forcing I frames as IDR frames", OFFSET(qsv.forced_idr), AV_OPT_TYPE_BOOL,{ .i64 = 0 }, 0, 1, VE }, \ { "low_power", "enable low power mode(experimental: many limitations by mfx version, BRC modes, etc.)", OFFSET(qsv.low_power), AV_OPT_TYPE_BOOL, { .i64 = -1}, -1, 1, VE},\ +{ "dblk_idc", "This option disable deblocking. It has value in range 0~2.", OFFSET(qsv.dblk_idc), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 2, VE}, \ extern const AVCodecHWConfigInternal *const ff_qsv_enc_hw_configs[]; @@ -169,6 +171,7 @@ typedef struct QSVEncContext { int rdo; int max_frame_size; int max_slice_size; + int dblk_idc; int tile_cols; int tile_rows;