diff mbox series

[FFmpeg-devel,GASPP] Filter out -D parameters from the call to GCC/Clang to assemble

Message ID 20220118130012.626437-1-martin@martin.st
State New
Headers show
Series [FFmpeg-devel,GASPP] Filter out -D parameters from the call to GCC/Clang to assemble | expand

Checks

Context Check Description
andriy/configurex86 warning Failed to apply patch
andriy/configureppc warning Failed to apply patch
andriy/configure_aarch64_jetson warning Failed to apply patch
andriy/configure_armv7_RPi4 warning Failed to apply patch

Commit Message

Martin Storsjö Jan. 18, 2022, 1 p.m. UTC 
Clang warns about unused -D parameters when operating on .s
files (or if invoked with "-x assembler") while GCC doesn't.
---
As noobdy else than me essentially maintains gas-preprocessor, I'll
go ahead and push this after a couple days if nobody speaks up.
---
 gas-preprocessor.pl | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Martin Storsjö Jan. 24, 2022, 1:15 p.m. UTC | #1 
On Tue, 18 Jan 2022, Martin Storsjö wrote:

> Clang warns about unused -D parameters when operating on .s
> files (or if invoked with "-x assembler") while GCC doesn't.
> ---
> As noobdy else than me essentially maintains gas-preprocessor, I'll
> go ahead and push this after a couple days if nobody speaks up.

Pushed now.

// Martin
diff mbox series

Patch

diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl
index 8028d81..67b130e 100755
--- a/gas-preprocessor.pl
+++ b/gas-preprocessor.pl
@@ -158,6 +158,10 @@  while ($index < $#preprocess_c_cmd) {
 my $tempfile;
 if ($as_type ne "armasm") {
     @gcc_cmd = map { /\.[csS]$/ ? qw(-x assembler -) : $_ } @gcc_cmd;
+
+    # Filter out options that can cause warnings due to unused arguments,
+    # Clang warns about unused -D parameters when invoked with "-x assembler".
+    @gcc_cmd = grep ! /^-D/, @gcc_cmd;
 } else {
     @preprocess_c_cmd = grep ! /^-c$/, @preprocess_c_cmd;
     @preprocess_c_cmd = grep ! /^-m/, @preprocess_c_cmd;