From patchwork Tue Jan 18 13:00:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Martin_Storsj=C3=B6?= X-Patchwork-Id: 33646 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:cd86:0:0:0:0:0 with SMTP id d128csp3714731iog; Tue, 18 Jan 2022 05:00:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQxvYAn7Vkw7tLVVNWVnovlBDyTjvjI2zZofxPlg1seh3VR4d+LyyCGBEj3WF7QGCDHu/1 X-Received: by 2002:a05:6402:1bd9:: with SMTP id ch25mr21573696edb.84.1642510825408; Tue, 18 Jan 2022 05:00:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642510825; cv=none; d=google.com; s=arc-20160816; b=fUmITMtebCYvhK8kZpY+UBu5UcsO1pSOSISkgM12k39nzATbT46LJKPyKQzehds2nl XHjpiJ3CqOe1AX2RAHBPm5GTqGHBXEz/88jqAuhJcBJ9W74lO2znYst+i4S33FSIR8QI EL1pxd7M+Dp9DfePEQ2EKAMQxhFs0d9YcgZl+CitrgkoXxJVGQd3T4WFx3h8Q0i3ywOe 0Ynu+VWeLqKLf461kCGCFqq2/RO8fSEt3VX9/RkJoOa22tsikrdhoqXmcT7wzxpmhsN/ 3RFdsak2tm9GDhcEN2YTEs85QsCWoMpj4wh33vQbAql1bE+8Rlh7RI1xc2je3l2bsn+W ggrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=0sji00tRUN8eTD9OIumeMVMsl2UcAT2FQSUIIDCE4bw=; b=d/lLXI2zlw4whUfkrnr8A1t0w7KQBwZwqLzKwLISF09NhNEN7uHx2iQ+Q2zOug/58G WaLDLRAN0ZAhanMsLzjajYyoedSfbPqinn2C/gvch+Un5fMyxAfkR+bGWyrSb+WWRa/C r+2VA2yWOfEHSI1AIXfj+K5+yf2/vHJp27SL2kcC6ffh1OCPqpHVdOo1mX2HV+rjrcK7 GsuXInFArEI+Ww1jYES6FaWG4vvNamtScfm15ugCthPBqM4IAN1sgH/9mSBtHX1+Ej3T BES53GhH+wawq9BY8vxTU0xt7+gN1fIOBgLtYkV8kKZBgHO8QkmeFMLLz8KmPdd4gF7G uk+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@martin-st.20210112.gappssmtp.com header.s=20210112 header.b="3Y/GlAvE"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id t5si4099985ejj.440.2022.01.18.05.00.24; Tue, 18 Jan 2022 05:00:25 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@martin-st.20210112.gappssmtp.com header.s=20210112 header.b="3Y/GlAvE"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 921DE68B0F9; Tue, 18 Jan 2022 15:00:21 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C417268B0B3 for ; Tue, 18 Jan 2022 15:00:14 +0200 (EET) Received: by mail-lf1-f51.google.com with SMTP id o15so70226159lfo.11 for ; Tue, 18 Jan 2022 05:00:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20210112.gappssmtp.com; s=20210112; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=+s1O5JUkmJFoL13yyFBL4Rt/Hg7p64fcj8U4A/maCwc=; b=3Y/GlAvEV+qeYBs3Jiqlw/5JFnvW325NbN/bRuJrOI1bIH3bvyLb/Bf/7ZC3PDZNyE eOqlTxOTT6auzBDfG4QVuqkwsIFv0OZKjwuD9RCpHseG/BGbjeejYXejcMJFyU2TjK9T 2PoUajecSAxNQ94tNrLHmhyWH8ErJgUuABW6BkuYGN1OY9jS0DtOv4mcI3/i3RElK8XB HaURR4K2NZqobtBJ8UtKT5yRU8NPHLxIt1xe5yMe6LCSDt4cvYxFaVArKyN80rM9alTk Ggs2mtEqbkrBiukj7f63+IfNVb3JhUf3TXlvhT+o1kA7YBAKJlJiJ9574aBuww2aXNz+ K+xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=+s1O5JUkmJFoL13yyFBL4Rt/Hg7p64fcj8U4A/maCwc=; b=55toVJvmFO2TA9mitA1T98QC9wWC9TSUimf6JEm7Oy8WCUVHfGreYXugEODbugEN9R ZbN+C2D9OgwjQ80SEuh8n6PR4ntqpIi22V8cn1PuntA1O6PlU2koCulK+CEnWTCgYBYT r8OHckQv/0R2QcC5STcUHxHdioIu4xRuDJADECP3Wo9fj3IMbNrm+SVza+DGBqge0/nh iydFTVf9CFRlpU9o/Rxj+9PMWonD973SlktXmZC+sgAMdzpNexB3bFygE763j/rBTJ8b cLhgKMcOoaekJS+5nspl8P+Od0qeyfPowtlcXytbminXwtKR8++gi6rhSHXTmv+iEBhm uYYQ== X-Gm-Message-State: AOAM533p+RNDSJvjKi7sSe5VPTrMZPGYjdVeRSD87meXZByW5xL/fEVm 8QaT1qkqf39SYt/87uVEfl9KJ4eVwCNQ5q2N X-Received: by 2002:a2e:bf18:: with SMTP id c24mr21334014ljr.104.1642510813985; Tue, 18 Jan 2022 05:00:13 -0800 (PST) Received: from localhost.localdomain (dsl-tkubng21-58c01c-243.dhcp.inet.fi. [88.192.28.243]) by smtp.gmail.com with ESMTPSA id b3sm1607104ljp.139.2022.01.18.05.00.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jan 2022 05:00:13 -0800 (PST) From: =?utf-8?q?Martin_Storsj=C3=B6?= To: ffmpeg-devel@ffmpeg.org Date: Tue, 18 Jan 2022 15:00:12 +0200 Message-Id: <20220118130012.626437-1-martin@martin.st> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [GASPP PATCH] Filter out -D parameters from the call to GCC/Clang to assemble X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 12rWorDp9fkl Clang warns about unused -D parameters when operating on .s files (or if invoked with "-x assembler") while GCC doesn't. --- As noobdy else than me essentially maintains gas-preprocessor, I'll go ahead and push this after a couple days if nobody speaks up. --- gas-preprocessor.pl | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl index 8028d81..67b130e 100755 --- a/gas-preprocessor.pl +++ b/gas-preprocessor.pl @@ -158,6 +158,10 @@ while ($index < $#preprocess_c_cmd) { my $tempfile; if ($as_type ne "armasm") { @gcc_cmd = map { /\.[csS]$/ ? qw(-x assembler -) : $_ } @gcc_cmd; + + # Filter out options that can cause warnings due to unused arguments, + # Clang warns about unused -D parameters when invoked with "-x assembler". + @gcc_cmd = grep ! /^-D/, @gcc_cmd; } else { @preprocess_c_cmd = grep ! /^-c$/, @preprocess_c_cmd; @preprocess_c_cmd = grep ! /^-m/, @preprocess_c_cmd;