From patchwork Thu Jan 20 07:13:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Chen, Wenbin" X-Patchwork-Id: 33720 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:cd86:0:0:0:0:0 with SMTP id d128csp5565262iog; Wed, 19 Jan 2022 23:15:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJwlccGKoNLP2fViBRsAiAzIGNi23cOOF1fce92yf/7XpHAfRttJhNVSvounGZz76TqQg4vH X-Received: by 2002:aa7:c615:: with SMTP id h21mr4362972edq.175.1642662930275; Wed, 19 Jan 2022 23:15:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642662930; cv=none; d=google.com; s=arc-20160816; b=DxrnTy2RNw44wRVlWYNjAtY+lhtQb6FWAJ+rqht5FghTVZI/2HPAV8+KAbW8dRItK7 UkUPkJVcZN5JK8IHQSpUTPFi51crjuIJIOw01bB+Tp9ahIrOyPUsF9QpbPiMkhhuZHAo 0xclNUH0c5JoXu5RHgr5G4PN2a0EUiZ9bgHZq+W8X/Mqdjv+IFY6be3TMxH6gBhVEUdp VSTwWF67LJi/nXJxVkZUY+9PRTiSe8SHk6QDwAZbFO/ByOYlZc+PdpUr0Br/g4zgxFum yQeaC2pFb0f90ACpYi71KlfydVxxLG+YbhwJMTBfECXBHGwIgwiGbVN6cCsABaMjc5Dc ApnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=bZH0EaDKGQHr1PcHcOxp+iCNPWbqHV2y+XnibszqfYo=; b=MQnXcZYGgp9CqmpiEkbQ+QXN4dTvSb3X7ND7zlU2mhbPjGL0XeLvJTcwYZ1z6secrz ZRe1FeI471RLMRsiMIWNLUyNB0y/BYWmPv+uiHouPu9zOFHGkjjv0loVVxcg8cAztUVw TkXnjmWUB8R9MH8p29luLtQj2yglMRXxWRyWtMSfo/ik5gibjI6qKU460pz8WUpZ4sjF 8tQ9AYHV4+1hNVGIspWoq8Qp2cw2z3eLdwAOz+brgXKEn2+pT3u8decYORErES/xBRWI CMMna7FgQl5uYTtqBFM2AeiCdFhFsdZTrhgOagNs43rbIBaf+Z41RYC3jSQkSYeVH2H6 uXDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=lBcXHAtm; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id i9si1781882edc.399.2022.01.19.23.15.29; Wed, 19 Jan 2022 23:15:30 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=lBcXHAtm; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0CA5E68B25B; Thu, 20 Jan 2022 09:15:25 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5916868B208 for ; Thu, 20 Jan 2022 09:15:17 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642662923; x=1674198923; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=1TUABgp/gD+AjHV3W9uppQ3N2U/Cgj5eHJfvTAvP7ac=; b=lBcXHAtm2kAGn+/04Zsrdf5IkdN4hNgMGZQW2r5c8IbUYnB6k3WExc/n gq8mVyl18vdfJ/qgWSGFRTJCMzjJDpXzUpUBSd2V8O14eRHFX6fiqDmAS G0niJ9a84ax4u1ZcFDf4S9FuoZs1ePRT6sbkjWEhGLv0hKdSxFEoMyMVe eGLn65oTvcePLNeq9At3z64+7ae0sR+syvmjJQm/QYz1V9Gvr/Jd1+Yg1 cEhecj30Jh0DOtaMcXvKcyIjcuucCvCrfnQvYmMnTakJw991dAJh7MX8D ED7Do3ByiNOZt4wSxCdfR9AgtzRY5q2k0Tgq1Brexgosst/dpVf3vCc5f w==; X-IronPort-AV: E=McAfee;i="6200,9189,10232"; a="306021539" X-IronPort-AV: E=Sophos;i="5.88,301,1635231600"; d="scan'208";a="306021539" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 23:15:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,301,1635231600"; d="scan'208";a="626192251" Received: from chenwenbin-z390-aorus-ultra.sh.intel.com ([10.239.35.110]) by orsmga004.jf.intel.com with ESMTP; 19 Jan 2022 23:15:14 -0800 From: Wenbin Chen To: ffmpeg-devel@ffmpeg.org Date: Thu, 20 Jan 2022 15:13:43 +0800 Message-Id: <20220120071343.187817-1-wenbin.chen@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: fix a memory leak problem X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: IU/NYhxdAV4a "qf->frame" ref to input frame but it isn't released. av_frame_unref() is added before refering qf->frame to new frame to make sure the previous reference is released. Signed-off-by: Wenbin Chen --- libavcodec/qsvenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index 269386624d..fd5c460d68 100644 --- a/libavcodec/qsvenc.c +++ b/libavcodec/qsvenc.c @@ -1521,6 +1521,7 @@ static int submit_frame(QSVEncContext *q, const AVFrame *frame, return ret; } } else { + av_frame_unref(qf->frame); ret = av_frame_ref(qf->frame, frame); if (ret < 0) return ret;