From patchwork Tue Jan 25 10:21:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 33838 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6602:2c4e:0:0:0:0 with SMTP id x14csp490959iov; Tue, 25 Jan 2022 02:22:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJw+zkM4G50Moi/aZoKy5aDQMJBlxtFvp6S1kHqEGteezdY9POK489AyK8XzVyluzlxE3mNU X-Received: by 2002:a17:906:2ec8:: with SMTP id s8mr15754626eji.746.1643106140737; Tue, 25 Jan 2022 02:22:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643106140; cv=none; d=google.com; s=arc-20160816; b=VSHu6hFOtm6tjgVAgVp+WnF1mLhyMgDj9kOHsHiRIrwh5wDSAvDstRMje/4Y03j3vw P2eYc7A75pKvg4DTtidd4SHtE+vD6gRCah/alpc96uSlacMrkPnHVNFNukmkrO+9tWuP k6qEEys6+kyX6zKo7/esdynaZgAeQl1jyGJOYUsc4K/83M8bOg33f96Jsv0g3Adb7R1U xrIGm57G7jrBtSS6QnnTrJw/LmqzCHVjr1QXiHuP4HqvOahK/mKGTvzSq30ssGZfV2MK Nr7ZvRbgk3uPIT3NCPVexGHHwkL7axAN2kWpXL9J+RoDdevON8gnizYaaq6imxMZHy17 Ieuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:delivered-to; bh=5W2UZTtvr6AX8HLXonWEVKM4ykEdx/RiyyrSHWa+PmU=; b=v01HcX1z+naK0PrJquksHDpgHnV1FiIge6BvJi6QHr/+/cge8SVCtblgYrxLdCE/m0 pyEp6rlEJ4+HfgG1t6ph6H6ltBtT1XDPY6rED9JjZSJYiaRjj1zUeTeDU8e7qocRXP9v YJzUkTYSciS/zrwqwRJrJNwftiDhPhqaRBGPLxoToZq7MkNf2DzGICMGR7P9F5C9T0pv EoDqDMRdCh9N1kHHz7QwVPehbl8IYCo+yNlr3TIMFXY5uZq3o2CP4B/iNqLSmq73J2c4 B+RhO+8r2XurXgM8LIUVFR6/VzTAJKWiWRngOGBJcSFaNEMRgKgfXKhzKIrUwM3UPJEo ChIg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id cw1si10885375ejc.47.2022.01.25.02.22.19; Tue, 25 Jan 2022 02:22:20 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 900CD68B087; Tue, 25 Jan 2022 12:22:16 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-dmta-pe05-3.mx.upcmail.net (vie01a-dmta-pe05-3.mx.upcmail.net [84.116.36.13]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6835868B008 for ; Tue, 25 Jan 2022 12:22:10 +0200 (EET) Received: from [172.31.216.235] (helo=vie01a-pemc-psmtp-pe12.mail.upcmail.net) by vie01a-dmta-pe05.mx.upcmail.net with esmtp (Exim 4.92) (envelope-from ) id 1nCIxl-006mPc-0A for ffmpeg-devel@ffmpeg.org; Tue, 25 Jan 2022 11:22:09 +0100 Received: from localhost ([213.47.68.29]) by vie01a-pemc-psmtp-pe12.mail.upcmail.net with ESMTP id CIwnn6KywSgGFCIwnnHKme; Tue, 25 Jan 2022 11:21:09 +0100 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 213.47.68.29 X-CNFS-Analysis: v=2.3 cv=f8Q2+96M c=1 sm=1 tr=0 a=2hcxjKEKjp0CzLx6oWAm4g==:117 a=2hcxjKEKjp0CzLx6oWAm4g==:17 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=ZZnuYtJkoWoA:10 a=9y7imnrrjsseHGDdguAA:9 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Tue, 25 Jan 2022 11:21:09 +0100 Message-Id: <20220125102109.522-2-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220125102109.522-1-michael@niedermayer.cc> References: <20220125102109.522-1-michael@niedermayer.cc> X-CMAE-Envelope: MS4wfP/BuDeq29rkRmq8uWK9lY0WvV18CvGdsTglGmRlsYD2m9VYtGTkZdFlYP9FrCaa2VrqOMBvaIlvdZ6LXUBaZn5nL4pcHPnniuWF1scc1yN8PRiqZy7n dIYwXo9+hamVRXzrn+lddwYfYkskqhg+lQAMcYaC4if9Gh6ThAQ0Pld0 Subject: [FFmpeg-devel] [PATCH 2/2] libavutil/random_seed: Skip testing generic seed twice X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: stWrZFR32J+D If no platform specific random seed is supported then the generic code was tested twice, this is unneeded Signed-off-by: Michael Niedermayer --- libavutil/random_seed.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/libavutil/random_seed.c b/libavutil/random_seed.c index 509b74936c..a8be2d4991 100644 --- a/libavutil/random_seed.c +++ b/libavutil/random_seed.c @@ -141,5 +141,11 @@ uint32_t av_get_random_seed(void) return seed; if (read_random(&seed, "/dev/random") == sizeof(seed)) return seed; +#if TEST + { // for testing we test get_generic_seed() seperatly so doing it here too is a waste of time + static int x; + return x++; + } +#endif return get_generic_seed(); }