From patchwork Sat Jan 29 01:12:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Jang X-Patchwork-Id: 33899 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6602:2c4e:0:0:0:0 with SMTP id x14csp921319iov; Fri, 28 Jan 2022 17:13:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJz2e6jFrZ3DTLClHc9JQUZxPBP4L4PWfTNJrU+lCvmHynWSy+dyHxz4kmWgNm1Q/dAi1Uu2 X-Received: by 2002:a17:907:6e86:: with SMTP id sh6mr9182533ejc.398.1643418790418; Fri, 28 Jan 2022 17:13:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643418790; cv=none; d=google.com; s=arc-20160816; b=AMzI9c2o21oQ2uU4C3rpM24wQkpITqH6crZALhwk5sFQ50VVHAa1VLLyaLwLslas9z 0WJAW7UObFMQV0pZl5dg7DRqW61tvtIjda6r4SH5Olj2bcvKKCdbV2UJYg5aSjDJQJWB x8T5QWpyk/Z8/Iks6voPKfXIDDkBgeN7aLcLdSBZ90YBqtAInnxAY1Tq+Mr2buTDqxdC fA/ez0NAGZU5DmpWkGe6hF9GVTCOWVZbW+6YMPfoDrPiU/69dNGr/qGHgj6eKaBzyl7V d7XwMWMeQwfMmrh4jUZewJrOVchRkQwxGh0fQQpLCuOafUWUS0+e58IRyG4HicEu5uFy I3uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=YrDfoveDB6C1lFve2m8RJO7a7+yLFBe+hx0f5M0Mdiw=; b=oI2kakQj1q9GZ9bBS13oeQfwMd/MgGEGCOGKT7Q5GUefxOzYP2G8fzMr3A6VQ1Rhvd zgA4Iw4QQKz5CTgBEYcx5kuT15Fo3Qg8DDCUIeLrEjxybcd5fUnyVe86jwe1KpB3K2bR OE6WEB3CNlo+5j7EnoD6VpxeZbQkmqYrYVQMI2FCiZknfQeF1NdwymmS3x5pjhcbW84H cAwblLH4nIZDbsbPrtH1AK2nNj633Xjyc95bKuusJlx0VIIR7nlIpvCM00nRbyYHCV6F Dp2uXheqbrNnvWQt/8K3C1m831K/xWV5pYTUblqBuZzHANN+MnLJxWAtUEA03XXv6epc aHIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=RUFjRORk; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id he17si4134185ejc.161.2022.01.28.17.13.10; Fri, 28 Jan 2022 17:13:10 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=RUFjRORk; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8470E68B1C4; Sat, 29 Jan 2022 03:13:07 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E21ED68AA89 for ; Sat, 29 Jan 2022 03:13:00 +0200 (EET) Received: by mail-pj1-f49.google.com with SMTP id g11-20020a17090a7d0b00b001b2c12c7273so8270233pjl.0 for ; Fri, 28 Jan 2022 17:13:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jyibVgbRYSUlwLaSfB3Co7EZJ4fvwzxJFeYCcpdMk38=; b=RUFjRORkbqlQi9bBJsifcYmC3EmqjKMSIaT/+JywMuMo3JRFjGaILDrv/9OU13BlQO hs2Flp7NYzTjuCvw4bDIJe5GERtPX/d/GWtgtsP7pSxe0mgi813aTfc6jne/27sCUy8S BRsPyddVpFBRgyMEUrTJVSDmtqhg7xD4Rv+pL99rJjx8We3+CaAetAihCOh4Fuo6OIXV cp551sTumBDNpy9ZtqB3VpX5wqIPZKq2JSArt8ac/XW7kp1xwm1XcvYBt3BxY30JQCfP f/xvQoY8w5wdq1MRj2e7FPgP3AfMrgKTQnwHQPiDuTeO7iXCf8mUxYqc6PsRmkxyN9uX 4rTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jyibVgbRYSUlwLaSfB3Co7EZJ4fvwzxJFeYCcpdMk38=; b=V1VNMc6xT4IjAadBwIn/+YgBkg4gamoEQTiG3LdXSrjzmIZ2WKTY1wkSQ6mK4d34vl ZpFTlrw8Tycfip4bDxIKL2i0N37lQx5goiWi+tCTXQ3UXvzB94Y9WSQGm6nNjSjWnYJ4 2btaqcaZwH+//1rRQeWX1Ibz1qIcS92yu2aH5ISVEXHUrFI5Jr99C7W61EgqiP9bbvIL 7XW/Yc/UeJuXIx4Hft2ZlldWAPksoHIt97I8dU1Z9VbwmwMRPnSuvl8dkZF247RA+ynt TmTM+NfDCxVyWq8Ju4zMWG7+08AuK8fu16fCYDTn2FEsUh1WBWr3eiuwTuvN9RNzYPSK xEBw== X-Gm-Message-State: AOAM531t/NjChPLSB4hGrmuZMb9YsNSELFe2e8RvmAwgrNQwma9aLYEm XcIQQsZpSW6uNAVKnxftRQ+kvORfPzhbHQ== X-Received: by 2002:a17:90a:15c9:: with SMTP id w9mr12632607pjd.225.1643418779103; Fri, 28 Jan 2022 17:12:59 -0800 (PST) Received: from ryzen-archlinux.localdomain (node-1w7jr9quwtshe9pluzzjlv6my.ipv6.telus.net. [2001:569:7da8:e800:e2d5:5eff:fe8e:845a]) by smtp.googlemail.com with ESMTPSA id f16sm10098012pfd.118.2022.01.28.17.12.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jan 2022 17:12:58 -0800 (PST) From: Jason Jang To: ffmpeg-devel@ffmpeg.org Date: Fri, 28 Jan 2022 17:12:41 -0800 Message-Id: <20220129011241.308079-1-jcj83429@gmail.com> X-Mailer: git-send-email 2.35.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 2/3] avfilter/af_apsyclip: fix peak overestimation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jason Jang Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: QosGkSDn3Sm8 Ignore more samples that are near the edge of the block. The reason is that the filtering tends to cause these samples to go above the window more than the samples near the middle. If these samples are included in the unwindowed peak estimation, the peak can be overestimated. Because the block is windowed again before overlapping, overshoots near the edge of the block are not very important. 0.1 is the value from the version originally contributed to calf. Signed-off-by: Jason Jang --- libavfilter/af_apsyclip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_apsyclip.c b/libavfilter/af_apsyclip.c index 0bc469c..2a79ed3 100644 --- a/libavfilter/af_apsyclip.c +++ b/libavfilter/af_apsyclip.c @@ -87,7 +87,7 @@ static void generate_hann_window(float *window, float *inv_window, int size) window[i] = value; // 1/window to calculate unwindowed peak. - inv_window[i] = value > 0.01f ? 1.f / value : 0.f; + inv_window[i] = value > 0.1f ? 1.f / value : 0.f; } }