From patchwork Mon Jan 31 13:51:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Gaiser X-Patchwork-Id: 33958 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6602:2c4e:0:0:0:0 with SMTP id x14csp2741254iov; Mon, 31 Jan 2022 05:53:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJxaW/BfmsznqIk/20cxRKo4Mge/KXnDNdGjx+oRbc9L9nc8aOTLcblyVwBQKiivEAGKvA4q X-Received: by 2002:a05:6402:3c6:: with SMTP id t6mr16495175edw.21.1643637227775; Mon, 31 Jan 2022 05:53:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643637227; cv=none; d=google.com; s=arc-20160816; b=ndaVJap+mUculMQOt9/5wbZnvv7SO6+GMTWg3HfS23vdaGo6Ovxg7ctjGsnfqz6g1f hd5ZVefkpt6vm+8HqeIinQSOl35D+lZVWX1WHDziWdm8eNEPkL5OJAzg+YJSkEokKCiB Co7kWzHlvOeQR4jWcX4gJ0yEDaQfsQOyjBqwitFImNlqIlyX0KvSAo6+zpu0JBy9VPJF KisHLicnXQfS3WOZe1ZfoFYIwRNCGV5Gqhq4YJAkaGYgHu7g7uSmejvdB0yqbskyKvC7 eSaBQg8B2HoeTbxfV4ZKgTJMiMDXHpwhbCERHPntiR0HjA19CrlHHqrIpjV3NcZpmTJg 9stw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to; bh=YzLSr7xbK9n7IDXTJvi/nc3D6ybG2a6RjhhWYKtFSF8=; b=s/0ux0nlvHOHv3pU2JiH/OqWbJz0kvKY90A2fwT0rZYMOAWy1kJy67j/MvKwdk+FzI nhHUG5fwaYpaN/nzZfjkoPGJF1FRAXDqdXJi1uOY9nX+XKUBMGPzyLtNyI15ZXEpo8a0 7ElxQK763iD1Gp3j++Rs407st3CbgGy9AljQkntuUZsAJFaZoEWDRGQnzWUBPm39lPJ0 TT+8m+d43ThZk63vaesDJsx0qt2jRjPlixBE+hqGMl7+9gE72Rddh+X62QusZK7SRO10 5s3sU5hUoAfHguNobKYVJBzLDmdMp0fvSbd++BYrGb90UboMNDoJ0OMfgMMIsX6bMJKL ADeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=LAJwKwo2; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id sc11si6976306ejc.113.2022.01.31.05.53.47; Mon, 31 Jan 2022 05:53:47 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=LAJwKwo2; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 65E2068B2A7; Mon, 31 Jan 2022 15:52:52 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 937FD68B027 for ; Mon, 31 Jan 2022 15:52:41 +0200 (EET) Received: by mail-ed1-f50.google.com with SMTP id p12so26924251edq.9 for ; Mon, 31 Jan 2022 05:52:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YeTkI0yDjiPKO61GKrHh/eq/EWi9ieJiC/8idr7dyZY=; b=LAJwKwo2SPNPrY7+W0Pf12dytSdZ7Yo70TYfGE6FMgfarbxEmjkgU7DOl+8nWTMvQV 5gLhpxjoG+zf8o9Q+kYPDTYWb1vu8IKp9G6jquiCHRi3R+UHhDm03m8OzeoNKAYk8K2E jdEqv7ggNH+CZjoM/+2OF1QEm+wjHmuyvqbTKv1kXU1JMpUxIVPFjjeQHUeTkRxxpIY/ AHm1LgjCA3L5bg9yr3HLda6/ZhaqGwJVn2xPDYPjw+xj944ZlAIAesaAyGWe3xEvX/XC vK7i5HuGCG6jcLWlJPoxVRjQ/4MT7a08cgm35z3+oyHIC1G0YdG73nfZpHFGTEgPM/2P 49Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YeTkI0yDjiPKO61GKrHh/eq/EWi9ieJiC/8idr7dyZY=; b=mpicFsePKIT4zxKmogfKpS6XPsapZZ4aV/Ht4P8gNETM0h2W5g2GqKIWk+8VH0Fi1l N3uz2Crd1ebfrgEMJzeyUQaSWDAHPhunRSe4T+WvxxsXL9Lf2H6qo+3bdn+TXFtqPR4+ NN91VXrF/ejNtg/NLxtPCBhLAtDfjkilMVORxS2whkQnI3g15y/soienvFQO4W8dZCaU xD+fsZltUzuSZsr4wVSN31fYf0VVnXncgQZmlaWC00dlr0iQzJfSJgE4Gv20n8oonsx3 SDVkLNDFqufdPJjxcO2rhJfLu7+OkkWIoENzBXP3dOTpk2P6MAkc4o7QdQ9rCgyrAvMa 0/2Q== X-Gm-Message-State: AOAM532jpmA9CwpUnh/3sq2VcC61CFKukfcqmLtV91s2V2w0ha1YTsXf Gjzbxf9wq5RAInAHudqv0j8BqRjjW+VXbQ== X-Received: by 2002:aa7:d94a:: with SMTP id l10mr20733399eds.302.1643637160820; Mon, 31 Jan 2022 05:52:40 -0800 (PST) Received: from localhost.localdomain (ip60-253-211-87.adsl2.static.versatel.nl. [87.211.253.60]) by smtp.gmail.com with ESMTPSA id l19sm5431885ejq.139.2022.01.31.05.52.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 05:52:40 -0800 (PST) From: Mark Gaiser To: ffmpeg-devel@ffmpeg.org Date: Mon, 31 Jan 2022 14:51:16 +0100 Message-Id: <20220131135116.14035-6-markg85@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220131135116.14035-1-markg85@gmail.com> References: <20220131135116.14035-1-markg85@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 5/5] Fix review feedback X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Mark Gaiser Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: V2KIZ5YruAWx Little bit of consistency in punctuations. Signed-off-by: Mark Gaiser --- libavformat/ipfs.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavformat/ipfs.c b/libavformat/ipfs.c index 8f6f91d85d..1644c74eac 100644 --- a/libavformat/ipfs.c +++ b/libavformat/ipfs.c @@ -46,7 +46,7 @@ typedef struct Context { // A best-effort way to find the IPFS gateway. // Only the most appropiate gateway is set. It's not actually requested (http call) to prevent -// potential slowdown in startup. A potential timeout is handled by the HTTP protocol. +// a potential slowdown in startup. A potential timeout is handled by the HTTP protocol. // // When done and the return value is 1, a potential IPFS Gateway is set in the gateway // variable in the inner URLContext. @@ -68,7 +68,7 @@ static int populate_ipfs_gateway(URLContext *h) return 1; } - // Test $IPFS_GATEWAY + // Test $IPFS_GATEWAY. c->gateway = getenv("IPFS_GATEWAY"); if (c->gateway) { return 1; @@ -82,7 +82,7 @@ static int populate_ipfs_gateway(URLContext *h) if (!ipfs_full_data_folder) { av_log(h, AV_LOG_DEBUG, "$IPFS_PATH is empty.\n"); - // Try via the home folder + // Try via the home folder. home_folder = getenv("HOME"); ipfs_full_data_folder = malloc(strlen(home_folder) + strlen(ipfs_data_folder) + 1); strcpy(ipfs_full_data_folder, home_folder); @@ -117,7 +117,7 @@ static int populate_ipfs_gateway(URLContext *h) return -1; } - // Get the contents of the gateway file + // Get the contents of the gateway file. gateway_file = av_fopen_utf8(ipfs_gateway_file, "r"); if (!gateway_file) { av_log(h, AV_LOG_ERROR, "Unable to open the IPFS gateway file (full uri: %s).\n", ipfs_gateway_file); @@ -132,7 +132,7 @@ static int populate_ipfs_gateway(URLContext *h) return -1; } - // Copy the gateway url into c->gateway + // Copy the gateway url into c->gateway. c->gateway = malloc(strlen(gateway_file_data) + 1); strcpy(c->gateway, gateway_file_data); if (c->gateway) { @@ -194,7 +194,7 @@ static int ipfs_open(URLContext *h, const char *uri, int flags, AVDictionary **o goto err; } - // If we have IPNS, update the protocol + // If we have IPNS, update the protocol. if (is_ipns) { protocol_path_suffix = "ipns/"; }