From patchwork Tue Feb 22 16:46:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul B Mahol X-Patchwork-Id: 34451 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6838:d078:0:0:0:0 with SMTP id x24csp18524nkx; Tue, 22 Feb 2022 08:45:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJx1j3H+soqwSe4yWAeVGDRiNVd8yGdrIckfHwiIF8hlmBcBKi4GDZmocuvKFxwqB1uBcegv X-Received: by 2002:a17:906:ad8d:b0:6ae:9bd6:1e9a with SMTP id la13-20020a170906ad8d00b006ae9bd61e9amr20330797ejb.337.1645548330718; Tue, 22 Feb 2022 08:45:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645548330; cv=none; d=google.com; s=arc-20160816; b=PQsmz9RsXNlE74pHa7GwfLcNXwg0EswX1w6FPOiCVOv48EQJhOgw2lSLNOmyyhZEEe 43uLVddq9jK4gEALpUVX9QFgCxXf5PjZkAPkTHrJSNFTTWP97B9ZwCR0LCgUNGOUeFBu THPbAX4PwADrWwt/qBhgrENuoQjRTXJkBUNu7Qa+8WZAVntAEGcM2H/PAwHDCduw9KOO OjKpwXvryx3fbl/52zpsxwTpUPxqsfdJbhKOyJlqBaeq8E2mdAIIZ7pbXvgAK9R0rfX1 ddqne2QN8kHVxtYknKsNbDDcIQB02ZwH6HKsuiEAcJ6KbI0T7Nq+lzGAmgobN+LN+mWK UGZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=4NoO6e/y4zzX5e7SUJSSKpfHuRGKWpRP3apd2xi8pSE=; b=g3STURjX7yvkz8F5hLzFTjWVvCoOFYKuw1hNthDPvqSPtOao1saNHVHSJCiUH0M+jP cIjl4i2kI615edyKgozeBMfNie5mT0kH3JVUfz2Jl12wBF8aB0FKhx4IFmaZOmDM9OOs pG7LCoOTpUnCrhwCRphe2C7qUWxTVun7jdIOxxc80QiV3yvvyQYr5v7pvW9yBST8v4Cj 9ZjRASvol3lOJtAD3qGXvCsrElylv+4wKuMJtRvGQpxK1NDtke4MKBQwaUshdDrs+3UZ sbwe7J5SbIyNC2OR1HnQqE6inAuR+I1nbG+xmIKV82zPUfBQbpWzqVfvCdt8V5eaHVTs yisQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=qnZaFFTg; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id hp30si12297800ejc.600.2022.02.22.08.45.24; Tue, 22 Feb 2022 08:45:30 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=qnZaFFTg; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 513CB687992; Tue, 22 Feb 2022 18:45:00 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 306B268B09C for ; Tue, 22 Feb 2022 18:44:52 +0200 (EET) Received: by mail-ed1-f51.google.com with SMTP id s1so5250267edd.13 for ; Tue, 22 Feb 2022 08:44:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=/aJ3/7ZSh4o2uMzpfCPXLIdnt66P8mUnRIjaiF1It2Q=; b=qnZaFFTgNfhSFSIxBqn+OrLKfvYoYPJs4D683ZsEWkVVzbhOezG6j8XsMGUZtk9yQx EnwZxgIVPPmq8qnyIw0Z21A49e+ndLbPBaBC3t3Qop5+wys7pcqnTFG69ICIgR/ykdFH F0+DxcROVAVt0sTR1GdeX/EFtRezPIE1cY3d2h5QxI+PAEEauCri8JjMr6YYUdLm5gp7 ++/VDUdHhqS7lz6WbkaHMxGu8gRKdpYBvbazxTjltzgEvR1Cmzdq/UDRTsr0rcAzRlB1 rCurDMY22tYBzk+E0l53gHLGCv9UG9xGuJuImZv7iJBkAF99z1jR2YqiRyUMy8q1ikG3 7C8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/aJ3/7ZSh4o2uMzpfCPXLIdnt66P8mUnRIjaiF1It2Q=; b=5DkGNFQ/h9/+bAPmyXIsSANf4xP4BgiBIeGS+z2WdpDrDDiesZW++xwBF2G92MVA5J wVJb0lh0iQTLxQN/ogLhqiIFDbgxK2GW0NingG1U6YmoFlXLzi50Vk92U+T8pzf5SNCS Qkkh5ZNVdDn5ERCmRNAYQjwPudT0fDoxAa7U4ZzEAFGrVQLsEMnGM4g416LRW2rlO800 BDILzh7pSZZPDFTnc6gTLGZfAqNj/DW6OraC8iM+udd4GSquSQu66mDnVuu1OLgdDdI8 jZrx4wqq5ykfkkweH7SNr9rxQjmnWcbKWSeyKksMKE0Zq/rSUU7Y6KAjeoXpyNdgJuXg q5qw== X-Gm-Message-State: AOAM530IASuF76+ym0/QIFPvOesEQmg7Y+uUog1wanPydto6d1ySrdGh PFS0AjTlVIt3Chc9stijKfKoW9jFTfQ= X-Received: by 2002:a50:f686:0:b0:403:cd5b:7d6a with SMTP id d6-20020a50f686000000b00403cd5b7d6amr26862015edn.189.1645548291498; Tue, 22 Feb 2022 08:44:51 -0800 (PST) Received: from localhost.localdomain ([212.15.177.16]) by smtp.gmail.com with ESMTPSA id g11sm6635938ejs.14.2022.02.22.08.44.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 08:44:51 -0800 (PST) From: Paul B Mahol To: ffmpeg-devel@ffmpeg.org Date: Tue, 22 Feb 2022 17:46:16 +0100 Message-Id: <20220222164616.511012-3-onemda@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20220222164616.511012-1-onemda@gmail.com> References: <20220222164616.511012-1-onemda@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 3/3] avfilter/af_loudnorm: remove hard clipping of samples X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 9nXN2Ls8BJoX It can cause unpleasant artifacts. Signed-off-by: Paul B Mahol --- libavfilter/af_loudnorm.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/libavfilter/af_loudnorm.c b/libavfilter/af_loudnorm.c index 7c8ac3a39d..9bb0c65bb7 100644 --- a/libavfilter/af_loudnorm.c +++ b/libavfilter/af_loudnorm.c @@ -394,12 +394,8 @@ static void true_peak_limiter(LoudNormContext *s, double *out, int nb_samples, i } while (smp_cnt < nb_samples); for (n = 0; n < nb_samples; n++) { - for (c = 0; c < channels; c++) { + for (c = 0; c < channels; c++) out[c] = buf[index + c]; - if (fabs(out[c]) > ceiling) { - out[c] = ceiling * (out[c] < 0 ? -1 : 1); - } - } out += channels; index += channels; if (index >= s->limiter_buf_size)