From patchwork Tue Mar 15 21:18:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marton Balint X-Patchwork-Id: 34786 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6838:3486:0:0:0:0 with SMTP id ek6csp3356399nkb; Tue, 15 Mar 2022 14:19:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9M3QJ+W3zRqXjxx2ypF12JaU7OMrEtFF8A9aG/vNvg8Wwv0pMd5XDJgSdrXoFQeyYAUJA X-Received: by 2002:a17:907:7f1f:b0:6da:7d72:1352 with SMTP id qf31-20020a1709077f1f00b006da7d721352mr23894536ejc.225.1647379168469; Tue, 15 Mar 2022 14:19:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647379168; cv=none; d=google.com; s=arc-20160816; b=i4rBDFGxwzhNup2cUj8fgouB/qmdFQDbEj+cAQH8nDh1MtxHrkFuIGC8kK2du70mK6 8bBBKPGZb9sTWcaEbpLHLYRDn0OnMyZQ3lZiQ9dcHvJxZCXBAH/sAanRZajE0patwLw4 ueax1gZLbV64K9EzUrQQivA8T0Di/8An4hNs0G9LSMb3HkIy9e4d4/CV/aYQH0yy6CYC gsuf9/c5RxfPwaVvJm44ipM1RfZFUh9luN4bPjlJLmgWPFwOGCfD/0m+eQ4XAlVnpwTw d0iwCM3mpVYDKjQZamHFPfxJ+gb5q1jxsAPq4L6F2kbXgDhCnG6BvH3dp0bt1e0S13MC RxKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:delivered-to; bh=k3mLR8Tm75SFpQRwQt5w71Mh4biDPNdJRqc0/6C4gto=; b=YRpYg9g58ITpEe6Ae6PFJoBuOxcU/o8JphyBDhPAEOxlfsco7Bw7lsR1pHRkjy7M/y tOFn1UrKHVQz2FS0f/whOvf+Azr7aBauYftpm3JTkZpVxNKMfLflE3KQMIU8XfYNsGtW hR3gCMMU7M24uUGD7OSuuOtKXG+/7JKpWB49WQ+a8lsiyomzLGaJ7/LiaVaCFsGTc2Y1 5YZCJ1BIJ/oqtak+nGk9HSPsGK1XCgTtyb8hG5+YbKu/jzlR7UeRfMWjoZO5RngLl1kj Kpwf2c4cZBZq7R8TkLZmemQBsEBwa8HHarajrYPZ7FncJahAKiuiQSqWU5f5MKYafCyT S7hw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id be21-20020a0564021a3500b00416bf8f0261si132261edb.215.2022.03.15.14.19.28; Tue, 15 Mar 2022 14:19:28 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 468EF68B120; Tue, 15 Mar 2022 23:19:21 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E4E1468019F for ; Tue, 15 Mar 2022 23:19:14 +0200 (EET) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id 53A9AE12AE; Tue, 15 Mar 2022 22:19:15 +0100 (CET) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AxXVj5WIKJLk; Tue, 15 Mar 2022 22:19:14 +0100 (CET) Received: from bluegene.passwd.hu (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id E1B44E5466; Tue, 15 Mar 2022 22:19:13 +0100 (CET) From: Marton Balint To: ffmpeg-devel@ffmpeg.org Date: Tue, 15 Mar 2022 22:18:56 +0100 Message-Id: <20220315211858.26800-2-cus@passwd.hu> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220315211858.26800-1-cus@passwd.hu> References: <1382f5bd-673f-f429-0ce9-ce39c3f9b586@gmail.com> <20220315211858.26800-1-cus@passwd.hu> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2 2/4] avutil/channel_layout: factorize ambisonic order detection X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Marton Balint Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: wXtsq9hlavzi Signed-off-by: Marton Balint --- libavutil/channel_layout.c | 42 +++++++++++++++++++++++++++----------- libavutil/channel_layout.h | 1 + 2 files changed, 31 insertions(+), 12 deletions(-) diff --git a/libavutil/channel_layout.c b/libavutil/channel_layout.c index c60ccf368f..0069c6257b 100644 --- a/libavutil/channel_layout.c +++ b/libavutil/channel_layout.c @@ -644,29 +644,31 @@ int av_channel_layout_copy(AVChannelLayout *dst, const AVChannelLayout *src) } /** - * If the custom layout is n-th order standard-order ambisonic, with optional - * extra non-diegetic channels at the end, write its string description in bp. - * Return a negative error code on error. + * If the layout is n-th order standard-order ambisonic, with optional + * extra non-diegetic channels at the end, return the order. + * Return a negative error code otherwise. */ -static int try_describe_ambisonic(AVBPrint *bp, const AVChannelLayout *channel_layout) +static int ambisonic_order(const AVChannelLayout *channel_layout) { int i, highest_ambi, order; highest_ambi = -1; - if (channel_layout->order == AV_CHANNEL_ORDER_AMBISONIC) + if (channel_layout->order == AV_CHANNEL_ORDER_AMBISONIC) { highest_ambi = channel_layout->nb_channels - av_popcount64(channel_layout->u.mask) - 1; - else { + } else { const AVChannelCustom *map = channel_layout->u.map; + av_assert0(channel_layout->order == AV_CHANNEL_ORDER_CUSTOM); + for (i = 0; i < channel_layout->nb_channels; i++) { int is_ambi = CHAN_IS_AMBI(map[i].id); /* ambisonic following non-ambisonic */ if (i > 0 && is_ambi && !CHAN_IS_AMBI(map[i - 1].id)) - return 0; + return AVERROR(EINVAL); /* non-default ordering */ if (is_ambi && map[i].id - AV_CHAN_AMBISONIC_BASE != i) - return 0; + return AVERROR(EINVAL); if (CHAN_IS_AMBI(map[i].id)) highest_ambi = i; @@ -674,17 +676,33 @@ static int try_describe_ambisonic(AVBPrint *bp, const AVChannelLayout *channel_l } /* no ambisonic channels*/ if (highest_ambi < 0) - return 0; + return AVERROR(EINVAL); order = floor(sqrt(highest_ambi)); /* incomplete order - some harmonics are missing */ if ((order + 1) * (order + 1) != highest_ambi + 1) + return AVERROR(EINVAL); + + return order; +} + +/** + * If the custom layout is n-th order standard-order ambisonic, with optional + * extra non-diegetic channels at the end, write its string description in bp. + * Return a negative error code on error. + */ +static int try_describe_ambisonic(AVBPrint *bp, const AVChannelLayout *channel_layout) +{ + int nb_ambi_channels; + int order = ambisonic_order(channel_layout); + if (order < 0) return 0; av_bprintf(bp, "ambisonic %d", order); /* extra channels present */ - if (highest_ambi < channel_layout->nb_channels - 1) { + nb_ambi_channels = (order + 1) * (order + 1); + if (nb_ambi_channels < channel_layout->nb_channels) { AVChannelLayout extra = { 0 }; char buf[128]; @@ -696,12 +714,12 @@ static int try_describe_ambisonic(AVBPrint *bp, const AVChannelLayout *channel_l const AVChannelCustom *map = channel_layout->u.map; extra.order = AV_CHANNEL_ORDER_CUSTOM; - extra.nb_channels = channel_layout->nb_channels - highest_ambi - 1; + extra.nb_channels = channel_layout->nb_channels - nb_ambi_channels; extra.u.map = av_calloc(extra.nb_channels, sizeof(*extra.u.map)); if (!extra.u.map) return AVERROR(ENOMEM); - memcpy(extra.u.map, &map[highest_ambi + 1], + memcpy(extra.u.map, &map[nb_ambi_channels], sizeof(*extra.u.map) * extra.nb_channels); } diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h index 4dd6614de9..294e8b0773 100644 --- a/libavutil/channel_layout.h +++ b/libavutil/channel_layout.h @@ -27,6 +27,7 @@ #include "version.h" #include "attributes.h" +#include "avassert.h" /** * @file