diff mbox series

[FFmpeg-devel] avutil/attributes: add support for clang in AV_NOWARN_DEPRECATED

Message ID 20220316140434.7557-1-jamrial@gmail.com
State Accepted
Commit 8ddf1795b96d6176b0ddcd4693c28a3da9b2ac50
Headers show
Series [FFmpeg-devel] avutil/attributes: add support for clang in AV_NOWARN_DEPRECATED | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_aarch64_jetson success Make finished
andriy/make_fate_aarch64_jetson success Make fate finished
andriy/make_armv7_RPi4 success Make finished
andriy/make_fate_armv7_RPi4 success Make fate finished

Commit Message

James Almer March 16, 2022, 2:04 p.m. UTC
Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavutil/attributes.h | 2 +-
 libavutil/version.h    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Martin Storsjö March 16, 2022, 2:18 p.m. UTC | #1
On Wed, 16 Mar 2022, James Almer wrote:

> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
> libavutil/attributes.h | 2 +-
> libavutil/version.h    | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavutil/attributes.h b/libavutil/attributes.h
> index 5cb9fe3452..04c615c952 100644
> --- a/libavutil/attributes.h
> +++ b/libavutil/attributes.h
> @@ -110,7 +110,7 @@
>  * scheduled for removal.
>  */
> #ifndef AV_NOWARN_DEPRECATED
> -#if AV_GCC_VERSION_AT_LEAST(4,6)
> +#if AV_GCC_VERSION_AT_LEAST(4,6) || defined(__clang__)
> #    define AV_NOWARN_DEPRECATED(code) \
>         _Pragma("GCC diagnostic push") \
>         _Pragma("GCC diagnostic ignored \"-Wdeprecated-declarations\"") \
> diff --git a/libavutil/version.h b/libavutil/version.h
> index d9d0e0564b..6735c20090 100644
> --- a/libavutil/version.h
> +++ b/libavutil/version.h
> @@ -80,7 +80,7 @@
>
> #define LIBAVUTIL_VERSION_MAJOR  57
> #define LIBAVUTIL_VERSION_MINOR  24
> -#define LIBAVUTIL_VERSION_MICRO 100
> +#define LIBAVUTIL_VERSION_MICRO 101
>
> #define LIBAVUTIL_VERSION_INT   AV_VERSION_INT(LIBAVUTIL_VERSION_MAJOR, \
>                                                LIBAVUTIL_VERSION_MINOR, \
> -- 
> 2.35.1

This seems to work for me, tested with a recent Apple Clang. (The number 
of build warnings drop by 2 when this is applied.)

// Martin
James Almer March 16, 2022, 3:30 p.m. UTC | #2
On 3/16/2022 11:18 AM, Martin Storsjö wrote:
> On Wed, 16 Mar 2022, James Almer wrote:
> 
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>> libavutil/attributes.h | 2 +-
>> libavutil/version.h    | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavutil/attributes.h b/libavutil/attributes.h
>> index 5cb9fe3452..04c615c952 100644
>> --- a/libavutil/attributes.h
>> +++ b/libavutil/attributes.h
>> @@ -110,7 +110,7 @@
>>  * scheduled for removal.
>>  */
>> #ifndef AV_NOWARN_DEPRECATED
>> -#if AV_GCC_VERSION_AT_LEAST(4,6)
>> +#if AV_GCC_VERSION_AT_LEAST(4,6) || defined(__clang__)
>> #    define AV_NOWARN_DEPRECATED(code) \
>>         _Pragma("GCC diagnostic push") \
>>         _Pragma("GCC diagnostic ignored \"-Wdeprecated-declarations\"") \
>> diff --git a/libavutil/version.h b/libavutil/version.h
>> index d9d0e0564b..6735c20090 100644
>> --- a/libavutil/version.h
>> +++ b/libavutil/version.h
>> @@ -80,7 +80,7 @@
>>
>> #define LIBAVUTIL_VERSION_MAJOR  57
>> #define LIBAVUTIL_VERSION_MINOR  24
>> -#define LIBAVUTIL_VERSION_MICRO 100
>> +#define LIBAVUTIL_VERSION_MICRO 101
>>
>> #define LIBAVUTIL_VERSION_INT   AV_VERSION_INT(LIBAVUTIL_VERSION_MAJOR, \
>>                                                LIBAVUTIL_VERSION_MINOR, \
>> -- 
>> 2.35.1
> 
> This seems to work for me, tested with a recent Apple Clang. (The number 
> of build warnings drop by 2 when this is applied.)

How 2? AV_NOWARN_DEPRECATED is currently used in a single place.

Pushed, thanks.

> 
> // Martin
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/libavutil/attributes.h b/libavutil/attributes.h
index 5cb9fe3452..04c615c952 100644
--- a/libavutil/attributes.h
+++ b/libavutil/attributes.h
@@ -110,7 +110,7 @@ 
  * scheduled for removal.
  */
 #ifndef AV_NOWARN_DEPRECATED
-#if AV_GCC_VERSION_AT_LEAST(4,6)
+#if AV_GCC_VERSION_AT_LEAST(4,6) || defined(__clang__)
 #    define AV_NOWARN_DEPRECATED(code) \
         _Pragma("GCC diagnostic push") \
         _Pragma("GCC diagnostic ignored \"-Wdeprecated-declarations\"") \
diff --git a/libavutil/version.h b/libavutil/version.h
index d9d0e0564b..6735c20090 100644
--- a/libavutil/version.h
+++ b/libavutil/version.h
@@ -80,7 +80,7 @@ 
 
 #define LIBAVUTIL_VERSION_MAJOR  57
 #define LIBAVUTIL_VERSION_MINOR  24
-#define LIBAVUTIL_VERSION_MICRO 100
+#define LIBAVUTIL_VERSION_MICRO 101
 
 #define LIBAVUTIL_VERSION_INT   AV_VERSION_INT(LIBAVUTIL_VERSION_MAJOR, \
                                                LIBAVUTIL_VERSION_MINOR, \