From patchwork Mon Mar 21 20:19:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 34882 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6838:ed11:0:0:0:0 with SMTP id hi17csp1960658nkc; Mon, 21 Mar 2022 13:21:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwgALqsAdj8IOmjW+l897DymEJy87xSDJ4dOAYCj3Kd+tkiyzsYvSlZrqpxs9dN2cQOvHSW X-Received: by 2002:a17:907:97c7:b0:6da:b3ba:6d9f with SMTP id js7-20020a17090797c700b006dab3ba6d9fmr22881545ejc.256.1647894081570; Mon, 21 Mar 2022 13:21:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647894081; cv=none; d=google.com; s=arc-20160816; b=PgG7sysf7CXt4GdTV8b1twRm4ASd6VLH1y6VG/H1lWBIaK++lexHMndTc7YNGn5ijD dw7L24py8pcXKKtxWfst/lBNZluoo2obZF74ZREyBz6GGOWjcL1bYLBK4uhLldxaYbce EOhfPN90+6HX+TsqKtMToXfMfZeDJ/5uSIvVl5bhprxSIQ2FLGp4vKFbWEZTqC9KcD4/ shXsZg0xhaEBffE+iFs10bsB0EIJktgKau5sfcKgp9/VdDLPcMsNj0XC/36Eo50OdGa+ Kv0BdUS5B3NUw3W6BsIcqrWIu1S+JHd6dXx2ZO1Y3HKxqnGePoe6veq+8WImwKE6HOK0 cJoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:delivered-to; bh=05uxnGCwfxdkfCg3wn5m5vqEjeFTJ4eCsqLzi1AmzZk=; b=qzHXg+RUR/yuQ0JGPOBSYwV00/exb4n2KI1SgLmcJBpC1/30+9pYsUi3TZlS3lPIr2 LXiy0pr7KZsKrGr9zF/agVKhTC7qvEkSn+SX9yKKN6FJaRDyD9zh4zuO0rWqemT8SbrT 83W9BB+ApgKmdhRT+/DSlKkk4bFfLNqXi8waOTJ+2puOClewL6YaAgvWHuC98NA1RdAV gh9Z9Q6aA7dCPrQqtNI1b9Hl/cUJEAdQFLRwhYQZM/lZrRXcyvOJtoA+IvgO1n36eLaw 33TbY/9NGT3dJWOJPygPsX8u4XqJmyyY32bl8fCubu5MpzQhJtk32zHj0T6SGZPKTvG/ 2bHw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id bw2-20020a170906c1c200b006df76385e40si7631033ejb.736.2022.03.21.13.21.21; Mon, 21 Mar 2022 13:21:21 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5C76D68B143; Mon, 21 Mar 2022 22:21:11 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-dmta-at03-3.mx.upcmail.net (vie01a-dmta-at03-3.mx.upcmail.net [62.179.121.153]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7C43C68AF34 for ; Mon, 21 Mar 2022 22:21:03 +0200 (EET) Received: from [172.31.216.235] (helo=vie01a-pemc-psmtp-pe12.mail.upcmail.net) by vie01a-dmta-at03.mx.upcmail.net with esmtp (Exim 4.92) (envelope-from ) id 1nWOWV-0002v1-57 for ffmpeg-devel@ffmpeg.org; Mon, 21 Mar 2022 21:21:03 +0100 Received: from ren-mail-psmtp-mg01. ([80.109.253.241]) by vie01a-pemc-psmtp-pe12.mail.upcmail.net with ESMTP id WOVmncjdBSgGFWOWVnNAan; Mon, 21 Mar 2022 21:21:03 +0100 Received: from localhost ([213.47.68.29]) by ren-mail-psmtp-mg01. with ESMTP id WOVInVhDbOPqFWOVInJl7T; Mon, 21 Mar 2022 21:19:48 +0100 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 213.47.68.29 X-CNFS-Analysis: v=2.4 cv=OcX7sjfY c=1 sm=1 tr=0 ts=6238ddf2 a=2hcxjKEKjp0CzLx6oWAm4g==:117 a=2hcxjKEKjp0CzLx6oWAm4g==:17 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=ZZnuYtJkoWoA:10 a=NEAV23lmAAAA:8 a=IJxozggTPz9AYRMQTaoA:9 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Mon, 21 Mar 2022 21:19:45 +0100 Message-Id: <20220321201946.16919-4-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220321201946.16919-1-michael@niedermayer.cc> References: <20220321201946.16919-1-michael@niedermayer.cc> X-CMAE-Envelope: MS4wfKH3XT/GAoipflDQbUD5paxHMRtRRiGJPlSG06RdRt3aHfKe8xLXfMLtp+zeIgB4Xv+DcOYplhSjH74kRVH03tqE011dcDwn9Cnumw60FXEFv392o1r/ tufZibxenBswwVdK1v3NJiI4RZ/GLgnr6JSCzCT4ETunA8O7OXVNCeuOJr7dO4adfDjZTap43VLFXg== Subject: [FFmpeg-devel] [PATCH 4/5] avcodec/diracdec: avoid signed integer overflow in global mv X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: NjYZQizBgW5R Fixes: signed integer overflow: -128275513086 * -76056576 cannot be represented in type 'long' Fixes: 45818/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-5129799149944832 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/diracdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/diracdec.c b/libavcodec/diracdec.c index d5c095c689..12f97feb6b 100644 --- a/libavcodec/diracdec.c +++ b/libavcodec/diracdec.c @@ -1433,8 +1433,8 @@ static void global_mv(DiracContext *s, DiracBlock *block, int x, int y, int ref) int *c = s->globalmc[ref].perspective; int64_t m = (1<u.mv[ref][0] = (mx + (1<<(ez+ep))) >> (ez+ep); block->u.mv[ref][1] = (my + (1<<(ez+ep))) >> (ez+ep);