From patchwork Fri Mar 25 14:10:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Diederick C. Niehorster" X-Patchwork-Id: 34973 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:ab0:5fda:0:0:0:0:0 with SMTP id g26csp1376863uaj; Fri, 25 Mar 2022 07:13:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxkJH2o9yyrh1/mdguStua/Qi1V6JmYa6POSg9rHnBhdgnOdQ14THhmnicWqjsOdCGSvqru X-Received: by 2002:aa7:d7c1:0:b0:419:2f7e:178d with SMTP id e1-20020aa7d7c1000000b004192f7e178dmr13471549eds.136.1648217605868; Fri, 25 Mar 2022 07:13:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648217605; cv=none; d=google.com; s=arc-20160816; b=C3EuVZBMgiKCawHbMI7aEWblgRsmuX4t/iCLYrT5h94oOnKK5RiGCdf553a1StOi1D Si01zrojXNg+7oVj4zNgyclXWb9F9sHEaZiVJEDD6Slkd9COZFeocWbGOYKKRtEhcj3c hO1iS96J3q7bZKc5ZAkhE7BZpuxG5pJI2MCSinN97ctPfF6qKjC6GH99wfLohFpb3ete DdAo3Mkvs9AtyAwausPhyMTguMshh4n29qrP+KNO4MN+0FBCWbDx/7MHuVUGSezzqvSF oXptQJ52+BZOXX8O8Aij3VP+i2A1IN8U3BWNtx17HJyzBcJDA/jnT1EpuMzOrWCq2Z7k Tyrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to; bh=2A9pYbmgm0RCt3SMzrDK2Ugo0q/WIudAQ0Sr0wkSgKo=; b=MecWXuF+bytZzlPdvdHVwH8bqYz27uPvsi+IX0Crgd4GW/5gadMn721GbNJXYxXZQu aG0jBqSif/7r/1RTda0kyBdjAflMPAWVDhJloyJ2aLghYrOAuiAeuC1bBUn7PqTzVrm/ 5wYZeCk2jF0LUgThR+mLRGQslunwXNiW0qgvqUDjqBQUCfYw3Qw0W2ksD8MwLxiludWE vtacNsePCqX7rmr0qXlQSz8COubB1lAXYi9xw2S7xx9DPrZP1/tZVDmFgCerI+bX1ZAQ zm4QgG7cfdHaCtnJVOK8xwW8QvvbSmltZ8Yjmlrew5famMi7/x5gPstfDUFnMsvsvHc+ xztA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=gNLOjYPO; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id u16-20020aa7d890000000b00418c2b5bea0si2798765edq.386.2022.03.25.07.13.25; Fri, 25 Mar 2022 07:13:25 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=gNLOjYPO; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E73D868B284; Fri, 25 Mar 2022 16:12:21 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D099368B26E for ; Fri, 25 Mar 2022 16:12:20 +0200 (EET) Received: by mail-lj1-f181.google.com with SMTP id q5so10470117ljb.11 for ; Fri, 25 Mar 2022 07:12:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=e67rJjxL3/70KyO3YUb1luBz3oVKcQTD1Fo5/Lm7BoY=; b=gNLOjYPO4ynljmPWzagBFpIHok3mH6H0L9FkL6s4k9RnnegjebfMRO77uKMFwVILrx DxRJruFO7TQDjAeAJycmwe3GYF9Hu9BnaPiGM4sObbbH572Pob120LTTV6KcljJUMW7L Zxwaw9LAWGBJPALvMRHZsfC3R0ueKsxUAifGgCBmRZWRB7QXWe7JtYMTxCI6Im6ZWTmf vLkGzLeGz25LcAOyA9VEmbAS0zSO3wFUeY8VSZIAyfl9OijjCUKS9w40Syb5JCa1UpjG J58WLH+ac/uB8pD+fN9AH1Es8TtxO+UzgmHDA5oT5NiM2FsHRZEzNndE+TooYRR/8mXT hBMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=e67rJjxL3/70KyO3YUb1luBz3oVKcQTD1Fo5/Lm7BoY=; b=P370d2o5yP4SsVlj5+mKTxRlupSk6ow22DmKL1c+1aK1dyCD960033h+x6rrsN+yeQ OzgcCvVcAN53pwSVtZZw9ErBmmRXuBbK05f/De78kNNscAvh1ndry55Tz24I+kFT8r+h +rTx6wNBKCY28yYjirOMOy3TnY02zkSZcu9NbPpzA3uZllrzQ8d18W4iB9wmcZ26I9I8 Ut7F0rM6JHXXofg4MJreBq0+xj536hk6GacmCT1dJNrE3LFKH9IwquU7F6VQJCj1SKUq ubNi/RlvNfTQsFn9WPH9lByL0fm9MyPqFS2SfGLzG6Ho7xOX0a4BUo5b/qGt95sD1ovJ q70Q== X-Gm-Message-State: AOAM531mAhErBvCew0Tfg48fWRI/rgET3mYvXF+8zr+48e91HaXZNlZp DRBZeGWM5VWko90Ce3sEcSaanzsdeqg= X-Received: by 2002:a05:651c:1024:b0:249:bab3:f3fa with SMTP id w4-20020a05651c102400b00249bab3f3famr1768719ljm.337.1648217539659; Fri, 25 Mar 2022 07:12:19 -0700 (PDT) Received: from localhost.localdomain (deedock.humlab.lu.se. [130.235.135.183]) by smtp.gmail.com with ESMTPSA id t5-20020ac25485000000b0044833ffc127sm717920lfk.185.2022.03.25.07.12.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 07:12:19 -0700 (PDT) From: Diederick Niehorster To: ffmpeg-devel@ffmpeg.org Date: Fri, 25 Mar 2022 15:10:30 +0100 Message-Id: <20220325141041.1748-12-dcnieho@gmail.com> X-Mailer: git-send-email 2.28.0.windows.1 In-Reply-To: <20220325141041.1748-1-dcnieho@gmail.com> References: <20220325141041.1748-1-dcnieho@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v4 11/22] avutil/opt: document AVOptionRange min_value > max_value X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Diederick Niehorster Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 4OOygy0lGJ2f AVOptionRange needs a way to encode that an option is not set. Here i provide a documentation solution. When a range is invalid (value_min > value_max), it should be considered unset/value not available. When querying a range of formats of an avdevice, sometimes for a given format the queried option is not available. This is not an error as the user is asking for a valid capability, it just doesn't always apply to all the matching formats of the device. This cannot be communicated through a single special value (like 0 or -1) as that has the same problem asany special value solution. Documenting that an invalid range means value not available allows communicating this situation without adding a field to the AVOptionRange struct. This further documents that an AVOptionRange denotes a single value when value_min == value_max, and a range only when value_max > value_min. This makes the is_range field superfluous. Signed-off-by: Diederick Niehorster --- libavutil/opt.c | 2 +- libavutil/opt.h | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index 8ffb10449b..ebffbb2f36 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -1979,9 +1979,9 @@ int av_opt_query_ranges_default(AVOptionRanges **ranges_arg, void *obj, const ch ranges->range[0] = range; ranges->nb_ranges = 1; ranges->nb_components = 1; - range->is_range = 1; range->value_min = field->min; range->value_max = field->max; + range->is_range = field->max > field->min; switch (field->type) { case AV_OPT_TYPE_BOOL: diff --git a/libavutil/opt.h b/libavutil/opt.h index 461b5d3b6b..4e7d7433e9 100644 --- a/libavutil/opt.h +++ b/libavutil/opt.h @@ -316,6 +316,11 @@ typedef struct AVOptionRange { * Value range. * For string ranges this represents the min/max length. * For dimensions this represents the min/max pixel count or width/height in multi-component case. + * If value_min < value_max, the struct encodes a range. + * If value_min == value_max, the struct encodes a single value. + * If value_min > value_max, the range is empty (a value is not available). + * Good sentinel values to use when a range is empty + * are value_min=0, value_max=-1, but this is not required. */ double value_min, value_max; /**