From patchwork Tue Mar 29 21:24:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 35049 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:c05:b0:7a:e998:b410 with SMTP id bw5csp489700pzb; Tue, 29 Mar 2022 14:25:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz6IQI6XNcIRoCZdrMWEpJhg3ODNi1i6eqI/DDSCBNVwuiAd4DeQbaRkJlaNjMFA8EX0Kmm X-Received: by 2002:a05:6402:5210:b0:419:d802:626e with SMTP id s16-20020a056402521000b00419d802626emr7218386edd.11.1648589132111; Tue, 29 Mar 2022 14:25:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648589132; cv=none; d=google.com; s=arc-20160816; b=ZgZ4ngsNyF4PDJ2grz/T7MJnyAyH7wXNNaAw3KKuLEIKoYqA1Le9ZvDMT3D7u+6RjX gBsmLu604Zm0PR4h03QGNWtg/khRjn2jC4pD2MiqnzDsJzrjgMbVJfZfipepcr1wNBe1 5QYTUYZQxgE1Mh8Cgco4vD4WU9U1Kmv3+wAlPMJLeKVOugW1k9T1yqbBf6AzX79k+CyB IgrhSlqhFpXi37S7Opws7GlE9x6XObdewD6zT+h3hh8KVcfd24CKVl0M27GfM5Xw0k0c j+l5P8htakmW6NFBhQVm7+QsMnh6sMLXllwikiy+Ezf/DAVE6tFrEEPXJ6mLKrpHbXA3 bwDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:delivered-to; bh=uceWNEebBO9o7Wo5uCSscwpIe8m7ZI7lGk+C8baO0Qw=; b=Ljc5LAUZGUTJBjgaGN2h2Uve+dPJiIg4apIukeduuxl6a5be7FG7UYyIT+7jmzDuXU VeeOCsjVJo98bgqHQ0X+9F2EVrH5s9Y/ghh/vCFWAV3CxZzVu9FCWuCftprEWZ7uPcsX t2oJQqaXc1WGl9jW3nZ7PH0Nz6nK2PkweiQ0qv0ctd3i5twMqtf5im0QWyZl0tv9MEh+ Gy5V8K/jhVHLy1uha313l5B6BW5AZ/AD9G7FYfeHr6aCgzHXrmCtdksyCvpn8rL9oSol kTqVN8u9MTxrALGKiLx7R4IcTLWaAm3v/S6iVbtDXMw3iQ6aDG1YT16UMayq4uFl4+rQ Pemw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id sd41-20020a1709076e2900b006dfdad1274fsi4391300ejc.709.2022.03.29.14.25.31; Tue, 29 Mar 2022 14:25:32 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5B51F68B151; Wed, 30 Mar 2022 00:25:29 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-dmta-at03-3.mx.upcmail.net (vie01a-dmta-at03-3.mx.upcmail.net [62.179.121.153]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B8E6468AFD2 for ; Wed, 30 Mar 2022 00:25:22 +0300 (EEST) Received: from [172.31.216.235] (helo=vie01a-pemc-psmtp-pe12.mail.upcmail.net) by vie01a-dmta-at03.mx.upcmail.net with esmtp (Exim 4.92) (envelope-from ) id 1nZJL1-0004vQ-CW for ffmpeg-devel@ffmpeg.org; Tue, 29 Mar 2022 23:25:15 +0200 Received: from ren-mail-psmtp-mg02. ([80.109.253.241]) by vie01a-pemc-psmtp-pe12.mail.upcmail.net with ESMTP id ZJKKnnaW4SgGFZJL1niOfA; Tue, 29 Mar 2022 23:25:15 +0200 Received: from localhost ([213.47.68.29]) by ren-mail-psmtp-mg02. with ESMTP id ZJKln45YB8eSWZJKln4x65; Tue, 29 Mar 2022 23:25:00 +0200 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 213.47.68.29 X-CNFS-Analysis: v=2.4 cv=KKE5sHJo c=1 sm=1 tr=0 ts=6243793b a=2hcxjKEKjp0CzLx6oWAm4g==:117 a=2hcxjKEKjp0CzLx6oWAm4g==:17 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=ZZnuYtJkoWoA:10 a=NEAV23lmAAAA:8 a=GJtpPpMjsyZxrEmgePEA:9 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Tue, 29 Mar 2022 23:24:59 +0200 Message-Id: <20220329212459.23440-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 X-CMAE-Envelope: MS4wfER3xHCD0edM4eD0qqzSYP2oZATO+AllbHVbDINtU1vt5D91Cfe/JC8VdY+KPws+mujI5upFk5HMNrSeGWhX22Pe6kDwfin9N4b74dWT5DkAQXzCgFX/ gMuclbO7s6PNYtlwahQGvhuRDuPG+VIyeDmfMVOBD0gzunFBwW1t0lvdACF/+EaAevxnMA+0tmmEjg== Subject: [FFmpeg-devel] [PATCH] avcodec/pcm_rechunk_bsf: unref packet before putting a new one in X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: j24fN3nw7adj Fixes: memleak Fixes: 45982/clusterfuzz-testcase-minimized-ffmpeg_BSF_PCM_RECHUNK_fuzzer-5562089618407424 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/pcm_rechunk_bsf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/pcm_rechunk_bsf.c b/libavcodec/pcm_rechunk_bsf.c index 108d9e90b9..3f43934fe9 100644 --- a/libavcodec/pcm_rechunk_bsf.c +++ b/libavcodec/pcm_rechunk_bsf.c @@ -153,6 +153,7 @@ static int rechunk_filter(AVBSFContext *ctx, AVPacket *pkt) } } + av_packet_unref(s->in_pkt); ret = ff_bsf_get_packet_ref(ctx, s->in_pkt); if (ret == AVERROR_EOF && s->out_pkt->size) { if (s->pad) {