From patchwork Wed Mar 30 20:42:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthieu Bouron X-Patchwork-Id: 35093 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:c05:b0:7a:e998:b410 with SMTP id bw5csp1015012pzb; Wed, 30 Mar 2022 13:43:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxKj9Zd0DAYqdpYk3tIv6YChVWzOFgyW7mZQdX5l4++TnIQc2nfVSrgKAMF6uSkUEfucd5X X-Received: by 2002:aa7:da1a:0:b0:419:b08:476f with SMTP id r26-20020aa7da1a000000b004190b08476fmr12854823eds.281.1648672991561; Wed, 30 Mar 2022 13:43:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648672991; cv=none; d=google.com; s=arc-20160816; b=KEH4WqONtmA/QB8/PDo9pEiTV8Su7sjBrCwDrdQ+Q3a96vy//e8UYYUGj/vX4m4HWt q0Oy2tZFdxzjEFOreYjWdqMHU3kQe39fs0hyaJr/96GQ0ziaDxex42Y80SLinhgGLV3n FVf28iet6IIffVAOYHfriQocxKgcoMxO9VrgfZWoMXLBjNOjp8bAMv2781aUOkBbusZk OghamvNt0/QFKyCRFJSNo+TK2fdaMOBYw2No/psaCMZwA44I6T5HPM3h3QSEJxG/8IU5 nfSBnU9hJTwVQL4M2iTd2WNZ8kA/gWvywRkuBVQBTz1j+TqPi+pN2ZxIrLTo+DhMjS5e Q9dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=L94X5VouBGZOs6yCeFNN26iQ03su9dHAsSGIuPB7WTQ=; b=AGltoy0XEsIGfmOZkw7Kg8vOmnFQ4kPC5aT8n11y5v8kovcXu2iwW4z4c3GIgIRI1V jR0mUoGwOtYZX1XarDLESjgAFh+zFVmxbabSUj5L8/UnMhebSVDkjZHQW1LovuMfrdOc Y2MuaiBavct2SzgwKlPkBWPBNZdu+ez+WcI9WxSx4WDmZIsYmGKMedkVcLtCXETCQQxG 4REJga4QNYkoBYn2Uflxnb7lnImfgFrlI837FE8lfB9NzNlWoFtCD1BdmE9/IwI2a5Dw HF1UKOfVSiimY7z7+rEH0vDUEBhuYbsH1hCuNVi/EcHC3rjZpwY3e9JAQehEq7XX+t4y 5ocA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=Jw3WtJCj; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id c16-20020aa7c750000000b00418c2b5bd93si21054495eds.117.2022.03.30.13.42.57; Wed, 30 Mar 2022 13:43:11 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=Jw3WtJCj; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5897A68B290; Wed, 30 Mar 2022 23:42:54 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1B09868A77A for ; Wed, 30 Mar 2022 23:42:47 +0300 (EEST) Received: by mail-wm1-f47.google.com with SMTP id bg31-20020a05600c3c9f00b00381590dbb33so774310wmb.3 for ; Wed, 30 Mar 2022 13:42:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=WMKKTVAoJ8C9nPHnz/m9GU+NDC6R8lb3XZsBIL7Jl70=; b=Jw3WtJCj4oWAFv335g4AoDcxhpfCMjOv4FsymBItl3pqviE3Jb6dS2Pz7xj3mp3kAi LnxGZeSfSPjhhi5w6tnaOoCDVmDolg8twe7GA+1VHjhlv21LyueeEPBvkzfy7w3uOMOS q/M+WryzQGe1gi3UdHtKVY2CZNO7P+hGHZLqG9Z9aUJhHnDLidPb2zBCkXwEIVgtmPEu EICwLdJE5XXZcPjIUq6ljWYc2DolHANsdb2zDKBta3PmyRYHM4WnDDmmJDhLdqLONJzG xGy8deghP5gfbT+KSoIwkc7goQddywI61N5JrtOU6jyLbVyEEAh0znEqPZluuYPghmy1 A8xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=WMKKTVAoJ8C9nPHnz/m9GU+NDC6R8lb3XZsBIL7Jl70=; b=XmIYR9AZTk4DP/kS2M3CyhIpBu5g+QBElP2jPgZnWxIcD1Ql5WuY4tbutGF7HYP+rv qczOuw99jh+7cN+K48aOL9/9mTIjs/nYop3T4oO8fqsRAqNZvq3Z8I/j7ba01G/uOYzg TuOouqVWMz/ewmyo/cJJVgs4MV0vHHRtM1wTwCdsq/dBhtfx0L/vutfKRTWVAMaWPW5P RmUMxENhFRSWxhJMCctzlk3FdPqbkYj5oNVQbn9E4rPikKW1j3Sl3a6AIoa8WBkVjURF GlM154hTDeHWsSbiMevUWnqbwLzDAR+A1IwQDvvJ6d0VXMHWUBILA9tBjx1G1AIJzVnB lYIg== X-Gm-Message-State: AOAM530cEQWgUroA2dCJQR3R+b5pCWhIBsiW37M5inMh6HLFmXhxHE9y l5PgwxTNVShMRbj+GRMquiR7gs98qSk= X-Received: by 2002:a1c:cc01:0:b0:37b:dcc8:7dfd with SMTP id h1-20020a1ccc01000000b0037bdcc87dfdmr1334879wmb.134.1648672966483; Wed, 30 Mar 2022 13:42:46 -0700 (PDT) Received: from localhost.localdomain (lputeaux-656-1-153-220.w217-128.abo.wanadoo.fr. [217.128.47.220]) by smtp.gmail.com with ESMTPSA id u11-20020a5d6acb000000b002058148822bsm25520456wrw.63.2022.03.30.13.42.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 13:42:46 -0700 (PDT) From: Matthieu Bouron To: ffmpeg-devel@ffmpeg.org Date: Wed, 30 Mar 2022 22:42:39 +0200 Message-Id: <20220330204239.212305-1-matthieu.bouron@gmail.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec_common: stop the codec before releasing it X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Matthieu Bouron Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: gJ8Kdz+SRFrF Fixes the following warnings/errors on codec release: E/BufferQueueProducer: [SurfaceTexture-0-31763-0](id:7c1300000001,api:3,p:31763,c:31763) detachBuffer: slot 0 is not owned by the producer (state = FREE) E/BufferQueueProducer: [SurfaceTexture-0-31763-0](id:7c1300000001,api:3,p:31763,c:31763) detachBuffer: slot 1 is not owned by the producer (state = FREE) E/BufferQueueProducer: [SurfaceTexture-0-31763-0](id:7c1300000001,api:3,p:31763,c:31763) detachBuffer: slot 2 is not owned by the producer (state = FREE) [...] --- libavcodec/mediacodecdec_common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/mediacodecdec_common.c b/libavcodec/mediacodecdec_common.c index cb18aed401..d99881c11f 100644 --- a/libavcodec/mediacodecdec_common.c +++ b/libavcodec/mediacodecdec_common.c @@ -232,6 +232,7 @@ static void ff_mediacodec_dec_unref(MediaCodecDecContext *s) if (atomic_fetch_sub(&s->refcount, 1) == 1) { if (s->codec) { + ff_AMediaCodec_stop(s->codec); ff_AMediaCodec_delete(s->codec); s->codec = NULL; }