diff mbox series

[FFmpeg-devel] avformat/webmdashenc: fix on-demand profile string

Message ID 20220408005759.12544-1-jamrial@gmail.com
State Accepted
Commit 487b49d8f2e1e81dce86230fc957ca2ee9de00ee
Headers show
Series [FFmpeg-devel] avformat/webmdashenc: fix on-demand profile string | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 fail Make fate failed
andriy/make_x86 success Make finished
andriy/make_fate_x86 fail Make fate failed
andriy/make_armv7_RPi4 success Make finished
andriy/make_fate_armv7_RPi4 fail Make fate failed

Commit Message

James Almer April 8, 2022, 12:57 a.m. UTC
Fixes ticket #9596

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavformat/webmdashenc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jun Zhao April 8, 2022, 3:02 a.m. UTC | #1
On Fri, Apr 8, 2022 at 8:58 AM James Almer <jamrial@gmail.com> wrote:
>
> Fixes ticket #9596
>
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavformat/webmdashenc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/webmdashenc.c b/libavformat/webmdashenc.c
> index a942c484e9..f8f2274556 100644
> --- a/libavformat/webmdashenc.c
> +++ b/libavformat/webmdashenc.c
> @@ -95,7 +95,7 @@ static int write_header(AVFormatContext *s)
>      }
>      avio_printf(pb, "  minBufferTime=\"PT%gS\"\n", min_buffer_time);
>      avio_printf(pb, "  profiles=\"%s\"%s",
> -                w->is_live ? "urn:mpeg:dash:profile:isoff-live:2011" : "urn:webm:dash:profile:webm-on-demand:2012",
> +                w->is_live ? "urn:mpeg:dash:profile:isoff-live:2011" : "urn:mpeg:dash:profile:webm-on-demand:2012",
>                  w->is_live ? "\n" : ">\n");
>      if (w->is_live) {
>          time_t local_time = time(NULL);
LGTM.
Hendrik Leppkes April 8, 2022, 6:14 a.m. UTC | #2
On Fri, Apr 8, 2022 at 2:58 AM James Almer <jamrial@gmail.com> wrote:
>
> Fixes ticket #9596
>
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavformat/webmdashenc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/webmdashenc.c b/libavformat/webmdashenc.c
> index a942c484e9..f8f2274556 100644
> --- a/libavformat/webmdashenc.c
> +++ b/libavformat/webmdashenc.c
> @@ -95,7 +95,7 @@ static int write_header(AVFormatContext *s)
>      }
>      avio_printf(pb, "  minBufferTime=\"PT%gS\"\n", min_buffer_time);
>      avio_printf(pb, "  profiles=\"%s\"%s",
> -                w->is_live ? "urn:mpeg:dash:profile:isoff-live:2011" : "urn:webm:dash:profile:webm-on-demand:2012",
> +                w->is_live ? "urn:mpeg:dash:profile:isoff-live:2011" : "urn:mpeg:dash:profile:webm-on-demand:2012",
>                  w->is_live ? "\n" : ">\n");
>      if (w->is_live) {
>          time_t local_time = time(NULL);
> --
> 2.35.1


This needs FATE updates now, got a bit yellow around there.

- Hendrik
diff mbox series

Patch

diff --git a/libavformat/webmdashenc.c b/libavformat/webmdashenc.c
index a942c484e9..f8f2274556 100644
--- a/libavformat/webmdashenc.c
+++ b/libavformat/webmdashenc.c
@@ -95,7 +95,7 @@  static int write_header(AVFormatContext *s)
     }
     avio_printf(pb, "  minBufferTime=\"PT%gS\"\n", min_buffer_time);
     avio_printf(pb, "  profiles=\"%s\"%s",
-                w->is_live ? "urn:mpeg:dash:profile:isoff-live:2011" : "urn:webm:dash:profile:webm-on-demand:2012",
+                w->is_live ? "urn:mpeg:dash:profile:isoff-live:2011" : "urn:mpeg:dash:profile:webm-on-demand:2012",
                 w->is_live ? "\n" : ">\n");
     if (w->is_live) {
         time_t local_time = time(NULL);