From patchwork Tue May 3 16:13:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Traian Coza X-Patchwork-Id: 35575 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:a885:b0:7f:4be2:bd17 with SMTP id ca5csp497207pzb; Tue, 3 May 2022 09:15:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUtNSBE0z14cFuQcmktN0Z3KBzdeCNwV1fa2tF2Jxw3DlxLvVix0Q3xIv2HsP++VMfm8fI X-Received: by 2002:a17:907:6e1d:b0:6f4:60e6:9fa6 with SMTP id sd29-20020a1709076e1d00b006f460e69fa6mr8040675ejc.184.1651594555637; Tue, 03 May 2022 09:15:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651594555; cv=none; d=google.com; s=arc-20160816; b=Qc757scXFY4w/96S+dQK1kvJzzxT7nujno7Om3B0BNPWd29TWjgNoYUQXjVxeIx5Fk kpIGFu5/wMGMN/OfTSXVt4XzauPMaa/4gE0OxIL0CU8GN0G1Y7sY4nBcTo5dtU1FxBbL cKLohjbWkOl8IJNPNJVNjtvO4SHOUHO9B8gxo8daqXhQ3lBQZkn62oniCJP6cZ5QQGSQ foJ4VgkCrKgDDD8T1KRiAcSR5lS/7b8Q+1bRDRzcHZlsi+9Or65FsSV9PhUAPvjoFXNg VTc+qYbHoYejoY4Pm5GpSn4g1qlYBNv7N88LdM37vxCnSgwBPa4qA2V5mRYGwGK1WHjF ppoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to; bh=xqcO1YgNreUEOY417ReKdSgbigTdoEk+hXUOGuZzFpk=; b=RABQYfDKEgH2lkwW8fORcljEsUj/5GPBJS6lD0BOOYRzoysHI/j2gSjI5ZD/yit4CO bm3SEIQgm9lv54fAZSv8aU3lppP1RChP1GnMuOYu1/gCZEHrPNO2zMVqp0aen1tTFfk0 whlH4Ksq1LKFNYmTIcrtuxB4xbaUhC/cN2jO2uVYKCNUQ8v/buO+nqSKHFtvEgHXpOTa qDoJfXtkb1x4HXO0AfPRsQ9t+yJht2DlOCjwG+nqr8mBw9NAcepqP8cxVNdOWMEfXKx9 HS7xoZetwsFWObjLR94Xw1be1XH33B7WOhnJb7DBUujAnYGu/9/5j6eUKuSuyAf88Xa7 ocPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b="La6/NeAt"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id fe5-20020a1709072a4500b006f396dc0ad3si13479381ejc.266.2022.05.03.09.15.55; Tue, 03 May 2022 09:15:55 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b="La6/NeAt"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 33ECC68B3E1; Tue, 3 May 2022 19:14:07 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4E86F68B3BB for ; Tue, 3 May 2022 19:14:01 +0300 (EEST) Received: by mail-qt1-f172.google.com with SMTP id h3so9262988qtn.4 for ; Tue, 03 May 2022 09:14:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NfIgOzyaw8pW9qTR/AXEV6xp3G7BYhhXgdd8k1Ctd5M=; b=La6/NeAta1kyt8LjRYfLDB5MK7b97Vt/JS/mESB+OV2utIxGtlsiV5eeG4GJxmxntw vUcF9xDMkuR1nevqxozMvAbI3Gy0RHcsZ2gf87mXt9ub9Ou8FKNzPuDvSRbthjnsHXLx m8PNsa+r2Z5U3v4HNrw+ytX4FJ/2I5PNFHPKxfwg7TwxviSWMRYDcLOKKgkZ0YHzFill 79KYhDESjfzV5SJTO0TzrIvJOpmrbCWNBX4DgXmHoQcSU71FwyLFiP8MgDa9sRJJeSO1 kJAF4IUk/YyVM+dCJNegUFUfwIcNvjswzkbAY2P7hBVeTCCVIhAidG1yPHCBkY2VHVFi wAWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NfIgOzyaw8pW9qTR/AXEV6xp3G7BYhhXgdd8k1Ctd5M=; b=2NCdiuEU4VSs+zd37wGG9Pes3K6zut51Cx9wBsR5wDXpr67NbtX5HVBow6NzyIKv5B qqk7ZfGcsrBT+1nDeuZE4tJXdkkZfiAex144fEr62/lWHgEDHy2MRg1gFbRNeIdasgtD 9GtShe39+d+o0xnPYFlDNyeh+CJXWvmedQ7Ys/xnwwRJxc57rLf6jZGwt0FhxaKCtsZ5 qBWwF53lY7KgBFRahZ9qk022E2ELBiVYfDXyAgV6S8KPyhVC9JZ5l51BQVXDr7B0KpRw eSy1uS50HyS7Ov3hsKWGX0p9PmfoQBEBaGbrWB42PzaF7fsyxmzXPkJ0gKBkbJzZ2BSq 4V3w== X-Gm-Message-State: AOAM533uOEn8mODQlpJQcdPFabH45Yt6Y1LPwkNZmL8p390xOzrHovtg 7Z3zNqsl9fErm75hjdWTWltC/RBTc/Ix X-Received: by 2002:a05:622a:1451:b0:2f3:9e80:9b56 with SMTP id v17-20020a05622a145100b002f39e809b56mr13107196qtx.490.1651594439749; Tue, 03 May 2022 09:13:59 -0700 (PDT) Received: from thinkpad.. ([66.220.203.136]) by smtp.gmail.com with ESMTPSA id fp35-20020a05622a50a300b002f39b99f67asm5812731qtb.20.2022.05.03.09.13.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 09:13:59 -0700 (PDT) From: Traian Coza To: ffmpeg-devel@ffmpeg.org Date: Tue, 3 May 2022 12:13:28 -0400 Message-Id: <20220503161328.842587-13-traian.coza@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220503161328.842587-1-traian.coza@gmail.com> References: <20220503161328.842587-1-traian.coza@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 12/12] Added more logging X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Traian Coza Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: G9G7UwN7IcYI --- fftools/text_to_bitmap.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fftools/text_to_bitmap.c b/fftools/text_to_bitmap.c index 0f165e7722..e05e485713 100644 --- a/fftools/text_to_bitmap.c +++ b/fftools/text_to_bitmap.c @@ -122,7 +122,8 @@ void init_ass_context(InputStream *ist, OutputStream *ost) } if (width && height) break; - // TODO Error: Cannot render without a width and height + av_log(NULL, AV_LOG_ERROR, "Cannot render text subtitle without frame size\n"); + return; } while (0); context->renderer = ass_renderer_init(context->library); @@ -197,7 +198,8 @@ void render_avsub_ass(ASS_Context *context, AVSubtitle *sub) ASS_Image *image = ass_render_frame(context->renderer, track, track->events[0].Start + track->events[0].Duration / 2, NULL); - if (image == NULL) av_log(NULL, AV_LOG_WARNING, "failed to render ass\n"); + if (image == NULL) av_log(NULL, AV_LOG_WARNING, + "failed to render ass: %s\n", rect->ass); rect->x = image ? image->dst_x : 0; rect->w = 0; rect->y = image ? image->dst_y : 0; rect->h = 0;