From patchwork Thu May 5 13:50:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Izen X-Patchwork-Id: 35605 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:a885:b0:7f:4be2:bd17 with SMTP id ca5csp1091097pzb; Thu, 5 May 2022 06:51:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyIGFpOWMyDAQXREjovJlHQVW3Gma+3oIdiLXR5vsPaswMyUuwNAOfsy3otomoxuobaUGKo X-Received: by 2002:aa7:dbc5:0:b0:423:f451:bb50 with SMTP id v5-20020aa7dbc5000000b00423f451bb50mr29626885edt.79.1651758701510; Thu, 05 May 2022 06:51:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651758701; cv=none; d=google.com; s=arc-20160816; b=DilOORWr/0/tvqshuPFwNlHmVmH5No/cG/eWW37qLG+7Nvtq5+6e54ID6bixbNALEj Ze7AEIzAbILJKiaIZ/S1Oiq7Ua/JA3PNh/JhmPGp81ZqP+WrweFcXajGBXpxJ7FtHbdh PVzevnNkv4tLkAhSUMf8OASU1gNaUUVe19hxPiHU0FTZxRrCdoYkYV4cPhZ+atnIoxti QE9Xb/3PwKxiDq+9RJjAls6n8gsXZ02u0yWxSdT62I3DOSGGLBtctRmLAYMHQcOj5KHg s3RaP1To13a1mhGDj/jzXWkGaUyisP9F6odQ0q9kMVbIISM62KWnFon29jbmNQvxURKi 2DpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to; bh=O/j8MTPkYw3ixUPQL4gUpcSr1oF0oo9i0J+D431OfsM=; b=cmL8x4rgbVQB7EbjM5BQNooGQs9eVGv6onBrKsPGCwyCWSIzLj/WTxwh3oE8UG2k5w yYRh4qgpJCQ8epU16IiXY2077IMLgDW/KDSdBG6Ufb1inBO2Klq7pTuoU8794w4Qy1K3 BAjSTEufMDnayz1Qk9LOL9tInBKlf0AQZJpBlajwgPC8HOzTQKr771oJR//jooem27qu 902wVz/1bZNQtlRDqK3omxrDz9XnRvk6pjipJVLZUzfmL7r790Fjd4S6rMIcV5Uth8MA JSnxzXqSfdYoXzf9teW40Yhdmjc1JgCpygYcVkf3oG4lzFCgNK4o6WIM0MA/Qc3oUvVu 9vbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=Dam0IVJx; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id dk14-20020a0564021d8e00b0041d71bccc73si1613152edb.244.2022.05.05.06.51.41; Thu, 05 May 2022 06:51:41 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=Dam0IVJx; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2671668B03C; Thu, 5 May 2022 16:51:33 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-il1-f182.google.com (mail-il1-f182.google.com [209.85.166.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1741368B344 for ; Thu, 5 May 2022 16:51:25 +0300 (EEST) Received: by mail-il1-f182.google.com with SMTP id l15so2871751ilh.3 for ; Thu, 05 May 2022 06:51:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F99bcs+s+87OLo73egEeJGe3P2JILSiIbS8yphrR53g=; b=Dam0IVJx18p0gBIPwrqymEAdsGDUkt93TtZQfQa1+BuhHWwEsJYsGC4ZOROKMS+tVu qWLYU/CkG1Y8G1IfA4b+DQX46aBdV4uPArVPVDH3/P6f6E+ogG95gP2cOjgjALJ3sJfr NpAvpMrqlCjgwmBatv0xvPQwv0CDlhxhXsMrnMEQsjlPM3mXELvgJqUvSvq7TdExTBCT DbyRWSs0byvMEAUpkyOWV+mdiXDsNlzQrW4WxyUMRD7e8A0a3kupkgHioxQUhnHN5tkV WkMWdDB2ValwvlLGm8H6aZX73hFm+79p75BTTkQrcDNEe6ry0DPQU9dWSttv0yex8SBS IOYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F99bcs+s+87OLo73egEeJGe3P2JILSiIbS8yphrR53g=; b=v28ia7hhAjyt92SAFqYUFSaa1S5rqgzm9EtScO7o/plZaMtVwi2YWeeHx6MPspJlqA gTADJrjOw1r8gcK8/8HqkneAZ7UDmHv4cbsPbF2cHTiDPirjDiVg8eOP/t38YBMEihVe k485/awhfqi0RvFN39bXFaykLWPVLH4nxBMVIB/L5Ed0uqi9865K7+kQcAmKVWkaFvSR 4Q8S4tBUkTtmJvT62LPLFlsnfVgiz+m5TQCFSzTLzRYBaUmNbpxZDuH5dg0R1eoDv87U 8cgREwEIlt0NH1JCKlEhphyoj+bqJyCn9zs+jTL97N+XjYH1JvU5tZ9ThndQ3sv5Si7i x6ig== X-Gm-Message-State: AOAM533wAoHFu0Y03eVwfgpPmlyYzOsvx5jsRYfQj3A0tN//xRM6KUpu Qa8zUtWUsVinpt23N9VQmQDIHFyJTFQ= X-Received: by 2002:a92:3609:0:b0:2c6:3595:2a25 with SMTP id d9-20020a923609000000b002c635952a25mr11034167ila.233.1651758683583; Thu, 05 May 2022 06:51:23 -0700 (PDT) Received: from gauss.local (c-68-41-54-207.hsd1.mi.comcast.net. [68.41.54.207]) by smtp.gmail.com with ESMTPSA id h29-20020a022b1d000000b0032b3a78178csm502251jaa.80.2022.05.05.06.51.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 06:51:23 -0700 (PDT) From: Leo Izen To: ffmpeg-devel@ffmpeg.org Date: Thu, 5 May 2022 09:50:55 -0400 Message-Id: <20220505135056.19268-2-leo.izen@gmail.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220505135056.19268-1-leo.izen@gmail.com> References: <20220505135056.19268-1-leo.izen@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v5 1/2] avcodec/libjxldec: properly tag output colorspace X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Leo Izen Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: dSjeqVm6MLm9 Whether an ICC profile is present or not, the decoder should now properly tag the colorspace of pixel data received by the decoder. --- libavcodec/libjxldec.c | 113 ++++++++++++++++++++++++++++++++++++++--- 1 file changed, 105 insertions(+), 8 deletions(-) diff --git a/libavcodec/libjxldec.c b/libavcodec/libjxldec.c index cd4bca3343..813ee279fe 100644 --- a/libavcodec/libjxldec.c +++ b/libavcodec/libjxldec.c @@ -135,6 +135,7 @@ static int libjxl_decode_frame(AVCodecContext *avctx, AVFrame *frame, int *got_f uint8_t *buf = avpkt->data; size_t remaining = avpkt->size, iccp_len; JxlDecoderStatus jret; + JxlColorEncoding jxl_encoding; int ret; *got_frame = 0; @@ -189,16 +190,112 @@ static int libjxl_decode_frame(AVCodecContext *avctx, AVFrame *frame, int *got_f continue; case JXL_DEC_COLOR_ENCODING: av_log(avctx, AV_LOG_DEBUG, "COLOR_ENCODING event emitted\n"); - jret = JxlDecoderGetICCProfileSize(ctx->decoder, &ctx->jxl_pixfmt, JXL_COLOR_PROFILE_TARGET_ORIGINAL, &iccp_len); - if (jret == JXL_DEC_SUCCESS && iccp_len > 0) { - av_buffer_unref(&ctx->iccp); - ctx->iccp = av_buffer_alloc(iccp_len); - if (!ctx->iccp) - return AVERROR(ENOMEM); - jret = JxlDecoderGetColorAsICCProfile(ctx->decoder, &ctx->jxl_pixfmt, JXL_COLOR_PROFILE_TARGET_ORIGINAL, ctx->iccp->data, iccp_len); - if (jret != JXL_DEC_SUCCESS) + jret = JxlDecoderGetColorAsEncodedProfile(ctx->decoder, NULL, JXL_COLOR_PROFILE_TARGET_ORIGINAL, &jxl_encoding); + if (jret == JXL_DEC_SUCCESS) + jret = JxlDecoderSetPreferredColorProfile(ctx->decoder, &jxl_encoding); + if (jret == JXL_DEC_SUCCESS) + jret = JxlDecoderGetColorAsEncodedProfile(ctx->decoder, &ctx->jxl_pixfmt, JXL_COLOR_PROFILE_TARGET_DATA, &jxl_encoding); + + avctx->color_range = frame->color_range = AVCOL_RANGE_JPEG; + + if (jret == JXL_DEC_SUCCESS) { + if (ctx->jxl_pixfmt.num_channels >= 3) { + avctx->colorspace = AVCOL_SPC_RGB; + switch (jxl_encoding.primaries) { + case JXL_PRIMARIES_SRGB: + avctx->color_primaries = AVCOL_PRI_BT709; + break; + case JXL_PRIMARIES_2100: + /* BT2020 and BT2100 use the same primaries */ + avctx->color_primaries = AVCOL_PRI_BT2020; + break; + case JXL_PRIMARIES_P3: + /* DCI P3 uses DCI, Display P3 uses D65 */ + if (jxl_encoding.white_point == JXL_WHITE_POINT_DCI) { + avctx->color_primaries = AVCOL_PRI_SMPTE431; + } else if (jxl_encoding.white_point == JXL_WHITE_POINT_D65) { + avctx->color_primaries = AVCOL_PRI_SMPTE432; + } else { + av_log(avctx, AV_LOG_WARNING, "Unsupported JXL white point: %d\n", jxl_encoding.white_point); + jret = JXL_DEC_ERROR; + } + break; + case JXL_PRIMARIES_CUSTOM: + av_log(avctx, AV_LOG_WARNING, "Custom primaries are unsupported without an ICC profile\n"); + jret = JXL_DEC_ERROR; + break; + default: + av_log(avctx, AV_LOG_WARNING, "Unknown JXL color primaries: %d\n", jxl_encoding.primaries); + jret = JXL_DEC_ERROR; + } + } + + switch (jxl_encoding.transfer_function) { + case JXL_TRANSFER_FUNCTION_709: + avctx->color_trc = AVCOL_TRC_BT709; + break; + case JXL_TRANSFER_FUNCTION_LINEAR: + avctx->color_trc = AVCOL_TRC_LINEAR; + break; + case JXL_TRANSFER_FUNCTION_SRGB: + avctx->color_trc = AVCOL_TRC_IEC61966_2_1; + break; + case JXL_TRANSFER_FUNCTION_PQ: + avctx->color_trc = AVCOL_TRC_SMPTE2084; + break; + case JXL_TRANSFER_FUNCTION_DCI: + avctx->color_trc = AVCOL_TRC_SMPTE428; + break; + case JXL_TRANSFER_FUNCTION_HLG: + avctx->color_trc = AVCOL_TRC_ARIB_STD_B67; + break; + case JXL_TRANSFER_FUNCTION_GAMMA: + if (jxl_encoding.gamma == 2.2) { + avctx->color_trc = AVCOL_TRC_GAMMA22; + } else if (jxl_encoding.gamma == 2.8) { + avctx->color_trc = AVCOL_TRC_GAMMA28; + } else { + av_log(avctx, AV_LOG_WARNING, "Unsupported gamma transfer: %f\n", jxl_encoding.gamma); + jret = JXL_DEC_ERROR; + } + break; + default: + av_log(avctx, AV_LOG_WARNING, "Unknown transfer function: %d\n", jxl_encoding.transfer_function); + jret = JXL_DEC_ERROR; + } + } + + /* fall back on ICCP if enum values fail */ + if (jret != JXL_DEC_SUCCESS) { + jret = JxlDecoderGetICCProfileSize(ctx->decoder, &ctx->jxl_pixfmt, JXL_COLOR_PROFILE_TARGET_DATA, &iccp_len); + if (jret == JXL_DEC_SUCCESS && iccp_len > 0) { av_buffer_unref(&ctx->iccp); + ctx->iccp = av_buffer_alloc(iccp_len); + if (!ctx->iccp) + return AVERROR(ENOMEM); + jret = JxlDecoderGetColorAsICCProfile(ctx->decoder, &ctx->jxl_pixfmt, JXL_COLOR_PROFILE_TARGET_DATA, ctx->iccp->data, iccp_len); + if (jret != JXL_DEC_SUCCESS) { + av_log(avctx, AV_LOG_WARNING, "Unable to obtain ICCP from header\n"); + av_buffer_unref(&ctx->iccp); + } + } } + + if (ctx->iccp) { + /* if the ICCP is present, libjxl outputs sRGB */ + if (ctx->jxl_pixfmt.num_channels >= 3) { + avctx->colorspace = AVCOL_SPC_RGB; + avctx->color_primaries = AVCOL_PRI_BT709; + } + /* linear sRGB if float values, standard sRGB if int values */ + avctx->color_trc = ctx->jxl_pixfmt.data_type == JXL_TYPE_FLOAT + || ctx->jxl_pixfmt.data_type == JXL_TYPE_FLOAT16 + ? AVCOL_TRC_LINEAR : AVCOL_TRC_IEC61966_2_1; + } + + frame->color_trc = avctx->color_trc; + frame->color_primaries = avctx->color_primaries; + frame->colorspace = avctx->colorspace; continue; case JXL_DEC_NEED_IMAGE_OUT_BUFFER: av_log(avctx, AV_LOG_DEBUG, "NEED_IMAGE_OUT_BUFFER event emitted\n");