From patchwork Fri May 6 05:57:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Wu, Tong1" X-Patchwork-Id: 35612 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:a885:b0:7f:4be2:bd17 with SMTP id ca5csp1491175pzb; Thu, 5 May 2022 22:57:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzmi9U1ybipZ6KMSa0A99L+BD6w0kthELdiJ2tjRqvhjYMCobyh/Fi0HJhMDL9jnNu+2Xc4 X-Received: by 2002:a17:906:c115:b0:6f3:c010:61a6 with SMTP id do21-20020a170906c11500b006f3c01061a6mr1477722ejc.231.1651816660828; Thu, 05 May 2022 22:57:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651816660; cv=none; d=google.com; s=arc-20160816; b=0eg3hcIzrvgv1kx2QrCNRWVHnGvFpu2XRCZ15ipsd/MVJDG2tf3lYwN6x/U2RfRmPD MCxBqyXy665dlI1QFdZBUyhS3FA2CRP/t9Zmw5kWW8e1IBEi1ws+PFu3Tlu43g/ZOsDF vAuk2R+ufVOwMjeDjBGzJ+oxwMPDNochLH4EmSOIu1njvsDGxRQqoYX6gZ44qaATY1na cfaTPNRmi4Wh+zHaGjeTuDbLcT6CVGMHok27/CUjE8nZC3rl0pQujiMzrsqpjkN+C6FZ X9PTqpJp15ui1PQ4mvwgqP0vXf7tptdyuBDCqm4487yGfnbgoYJpPd4IP+wD0GmClXUd go3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to; bh=Nv0Wo2n06Rt1KaVAbnsbrVKbWnrklswBCLYUpcwhWmM=; b=bglZGSObrXc+n1GFQS5ZAqh4qkyZKAKaF1182Y1ILB/h3W+MCOWkTjhNWjOiLctHnu icO+52YvUjD6P0T7AloaEMmBkbUeyPjws2N5c9IXaSkXU5a/vq0DCwCqTrr6+0M5XQcf EaZlzB2PeeEdXzizSyKE2OuiQPo56UOkRVwuEIUZPx+dNHYOp7zKp1579EeKPdLRcpw8 7cUQ7TxL/BUn5mCMrPc0dL03i5Rv8HnQDCDmQO9Qy++17EbKtR5APog7MGRjv7opZTSZ KE2ojHs+YQiJMreKS0fe7N0dlDn6qqsoLYuL+IZ9dFxrnqRj6wpeSd+UvsYlwPmC5tnT 64dA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b="TIf/Oofm"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id z8-20020a1709063ac800b006e74fd3551asi4043659ejd.525.2022.05.05.22.57.40; Thu, 05 May 2022 22:57:40 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b="TIf/Oofm"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6190968B2F7; Fri, 6 May 2022 08:57:31 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 87C9A68B192 for ; Fri, 6 May 2022 08:57:23 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651816648; x=1683352648; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Fvpof9+HfrCqRgzsbIqhU0SdoG0zrYEEwBILZu8iV3E=; b=TIf/OofmxjXWiL5jPXeARxZl5k62exmWKQdZzV1cClqvXV6sILmVCKPF tHj9OhcNawuu7Jx9yv0TG/qhE3ZKdbJC/lAZYVw7ISd2wP5WbqPPfM+V7 9Ra+h+doBF2t8b/f44x7AN/BOTqX7s5Ccp5htrhkfw/p6FTt2BC58Li/8 Mzg3IrZxuGulD9YWU3M+gSJBUu9w3ULBN73piqHtHVqy5Nk5Pbu/FNxiU RKyFMHXWTg0O9AqZSLrpBFnPuXlyUm8+EmkMSnVUuk6vSrECJeqemCRq7 EDQuidL+tYdttpiVDaKt/jzack/Flnp4YGF+aQ6UHUUpuEn5XDsXGpIqX Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10338"; a="267201059" X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="267201059" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 22:57:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="568953776" Received: from gtapc.iind.intel.com (HELO localhost.localdomain) ([10.190.234.85]) by fmsmga007.fm.intel.com with ESMTP; 05 May 2022 22:57:19 -0700 From: Tong Wu To: ffmpeg-devel@ffmpeg.org Date: Fri, 6 May 2022 05:57:10 +0000 Message-Id: <20220506055711.1671-2-tong1.wu@intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220506055711.1671-1-tong1.wu@intel.com> References: <20220506055711.1671-1-tong1.wu@intel.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v4 2/3] avutil/hwcontext_d3d11va: pass the format value from outside for staging texture X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Tong Wu Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: dwm+Jgn0eo/i In d3d11va_create_staging_texture(), during the hwmap process, the ctx->internal->priv is not initialized, resulting in the texDesc.Format not initialized. Now pass the format value from d3d11va_transfer_data() to fix it. $ ffmpeg.exe -y -hwaccel qsv -init_hw_device d3d11va=d3d11 \ -init_hw_device qsv=qsv@d3d11 -c:v h264_qsv \ -i input.h264 -vf "hwmap=derive_device=d3d11va,format=d3d11,hwdownload,format=nv12" \ -f null - Signed-off-by: Tong Wu --- libavutil/hwcontext_d3d11va.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavutil/hwcontext_d3d11va.c b/libavutil/hwcontext_d3d11va.c index 2b4e24bb56..bb4e9d6965 100644 --- a/libavutil/hwcontext_d3d11va.c +++ b/libavutil/hwcontext_d3d11va.c @@ -346,7 +346,7 @@ static int d3d11va_transfer_get_formats(AVHWFramesContext *ctx, return 0; } -static int d3d11va_create_staging_texture(AVHWFramesContext *ctx) +static int d3d11va_create_staging_texture(AVHWFramesContext *ctx, DXGI_FORMAT format) { AVD3D11VADeviceContext *device_hwctx = ctx->device_ctx->hwctx; D3D11VAFramesContext *s = ctx->internal->priv; @@ -355,7 +355,7 @@ static int d3d11va_create_staging_texture(AVHWFramesContext *ctx) .Width = ctx->width, .Height = ctx->height, .MipLevels = 1, - .Format = s->format, + .Format = format, .SampleDesc = { .Count = 1 }, .ArraySize = 1, .Usage = D3D11_USAGE_STAGING, @@ -411,7 +411,8 @@ static int d3d11va_transfer_data(AVHWFramesContext *ctx, AVFrame *dst, device_hwctx->lock(device_hwctx->lock_ctx); if (!s->staging_texture) { - int res = d3d11va_create_staging_texture(ctx); + ID3D11Texture2D_GetDesc((ID3D11Texture2D *)texture, &desc); + int res = d3d11va_create_staging_texture(ctx, desc.Format); if (res < 0) return res; }