diff mbox series

[FFmpeg-devel] avfilter/avf_showfreqs: fix memleak in plot_freqs

Message ID 20220513021924.64854-1-lq@chinaffmpeg.org
State Accepted
Commit 90007e0b4e1b92674097dcc897a29bf8cb49cc3e
Headers show
Series [FFmpeg-devel] avfilter/avf_showfreqs: fix memleak in plot_freqs | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Liu Steven May 13, 2022, 2:19 a.m. UTC
plot_freqs should free colors before return error when
ff_get_video_buffer failed

Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
---
 libavfilter/avf_showfreqs.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/libavfilter/avf_showfreqs.c b/libavfilter/avf_showfreqs.c
index 6dcff686b6..86a67c7328 100644
--- a/libavfilter/avf_showfreqs.c
+++ b/libavfilter/avf_showfreqs.c
@@ -421,8 +421,10 @@  static int plot_freqs(AVFilterLink *inlink, int64_t pts)
         return AVERROR(ENOMEM);
 
     out = ff_get_video_buffer(outlink, outlink->w, outlink->h);
-    if (!out)
+    if (!out) {
+        av_free(colors);
         return AVERROR(ENOMEM);
+    }
 
     for (n = 0; n < outlink->h; n++)
         memset(out->data[0] + out->linesize[0] * n, 0, outlink->w * 4);